[INFO] fetching crate ipstack 0.1.0... [INFO] checking ipstack-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ipstack 0.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ipstack 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ipstack 0.1.0 [INFO] finished tweaking crates.io crate ipstack 0.1.0 [INFO] tweaked toml for crates.io crate ipstack 0.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate ipstack 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b4cff6f546a6fd984acdb0d8c068a4244f03b8a817f6336af277efc16dd2f9fc [INFO] running `Command { std: "docker" "start" "-a" "b4cff6f546a6fd984acdb0d8c068a4244f03b8a817f6336af277efc16dd2f9fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b4cff6f546a6fd984acdb0d8c068a4244f03b8a817f6336af277efc16dd2f9fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b4cff6f546a6fd984acdb0d8c068a4244f03b8a817f6336af277efc16dd2f9fc", kill_on_drop: false }` [INFO] [stdout] b4cff6f546a6fd984acdb0d8c068a4244f03b8a817f6336af277efc16dd2f9fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c697ec71eb79741af99f56e6c9a3300232e58c448e1bb1cdaf9e44a6b006f80 [INFO] running `Command { std: "docker" "start" "-a" "5c697ec71eb79741af99f56e6c9a3300232e58c448e1bb1cdaf9e44a6b006f80", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking clap_builder v4.5.10 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking ioctl-sys v0.8.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking etherparse v0.15.0 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking env_filter v0.1.1 [INFO] [stderr] Checking env_logger v0.11.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking tokio v1.39.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking clap v4.5.10 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking udp-stream v0.0.12 [INFO] [stderr] Checking ipstack v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:128:18 [INFO] [stdout] | [INFO] [stdout] 116 | mut device: D, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | accept_sender: UnboundedSender, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let mut sessions: SessionCollection = AHashMap::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let (pkt_sender, mut pkt_receiver) = mpsc::unbounded_channel::(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | [INFO] [stdout] 128 | tokio::spawn(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 129 | | loop { [INFO] [stdout] 130 | | select! { [INFO] [stdout] 131 | | Ok(n) = device.read(&mut buffer) => { [INFO] [stdout] ... | [INFO] [stdout] 152 | | } [INFO] [stdout] 153 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/tcp.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 61 | packet_sender: PacketSender, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | stream_receiver: PacketReceiver, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | let stream = IpStackTcpStream { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Err(IpStackError::InvalidTcpPacket) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/tcp.rs:426:21 [INFO] [stdout] | [INFO] [stdout] 426 | Poll::Ready(Ok(payload_len)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/tcp_wrapper.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 21 | pkt_sender: PacketSender, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let (stream_sender, stream_receiver) = mpsc::unbounded_channel::(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | / IpStackTcpStreamInner::new( [INFO] [stdout] 27 | | local_addr, [INFO] [stdout] 28 | | peer_addr, [INFO] [stdout] 29 | | tcp, [INFO] [stdout] ... | [INFO] [stdout] 33 | | tcp_timeout, [INFO] [stdout] 34 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/tcp_wrapper.rs:35:14 [INFO] [stdout] | [INFO] [stdout] 21 | pkt_sender: PacketSender, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let (stream_sender, stream_receiver) = mpsc::unbounded_channel::(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | .map(|inner| IpStackTcpStream { [INFO] [stdout] | ______________^ [INFO] [stdout] 36 | | inner: Some(Box::new(inner)), [INFO] [stdout] 37 | | peer_addr, [INFO] [stdout] 38 | | local_addr, [INFO] [stdout] 39 | | stream_sender, [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/tcp_wrapper.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 25 | let (stream_sender, stream_receiver) = mpsc::unbounded_channel::(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | .map(|inner| IpStackTcpStream { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | inner: Some(Box::new(inner)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/udp.rs:44:22 [INFO] [stdout] | [INFO] [stdout] 31 | pkt_sender: PacketSender, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let (stream_sender, stream_receiver) = mpsc::unbounded_channel::(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | timeout: Box::pin(tokio::time::sleep_until(deadline)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream/udp.rs:162:32 [INFO] [stdout] | [INFO] [stdout] 162 | std::task::Poll::Ready(Ok(payload_len)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ipstack` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5c697ec71eb79741af99f56e6c9a3300232e58c448e1bb1cdaf9e44a6b006f80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c697ec71eb79741af99f56e6c9a3300232e58c448e1bb1cdaf9e44a6b006f80", kill_on_drop: false }` [INFO] [stdout] 5c697ec71eb79741af99f56e6c9a3300232e58c448e1bb1cdaf9e44a6b006f80