[INFO] fetching crate ippacket 0.1.0... [INFO] checking ippacket-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ippacket 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ippacket 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ippacket 0.1.0 [INFO] finished tweaking crates.io crate ippacket 0.1.0 [INFO] tweaked toml for crates.io crate ippacket 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] baed35294ce1eb1cec437075436382faa1093e5a4bb3650673c477b11d3dc404 [INFO] running `Command { std: "docker" "start" "-a" "baed35294ce1eb1cec437075436382faa1093e5a4bb3650673c477b11d3dc404", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "baed35294ce1eb1cec437075436382faa1093e5a4bb3650673c477b11d3dc404", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "baed35294ce1eb1cec437075436382faa1093e5a4bb3650673c477b11d3dc404", kill_on_drop: false }` [INFO] [stdout] baed35294ce1eb1cec437075436382faa1093e5a4bb3650673c477b11d3dc404 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ccd89582c72081252275f2f5e5f9ce668682dcdb9a61aaaf04ace21d265d06cc [INFO] running `Command { std: "docker" "start" "-a" "ccd89582c72081252275f2f5e5f9ce668682dcdb9a61aaaf04ace21d265d06cc", kill_on_drop: false }` [INFO] [stderr] Checking ippacket v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:30 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(bytes: Box<[u8]>) -> io::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | IpPacket::with_bytes(Bytes::new(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn into_inner(self) -> Box<[u8]> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | self.into_data().into_inner() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn into_data(self) -> Window> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Bytes::try_unwrap(self.data).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn try_unwrap(this: Bytes) -> Result>, Bytes> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let (off, len, cap) = (this.off, this.len, this.cap); [INFO] [stdout] 22 | / Rc::try_unwrap(this.bytes) [INFO] [stdout] 23 | | .map(|c| { [INFO] [stdout] 24 | | let mut window = Window::new(c.into_inner()); [INFO] [stdout] 25 | | window.set_start(off); [INFO] [stdout] 26 | | window.set_end(off + len); [INFO] [stdout] 27 | | window [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(bytes: Box<[u8]>) -> Bytes { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | bytes: Rc::new(RefCell::new(bytes)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icmp.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn with_bytes(bytes: Bytes) -> io::Result<(IcmpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut header = IcmpHeader(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let remaining = try_split!(header.0, IcmpHeader::len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icmp.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 218 | pub fn calculated_checksum>(&self, data: V) -> u16 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | / self.0 [INFO] [stdout] 220 | | .slice(0, 2) [INFO] [stdout] 221 | | .pair_iter() [INFO] [stdout] 222 | | .chain(self.0.slice(4, IcmpHeader::len()).pair_iter()) [INFO] [stdout] 223 | | .chain(data) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn with_bytes(bytes: Bytes) -> io::Result<(Ipv4Header, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let mut header = Ipv4Header(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let len = header.len(); [INFO] [stdout] 76 | let remaining = try_split!(header.0, len); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn with_bytes(bytes: Bytes) -> io::Result<(Ipv6Header, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let mut header = Ipv6Header(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let remaining = try_split!(header.0, Ipv6Header::len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:82:30 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn new(bytes: Box<[u8]>) -> io::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | IpPacket::with_bytes(Bytes::new(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:238:15 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn with_bytes(bytes: Bytes) -> io::Result<(IpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | match bytes.read_u8(0).map(|v| v >> 4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn into_inner(self) -> Box<[u8]> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | self.into_data().into_inner() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn into_data(self) -> Window> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | Bytes::try_unwrap(self.data).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:239:66 [INFO] [stdout] | [INFO] [stdout] 239 | Ok(4) => Ipv4Header::with_bytes(bytes).map(|(h, b)| (IpHeader::V4(h), b)), [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:240:66 [INFO] [stdout] | [INFO] [stdout] 240 | Ok(6) => Ipv6Header::with_bytes(bytes).map(|(h, b)| (IpHeader::V6(h), b)), [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn try_unwrap(this: Bytes) -> Result>, Bytes> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let (off, len, cap) = (this.off, this.len, this.cap); [INFO] [stdout] 22 | / Rc::try_unwrap(this.bytes) [INFO] [stdout] 23 | | .map(|c| { [INFO] [stdout] 24 | | let mut window = Window::new(c.into_inner()); [INFO] [stdout] 25 | | window.set_start(off); [INFO] [stdout] 26 | | window.set_end(off + len); [INFO] [stdout] 27 | | window [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytes.rs:40:20 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(bytes: Box<[u8]>) -> Bytes { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | bytes: Rc::new(RefCell::new(bytes)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:359:10 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn build(self, mut bytes: Bytes) -> (IpHeader, Bytes) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | let (mut header, remaining) = Ipv4Header::with_bytes(bytes).unwrap(); [INFO] [stdout] | ------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | (IpHeader::V4(header), remaining) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 368 | pub fn with_bytes(bytes: Bytes) -> io::Result<(HopByHopOpts, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | let mut opts = HopByHopOpts(bytes); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | let len = opts.len(); [INFO] [stdout] 371 | let remaining = try_split!(opts.0, len); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | Ok((opts, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:394:63 [INFO] [stdout] | [INFO] [stdout] 394 | HopByHopOpts::with_bytes(bytes).map(|(h, b)| (ExtHeader::HopByHop(h), b)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn with_bytes(bytes: Bytes) -> io::Result<(TcpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut header = TcpHeader(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let len = header.len(); [INFO] [stdout] 19 | let remaining = try_split!(header.0, len); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn calculated_checksum>(&self, header: &IpHeader, data: V) -> u16 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let pseudo = header.pseudo_iter(header.total_len().unwrap() - header.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | / self.0 [INFO] [stdout] 74 | | .slice(0, 16) [INFO] [stdout] 75 | | .pair_iter() [INFO] [stdout] 76 | | .chain(self.0.slice(18, self.len()).pair_iter()) [INFO] [stdout] 77 | | .chain(pseudo) [INFO] [stdout] 78 | | .chain(data) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn with_bytes(bytes: Bytes) -> io::Result<(UdpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let mut header = UdpHeader(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let mut payload = try_split!(header.0, UdpHeader::len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok((header, payload)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn calculated_checksum>(&self, header: &IpHeader, data: V) -> u16 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let pseudo = header.pseudo_iter(self.udp_len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / self.0 [INFO] [stdout] 58 | | .slice(0, 6) [INFO] [stdout] 59 | | .pair_iter() [INFO] [stdout] 60 | | .chain(pseudo) [INFO] [stdout] 61 | | .chain(data) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icmp.rs:184:12 [INFO] [stdout] | [INFO] [stdout] 181 | pub fn with_bytes(bytes: Bytes) -> io::Result<(IcmpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut header = IcmpHeader(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | let remaining = try_split!(header.0, IcmpHeader::len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/icmp.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 218 | pub fn calculated_checksum>(&self, data: V) -> u16 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | / self.0 [INFO] [stdout] 220 | | .slice(0, 2) [INFO] [stdout] 221 | | .pair_iter() [INFO] [stdout] 222 | | .chain(self.0.slice(4, IcmpHeader::len()).pair_iter()) [INFO] [stdout] 223 | | .chain(data) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn with_bytes(bytes: Bytes) -> io::Result<(Ipv4Header, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | let mut header = Ipv4Header(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let len = header.len(); [INFO] [stdout] 76 | let remaining = try_split!(header.0, len); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:180:12 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn with_bytes(bytes: Bytes) -> io::Result<(Ipv6Header, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let mut header = Ipv6Header(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let remaining = try_split!(header.0, Ipv6Header::len()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:238:15 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn with_bytes(bytes: Bytes) -> io::Result<(IpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | match bytes.read_u8(0).map(|v| v >> 4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:239:66 [INFO] [stdout] | [INFO] [stdout] 239 | Ok(4) => Ipv4Header::with_bytes(bytes).map(|(h, b)| (IpHeader::V4(h), b)), [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:240:66 [INFO] [stdout] | [INFO] [stdout] 240 | Ok(6) => Ipv6Header::with_bytes(bytes).map(|(h, b)| (IpHeader::V6(h), b)), [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:359:10 [INFO] [stdout] | [INFO] [stdout] 339 | pub fn build(self, mut bytes: Bytes) -> (IpHeader, Bytes) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 354 | let (mut header, remaining) = Ipv4Header::with_bytes(bytes).unwrap(); [INFO] [stdout] | ------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | (IpHeader::V4(header), remaining) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:372:12 [INFO] [stdout] | [INFO] [stdout] 368 | pub fn with_bytes(bytes: Bytes) -> io::Result<(HopByHopOpts, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | let mut opts = HopByHopOpts(bytes); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | let len = opts.len(); [INFO] [stdout] 371 | let remaining = try_split!(opts.0, len); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | Ok((opts, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ip.rs:394:63 [INFO] [stdout] | [INFO] [stdout] 394 | HopByHopOpts::with_bytes(bytes).map(|(h, b)| (ExtHeader::HopByHop(h), b)) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn with_bytes(bytes: Bytes) -> io::Result<(TcpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let mut header = TcpHeader(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let len = header.len(); [INFO] [stdout] 19 | let remaining = try_split!(header.0, len); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Ok((header, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 71 | pub fn calculated_checksum>(&self, header: &IpHeader, data: V) -> u16 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let pseudo = header.pseudo_iter(header.total_len().unwrap() - header.len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | / self.0 [INFO] [stdout] 74 | | .slice(0, 16) [INFO] [stdout] 75 | | .pair_iter() [INFO] [stdout] 76 | | .chain(self.0.slice(18, self.len()).pair_iter()) [INFO] [stdout] 77 | | .chain(pseudo) [INFO] [stdout] 78 | | .chain(data) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn with_bytes(bytes: Bytes) -> io::Result<(UdpHeader, Bytes)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let mut header = UdpHeader(bytes); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let mut payload = try_split!(header.0, UdpHeader::len()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Ok((header, payload)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn calculated_checksum>(&self, header: &IpHeader, data: V) -> u16 { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let pseudo = header.pseudo_iter(self.udp_len()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / self.0 [INFO] [stdout] 58 | | .slice(0, 6) [INFO] [stdout] 59 | | .pair_iter() [INFO] [stdout] 60 | | .chain(pseudo) [INFO] [stdout] 61 | | .chain(data) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ippacket` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `ippacket` (lib test) due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "ccd89582c72081252275f2f5e5f9ce668682dcdb9a61aaaf04ace21d265d06cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ccd89582c72081252275f2f5e5f9ce668682dcdb9a61aaaf04ace21d265d06cc", kill_on_drop: false }` [INFO] [stdout] ccd89582c72081252275f2f5e5f9ce668682dcdb9a61aaaf04ace21d265d06cc