[INFO] fetching crate ipmpsc 0.5.1... [INFO] checking ipmpsc-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ipmpsc 0.5.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ipmpsc 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ipmpsc 0.5.1 [INFO] finished tweaking crates.io crate ipmpsc 0.5.1 [INFO] tweaked toml for crates.io crate ipmpsc 0.5.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ipmpsc 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3405668d8bbcacbd06429ed7345c87faf86a0514844aa76d0670f3362055820 [INFO] running `Command { std: "docker" "start" "-a" "e3405668d8bbcacbd06429ed7345c87faf86a0514844aa76d0670f3362055820", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3405668d8bbcacbd06429ed7345c87faf86a0514844aa76d0670f3362055820", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3405668d8bbcacbd06429ed7345c87faf86a0514844aa76d0670f3362055820", kill_on_drop: false }` [INFO] [stdout] e3405668d8bbcacbd06429ed7345c87faf86a0514844aa76d0670f3362055820 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a7a26c2c3f6235ec881c03c14f33451b9248786f60fdc046f9f116c0fdbbdf7 [INFO] running `Command { std: "docker" "start" "-a" "4a7a26c2c3f6235ec881c03c14f33451b9248786f60fdc046f9f116c0fdbbdf7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling syn v1.0.54 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling anyhow v1.0.35 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking bit-set v0.5.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap2 v0.2.2 [INFO] [stderr] Checking errno v0.2.7 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking rusty-fork v0.2.2 [INFO] [stderr] Checking proptest v0.9.6 [INFO] [stderr] Compiling thiserror-impl v1.0.22 [INFO] [stderr] Checking thiserror v1.0.22 [INFO] [stderr] Checking bincode v1.3.1 [INFO] [stderr] Checking serde_bytes v0.11.5 [INFO] [stderr] Checking ipmpsc v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 141 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Ok(Self(View::try_new(Arc::new(UnsafeCell::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 151 | | Buffer::try_new(path, map(&file)?, None)?, [INFO] [stdout] 152 | | )))?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 162 | let file = NamedTempFile::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let map = map(file.as_file())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | [INFO] [stdout] 175 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 176 | | path.to_owned(), [INFO] [stdout] 177 | | Self(View::try_new(Arc::new(UnsafeCell::new(Buffer::try_new( [INFO] [stdout] 178 | | &path, [INFO] [stdout] ... | [INFO] [stdout] 181 | | )?)))?), [INFO] [stdout] 182 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 191 | let file = OpenOptions::new().read(true).write(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let map = unsafe { MmapMut::map_mut(&file)? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | [INFO] [stdout] 194 | let buffer = Buffer::try_new(path, map, None)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(Self(View::try_new(Arc::new(UnsafeCell::new(buffer)))?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/posix.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn try_new(buffer: Arc>) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(View(buffer)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/posix.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn try_new(_path: &str, map: MmapMut, file: Option) -> Result { [INFO] [stdout] | ------------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(Buffer { map, _file: file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ipmpsc` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:12 [INFO] [stdout] | [INFO] [stdout] 141 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Ok(Self(View::try_new(Arc::new(UnsafeCell::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 151 | | Buffer::try_new(path, map(&file)?, None)?, [INFO] [stdout] 152 | | )))?)) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:12 [INFO] [stdout] | [INFO] [stdout] 162 | let file = NamedTempFile::new()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let map = map(file.as_file())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | [INFO] [stdout] 175 | Ok(( [INFO] [stdout] | ____________^ [INFO] [stdout] 176 | | path.to_owned(), [INFO] [stdout] 177 | | Self(View::try_new(Arc::new(UnsafeCell::new(Buffer::try_new( [INFO] [stdout] 178 | | &path, [INFO] [stdout] ... | [INFO] [stdout] 181 | | )?)))?), [INFO] [stdout] 182 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 191 | let file = OpenOptions::new().read(true).write(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let map = unsafe { MmapMut::map_mut(&file)? }; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | [INFO] [stdout] 194 | let buffer = Buffer::try_new(path, map, None)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | Ok(Self(View::try_new(Arc::new(UnsafeCell::new(buffer)))?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/posix.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn try_new(buffer: Arc>) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(View(buffer)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/posix.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn try_new(_path: &str, map: MmapMut, file: Option) -> Result { [INFO] [stdout] | ------------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(Buffer { map, _file: file }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:597:36 [INFO] [stdout] | [INFO] [stdout] 594 | let data = Arc::new(self.data.clone()); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | os::test::fork({ [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 598 | | let name = name.clone(); [INFO] [stdout] 599 | | let data = data.clone(); [INFO] [stdout] 600 | | move || -> Result<()> { [INFO] [stdout] ... | [INFO] [stdout] 608 | | } [INFO] [stdout] 609 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:688:13 [INFO] [stdout] | [INFO] [stdout] 684 | let tx = Sender::new(SharedRingBuffer::open(&name)?); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 688 | tx.send(&42_u32).map_err(anyhow::Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ipmpsc` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "4a7a26c2c3f6235ec881c03c14f33451b9248786f60fdc046f9f116c0fdbbdf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a7a26c2c3f6235ec881c03c14f33451b9248786f60fdc046f9f116c0fdbbdf7", kill_on_drop: false }` [INFO] [stdout] 4a7a26c2c3f6235ec881c03c14f33451b9248786f60fdc046f9f116c0fdbbdf7