[INFO] fetching crate ipfs-unixfs 0.2.0... [INFO] checking ipfs-unixfs-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ipfs-unixfs 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ipfs-unixfs 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ipfs-unixfs 0.2.0 [INFO] finished tweaking crates.io crate ipfs-unixfs 0.2.0 [INFO] tweaked toml for crates.io crate ipfs-unixfs 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate ipfs-unixfs 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad73cb62aceee9cbd2127b4a88c3eb5b260bdf03d0247bd15e96b9c23b56c0a8 [INFO] running `Command { std: "docker" "start" "-a" "ad73cb62aceee9cbd2127b4a88c3eb5b260bdf03d0247bd15e96b9c23b56c0a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad73cb62aceee9cbd2127b4a88c3eb5b260bdf03d0247bd15e96b9c23b56c0a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad73cb62aceee9cbd2127b4a88c3eb5b260bdf03d0247bd15e96b9c23b56c0a8", kill_on_drop: false }` [INFO] [stdout] ad73cb62aceee9cbd2127b4a88c3eb5b260bdf03d0247bd15e96b9c23b56c0a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2332451e25fdcc5651782f8cb52d5f3ae31372cdcd1d8128ff145d2eb4b0e8bb [INFO] running `Command { std: "docker" "start" "-a" "2332451e25fdcc5651782f8cb52d5f3ae31372cdcd1d8128ff145d2eb4b0e8bb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.21 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Compiling syn v1.0.41 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling rayon-core v1.8.1 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling data-encoding v2.3.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking keccak v0.1.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking blake2s_simd v0.5.10 [INFO] [stderr] Checking blake2b_simd v0.5.10 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking sha-1 v0.9.1 [INFO] [stderr] Checking sha2 v0.9.1 [INFO] [stderr] Compiling rayon v1.4.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking base-x v0.2.6 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Checking unsigned-varint v0.5.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking filetime v0.2.12 [INFO] [stderr] Checking unsigned-varint v0.3.3 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking multihash v0.11.4 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking quick-protobuf v0.7.0 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking tar v0.4.30 [INFO] [stderr] Compiling hex-literal v0.3.1 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.8 [INFO] [stderr] Checking data-encoding-macro v0.1.8 [INFO] [stderr] Checking multibase v0.8.0 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking cid v0.5.1 [INFO] [stderr] Checking ipfs-unixfs v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.1.0 [INFO] [stdout] warning: field `hidden` is never read [INFO] [stdout] --> src/lib.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct InvalidCidInLink { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 51 | hidden: (), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InvalidCidInLink` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `unwrap_borrowed` is never used [INFO] [stdout] --> src/file.rs:157:8 [INFO] [stdout] | [INFO] [stdout] 155 | pub(crate) trait UnwrapBorrowedExt<'a> { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] 156 | /// Does not default but requires there to be an borrowed inner value. [INFO] [stdout] 157 | fn unwrap_borrowed(self) -> &'a [u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/visit.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | self.start_from_reader(fr, &mut None) [INFO] [stdout] | ^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/adder.rs:225:9 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn finish(mut self) -> impl Iterator)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let last_leaf = Self::flush_buffered_leaf( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let root_links = self.flush_buffered_links(true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | // should probably error if there is neither? [INFO] [stdout] 225 | last_leaf.into_iter().chain(root_links.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/adder.rs:225:37 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn finish(mut self) -> impl Iterator)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let last_leaf = Self::flush_buffered_leaf( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let root_links = self.flush_buffered_links(true); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | // should probably error if there is neither? [INFO] [stdout] 225 | last_leaf.into_iter().chain(root_links.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/adder.rs:273:14 [INFO] [stdout] | [INFO] [stdout] 260 | let (cid, vec) = render_and_hash(&inner); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 264 | let link = Link { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Some((cid, vec)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:150:30 [INFO] [stdout] | [INFO] [stdout] 149 | fn from(e: MultipleMatchingLinks) -> ResolveError { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | ResolveError::Lookup(e.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir.rs:189:15 [INFO] [stdout] | [INFO] [stdout] 187 | ((i, first), (j, second)): ((usize, Cid), (usize, PBLink<'a>)), [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 188 | ) -> MultipleMatchingLinks { [INFO] [stdout] 189 | match try_convert_cid(j, second) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/sharded_lookup.rs:187:12 [INFO] [stdout] | [INFO] [stdout] 163 | iter: impl Iterator>, [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let mut found = None; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Ok(found.map(|(_, cid)| cid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/sharded_lookup.rs:210:30 [INFO] [stdout] | [INFO] [stdout] 209 | fn from(e: PartitioningError) -> ResolveError { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | ResolveError::Lookup(LookupError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/builder/iter.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 65 | pub(super) fn new(root: DirBuilder, opts: TreeOptions, longest_path: usize) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let root = Visited::DescentRoot(root); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | persisted_cids: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/builder/iter.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 65 | pub(super) fn new(root: DirBuilder, opts: TreeOptions, longest_path: usize) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let root = Visited::DescentRoot(root); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | reused_children: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/builder/iter.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 65 | pub(super) fn new(root: DirBuilder, opts: TreeOptions, longest_path: usize) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let root = Visited::DescentRoot(root); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | cid: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/builder/iter.rs:156:12 [INFO] [stdout] | [INFO] [stdout] 144 | let mh = multihash::wrap(multihash::Code::Sha2_256, &Sha256::digest(&buffer)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | let cid = Cid::new_v0(mh).expect("sha2_256 is the correct multihash for cidv0"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Ok(Leaf { [INFO] [stdout] | ____________^ [INFO] [stdout] 157 | | link: cid, [INFO] [stdout] 158 | | total_size: buffer.len() as u64 + combined_from_links, [INFO] [stdout] 159 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/builder/buffered.rs:50:37 [INFO] [stdout] | [INFO] [stdout] 42 | target: Cid, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let leaf = Leaf { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | self.modify_with(full_path, |parent, basename, _| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 51 | | parent [INFO] [stdout] 52 | | .put_leaf(basename, leaf) [INFO] [stdout] 53 | | .map_err(|_| TreeBuildingFailed::DuplicatePath(full_path.to_string())) [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 136 | match UnixFs::try_from(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dagpb.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn wrap_node_data(block: T) -> Result, quick_protobuf::Error> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(NodeData { [INFO] [stdout] | ________^ [INFO] [stdout] 29 | | inner: block, [INFO] [stdout] 30 | | range, [INFO] [stdout] 31 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 38 | let cid = match Cid::try_from(hash) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Ok(cid) => cid, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok((cid, name, nested_depth)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 59 | let cid = match Cid::try_from(hash) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(cid) => cid, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok((cid, name, depth)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:81:22 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(cid: Cid, root_name: String) -> Walker { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let next = Some((cid, root_name, depth)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | current: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(cid: Cid, root_name: String) -> Walker { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let next = Some((cid, root_name, depth)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | pending: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:352:19 [INFO] [stdout] | [INFO] [stdout] 347 | fn new_root_dir(cid: Cid, metadata: Metadata, name: &str, depth: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 352 | kind: InnerKind::RootDirectory, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:364:19 [INFO] [stdout] | [INFO] [stdout] 359 | fn new_root_bucket(cid: Cid, metadata: Metadata, name: &str, depth: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | kind: InnerKind::BucketAtRoot, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:383:19 [INFO] [stdout] | [INFO] [stdout] 372 | cid: Cid, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 375 | step: Option, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | kind: InnerKind::File(step, file_size), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/walk.rs:395:19 [INFO] [stdout] | [INFO] [stdout] 390 | fn new_root_symlink(cid: Cid, metadata: Metadata, name: &str, depth: usize) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | kind: InnerKind::Symlink, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ipfs-unixfs` (lib) due to 24 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "2332451e25fdcc5651782f8cb52d5f3ae31372cdcd1d8128ff145d2eb4b0e8bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2332451e25fdcc5651782f8cb52d5f3ae31372cdcd1d8128ff145d2eb4b0e8bb", kill_on_drop: false }` [INFO] [stdout] 2332451e25fdcc5651782f8cb52d5f3ae31372cdcd1d8128ff145d2eb4b0e8bb