[INFO] fetching crate iota_stronghold 2.1.0... [INFO] checking iota_stronghold-2.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iota_stronghold 2.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate iota_stronghold 2.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iota_stronghold 2.1.0 [INFO] removed 2 missing examples [INFO] finished tweaking crates.io crate iota_stronghold 2.1.0 [INFO] tweaked toml for crates.io crate iota_stronghold 2.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate iota_stronghold 2.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b48a5a1358c960f7152bef4cbb126405040b11df377b05293bcbc3a2e9bf154c [INFO] running `Command { std: "docker" "start" "-a" "b48a5a1358c960f7152bef4cbb126405040b11df377b05293bcbc3a2e9bf154c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b48a5a1358c960f7152bef4cbb126405040b11df377b05293bcbc3a2e9bf154c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b48a5a1358c960f7152bef4cbb126405040b11df377b05293bcbc3a2e9bf154c", kill_on_drop: false }` [INFO] [stdout] b48a5a1358c960f7152bef4cbb126405040b11df377b05293bcbc3a2e9bf154c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73993558578ff557518d43fb93b6bb7c311f7ee6528d90bb1645f16c41c6410c [INFO] running `Command { std: "docker" "start" "-a" "73993558578ff557518d43fb93b6bb7c311f7ee6528d90bb1645f16c41c6410c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling tinyvec_macros v0.1.1 [INFO] [stderr] Compiling zerocopy v0.7.34 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling allocator-api2 v0.2.18 [INFO] [stderr] Compiling unicode-bidi v0.3.15 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling percent-encoding v2.3.1 [INFO] [stderr] Compiling tinyvec v1.6.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling form_urlencoded v1.2.1 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling platforms v3.4.0 [INFO] [stderr] Compiling rle-decode-fast v1.0.3 [INFO] [stderr] Compiling adler32 v1.2.0 [INFO] [stderr] Compiling dary_heap v0.3.6 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Compiling unicode-normalization v0.1.23 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling minisign-verify v0.2.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling core2 v0.4.0 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling curve25519-dalek v4.1.2 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling iota-crypto v0.23.1 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Compiling idna v0.5.0 [INFO] [stderr] Compiling libflate_lz77 v2.1.0 [INFO] [stderr] Compiling syn v2.0.63 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling libflate v2.1.0 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling anyhow v1.0.83 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking iterator-sorted v0.1.0 [INFO] [stderr] Compiling filetime v0.2.23 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Compiling url v2.5.0 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Compiling xattr v1.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Compiling tar v0.4.40 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Compiling ureq v2.9.7 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking rust-argon2 v1.0.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling libsodium-sys-stable v1.20.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Compiling stronghold-derive v1.0.0 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Checking stronghold-utils v1.0.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking curve25519-dalek v3.2.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking x25519-dalek v1.1.1 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking ed25519-zebra v4.0.3 [INFO] [stderr] Checking k256 v0.13.3 [INFO] [stderr] Checking stronghold-runtime v2.0.1 [INFO] [stderr] Checking stronghold_engine v2.0.1 [INFO] [stderr] Checking iota_stronghold v2.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/client.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn vault

(&self, vault_path: P) -> ClientVault [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | client: self.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/client.rs:232:40 [INFO] [stdout] | [INFO] [stdout] 232 | let mapped = res.map(|mut vec| vec.pop().unwrap().try_into().ok().unwrap())?; [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/client.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 274 | let ks = self.keystore.read()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | Ok(KeyProvider::KeyStore(ks)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 179 | let decrypted = snapshot::decrypt_content(&mut encrypted.as_slice(), &key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let (keys, db) = bincode::deserialize(&decrypted)?; [INFO] [stdout] | ---- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok((keys, db, store.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:171:31 [INFO] [stdout] | [INFO] [stdout] 171 | .and_then(|state| self.keystore.get_key(vid).map(|pkey| (state, pkey))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 172 | .and_then(|(state, pkey)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let k = &pkey.key; [INFO] [stdout] 174 | k.borrow().deref().try_into().ok().map(|k| (state, k)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:348:20 [INFO] [stdout] | [INFO] [stdout] 345 | .get_guard::<_, SnapshotError, _>(&vault_key, vid, rid, |guard| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | let sk = x25519::SecretKey::try_from_slice(&guard.borrow())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | let shared_key = sk.diffie_hellman(&remote_pk); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(snapshot::decrypt_content_with_work_factor( [INFO] [stdout] | ____________________^ [INFO] [stdout] 349 | | &mut bytes.as_slice(), [INFO] [stdout] 350 | | shared_key.as_bytes(), [INFO] [stdout] 351 | | Self::STRONG_KEY_WORK_FACTOR, [INFO] [stdout] 352 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/store.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 181 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Store { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | cache: Arc::new(RwLock::new(cache)), [INFO] [stdout] 188 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/stronghold.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn get_client

(&self, client_path: P) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let clients = self.clients.read()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | / clients [INFO] [stdout] 199 | | .get(&client_id) [INFO] [stdout] 200 | | .cloned() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/stronghold.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn unload_client(&self, client: Client) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let mut clients = self.clients.write()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | clients.remove(&client.id).ok_or(ClientError::ClientDataNotPresent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/stronghold.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn purge_client(&self, client: Client) -> Result<(), ClientError> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let mut snapshot = self.snapshot.write()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut clients = self.clients.write()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | / snapshot [INFO] [stdout] 223 | | .purge_client(*client.id()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/security/keyprovider.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 33 | fn try_from(data: Zeroizing>) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | match NCKey::load(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/security/keyprovider.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn with_passphrase_hashed(mut passphrase: P, mut digest: D) -> Result [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut key = Zeroizing::new(vec![0_u8; ::output_size()]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Self::try_from(key).map_err(|e| ClientError::Inner(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/clientrunner.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 67 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let execute_procedure = |guards: [Buffer; N]| { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let Products { output: plain, secret } = f(guards)?; [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok((secret, plain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 237 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 239 | | secret: self.data, [INFO] [stdout] 240 | | output: (), [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 387 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | let mut entropy = Zeroizing::new([0u8; 32]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let mnemonic: bip39::Mnemonic = bip39::wordlist::encode(entropy.as_ref(), &wordlist).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | let seed = bip39::mnemonic_to_seed(&mnemonic, &self.passphrase); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | [INFO] [stdout] 399 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 400 | | secret: Zeroizing::new(seed.as_ref().to_vec()), [INFO] [stdout] 401 | | output: mnemonic, [INFO] [stdout] 402 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 424 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | let seed = bip39::mnemonic_to_seed(&self.mnemonic, &self.passphrase); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | [INFO] [stdout] 427 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 428 | | secret: Zeroizing::new(seed.as_ref().to_vec()), [INFO] [stdout] 429 | | output: (), [INFO] [stdout] 430 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:457:12 [INFO] [stdout] | [INFO] [stdout] 455 | let mut seed = Zeroizing::new(vec![0u8; size_bytes]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | fill(seed.as_mut())?; [INFO] [stdout] 457 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 458 | | secret: seed, [INFO] [stdout] 459 | | output: (), [INFO] [stdout] 460 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 497 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let (extended_bytes, chain_code) = match self.input { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | let mut ext_bytes = Zeroizing::new([0_u8; 65]); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | let dk = slip10::Seed::from_bytes(&guards[0].borrow()) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | let dk = slip10::Seed::from_bytes(&guards[0].borrow()) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | secret: extended_bytes, [INFO] [stdout] 555 | | output: chain_code, [INFO] [stdout] 556 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:512:14 [INFO] [stdout] | [INFO] [stdout] 511 | fn get_result(dk: slip10::Slip10) -> (Zeroizing>, slip10::ChainCode) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | (Zeroizing::new((dk.extended_bytes()[1..]).into()), *dk.chain_code()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:595:8 [INFO] [stdout] | [INFO] [stdout] 584 | fn ed25519_secret_key(raw: Ref) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | Ok(ed25519::SecretKey::from_bytes( [INFO] [stdout] | ________^ [INFO] [stdout] 596 | | raw_slice[..ed25519::SecretKey::LENGTH].try_into().unwrap(), [INFO] [stdout] 597 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 624 | let secret = match self.ty { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Ok(Products { secret, output: () }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:625:73 [INFO] [stdout] | [INFO] [stdout] 625 | KeyType::Ed25519 => ed25519::SecretKey::generate().map(|sk| sk.to_bytes().to_vec().into())?, [INFO] [stdout] | -- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:763:12 [INFO] [stdout] | [INFO] [stdout] 758 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 759 | let sk = x25519_secret_key(guards[0].borrow())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 760 | let public = x25519::PublicKey::from_bytes(self.public_key); [INFO] [stdout] 761 | let shared_key = sk.diffie_hellman(&public); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 762 | [INFO] [stdout] 763 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 764 | | secret: shared_key.to_bytes().to_vec().into(), [INFO] [stdout] 765 | | output: (), [INFO] [stdout] 766 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:851:12 [INFO] [stdout] | [INFO] [stdout] 827 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 828 | let secret = match self.hash_type { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 829 | Sha2Hash::Sha256 => { [INFO] [stdout] 830 | let mut okm = Zeroizing::new(vec![0; SHA256_LEN]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 837 | let mut okm = Zeroizing::new(vec![0; SHA384_LEN]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 844 | let mut okm = Zeroizing::new(vec![0; SHA512_LEN]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 851 | Ok(Products { secret, output: () }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:897:12 [INFO] [stdout] | [INFO] [stdout] 879 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 880 | let secret = match self.hash_type { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 881 | Sha2Hash::Sha256 => { [INFO] [stdout] 882 | let mut buffer = Zeroizing::new(vec![0; SHA256_LEN]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 887 | let mut buffer = Zeroizing::new(vec![0; SHA384_LEN]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 892 | let mut buffer = Zeroizing::new(vec![0; SHA512_LEN]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 897 | Ok(Products { secret, output: () }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1040:12 [INFO] [stdout] | [INFO] [stdout] 1033 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1034 | let derived_key_material = match self.hash { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1040 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 1041 | | secret: derived_key_material, [INFO] [stdout] 1042 | | output: (), [INFO] [stdout] 1043 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1130:23 [INFO] [stdout] | [INFO] [stdout] 1129 | fn use_secret(self, guard: [Buffer; 2]) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1130 | self.wrap_key(guard[0].borrow().as_ref(), guard[1].borrow().as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1130:51 [INFO] [stdout] | [INFO] [stdout] 1129 | fn use_secret(self, guard: [Buffer; 2]) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1130 | self.wrap_key(guard[0].borrow().as_ref(), guard[1].borrow().as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1169:12 [INFO] [stdout] | [INFO] [stdout] 1167 | fn derive(self, guard: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1168 | let plaintext = self.unwrap_key(guard[0].borrow().as_ref())?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1169 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 1170 | | secret: plaintext, [INFO] [stdout] 1171 | | output: (), [INFO] [stdout] 1172 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1258:12 [INFO] [stdout] | [INFO] [stdout] 1251 | fn derive(self, guard: [Buffer; 2]) -> Result, FatalProcedureError> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1252 | let a = guard[0].borrow(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1255 | let b = guard[1].borrow(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1258 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 1259 | | secret: [a, b].concat().into(), [INFO] [stdout] 1260 | | output: (), [INFO] [stdout] 1261 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 364 | pub fn deserialize<'de, T, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | String::deserialize(d).map(From::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 32 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iota_stronghold` (lib) due to 33 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/client.rs:70:21 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn vault

(&self, vault_path: P) -> ClientVault [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | client: self.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/client.rs:232:40 [INFO] [stdout] | [INFO] [stdout] 232 | let mapped = res.map(|mut vec| vec.pop().unwrap().try_into().ok().unwrap())?; [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/client.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 274 | let ks = self.keystore.read()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | Ok(KeyProvider::KeyStore(ks)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 179 | let decrypted = snapshot::decrypt_content(&mut encrypted.as_slice(), &key)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | let (keys, db) = bincode::deserialize(&decrypted)?; [INFO] [stdout] | ---- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok((keys, db, store.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:171:31 [INFO] [stdout] | [INFO] [stdout] 171 | .and_then(|state| self.keystore.get_key(vid).map(|pkey| (state, pkey))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:174:17 [INFO] [stdout] | [INFO] [stdout] 172 | .and_then(|(state, pkey)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let k = &pkey.key; [INFO] [stdout] 174 | k.borrow().deref().try_into().ok().map(|k| (state, k)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/snapshot.rs:348:20 [INFO] [stdout] | [INFO] [stdout] 345 | .get_guard::<_, SnapshotError, _>(&vault_key, vid, rid, |guard| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 346 | let sk = x25519::SecretKey::try_from_slice(&guard.borrow())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 347 | let shared_key = sk.diffie_hellman(&remote_pk); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(snapshot::decrypt_content_with_work_factor( [INFO] [stdout] | ____________________^ [INFO] [stdout] 349 | | &mut bytes.as_slice(), [INFO] [stdout] 350 | | shared_key.as_bytes(), [INFO] [stdout] 351 | | Self::STRONG_KEY_WORK_FACTOR, [INFO] [stdout] 352 | | )?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/store.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 181 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Store { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | cache: Arc::new(RwLock::new(cache)), [INFO] [stdout] 188 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/stronghold.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn get_client

(&self, client_path: P) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let clients = self.clients.read()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | / clients [INFO] [stdout] 199 | | .get(&client_id) [INFO] [stdout] 200 | | .cloned() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/stronghold.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn unload_client(&self, client: Client) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | let mut clients = self.clients.write()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 210 | clients.remove(&client.id).ok_or(ClientError::ClientDataNotPresent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/stronghold.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn purge_client(&self, client: Client) -> Result<(), ClientError> { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | let mut snapshot = self.snapshot.write()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut clients = self.clients.write()?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | / snapshot [INFO] [stdout] 223 | | .purge_client(*client.id()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/vault.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn read_secret

(&self, record_path: P) -> Result>, ClientError> [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(self.client.get_guard(&location, |guarded_data| { [INFO] [stdout] | ____________^ [INFO] [stdout] 88 | | let guarded_data = guarded_data.borrow(); [INFO] [stdout] 89 | | Ok(guarded_data.to_vec().into()) [INFO] [stdout] 90 | | })?) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/vault.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 87 | Ok(self.client.get_guard(&location, |guarded_data| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let guarded_data = guarded_data.borrow(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Ok(guarded_data.to_vec().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/security/keyprovider.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 33 | fn try_from(data: Zeroizing>) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | match NCKey::load(data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/security/keyprovider.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn with_passphrase_hashed(mut passphrase: P, mut digest: D) -> Result [INFO] [stdout] | ----------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let mut key = Zeroizing::new(vec![0_u8; ::output_size()]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Self::try_from(key).map_err(|e| ClientError::Inner(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/clientrunner.rs:76:16 [INFO] [stdout] | [INFO] [stdout] 67 | f: F, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let execute_procedure = |guards: [Buffer; N]| { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let Products { output: plain, secret } = f(guards)?; [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok((secret, plain)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 237 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 239 | | secret: self.data, [INFO] [stdout] 240 | | output: (), [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 387 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | let mut entropy = Zeroizing::new([0u8; 32]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 396 | let mnemonic: bip39::Mnemonic = bip39::wordlist::encode(entropy.as_ref(), &wordlist).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 397 | let seed = bip39::mnemonic_to_seed(&mnemonic, &self.passphrase); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 398 | [INFO] [stdout] 399 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 400 | | secret: Zeroizing::new(seed.as_ref().to_vec()), [INFO] [stdout] 401 | | output: mnemonic, [INFO] [stdout] 402 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:427:12 [INFO] [stdout] | [INFO] [stdout] 424 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 425 | let seed = bip39::mnemonic_to_seed(&self.mnemonic, &self.passphrase); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 426 | [INFO] [stdout] 427 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 428 | | secret: Zeroizing::new(seed.as_ref().to_vec()), [INFO] [stdout] 429 | | output: (), [INFO] [stdout] 430 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:457:12 [INFO] [stdout] | [INFO] [stdout] 455 | let mut seed = Zeroizing::new(vec![0u8; size_bytes]); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | fill(seed.as_mut())?; [INFO] [stdout] 457 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 458 | | secret: seed, [INFO] [stdout] 459 | | output: (), [INFO] [stdout] 460 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 497 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 515 | let (extended_bytes, chain_code) = match self.input { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 523 | let mut ext_bytes = Zeroizing::new([0_u8; 65]); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | let dk = slip10::Seed::from_bytes(&guards[0].borrow()) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | let dk = slip10::Seed::from_bytes(&guards[0].borrow()) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 554 | | secret: extended_bytes, [INFO] [stdout] 555 | | output: chain_code, [INFO] [stdout] 556 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:512:14 [INFO] [stdout] | [INFO] [stdout] 511 | fn get_result(dk: slip10::Slip10) -> (Zeroizing>, slip10::ChainCode) { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 512 | (Zeroizing::new((dk.extended_bytes()[1..]).into()), *dk.chain_code()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:595:8 [INFO] [stdout] | [INFO] [stdout] 584 | fn ed25519_secret_key(raw: Ref) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 595 | Ok(ed25519::SecretKey::from_bytes( [INFO] [stdout] | ________^ [INFO] [stdout] 596 | | raw_slice[..ed25519::SecretKey::LENGTH].try_into().unwrap(), [INFO] [stdout] 597 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:629:12 [INFO] [stdout] | [INFO] [stdout] 624 | let secret = match self.ty { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Ok(Products { secret, output: () }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:625:73 [INFO] [stdout] | [INFO] [stdout] 625 | KeyType::Ed25519 => ed25519::SecretKey::generate().map(|sk| sk.to_bytes().to_vec().into())?, [INFO] [stdout] | -- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:763:12 [INFO] [stdout] | [INFO] [stdout] 758 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 759 | let sk = x25519_secret_key(guards[0].borrow())?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 760 | let public = x25519::PublicKey::from_bytes(self.public_key); [INFO] [stdout] 761 | let shared_key = sk.diffie_hellman(&public); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 762 | [INFO] [stdout] 763 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 764 | | secret: shared_key.to_bytes().to_vec().into(), [INFO] [stdout] 765 | | output: (), [INFO] [stdout] 766 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:851:12 [INFO] [stdout] | [INFO] [stdout] 827 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 828 | let secret = match self.hash_type { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 829 | Sha2Hash::Sha256 => { [INFO] [stdout] 830 | let mut okm = Zeroizing::new(vec![0; SHA256_LEN]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 837 | let mut okm = Zeroizing::new(vec![0; SHA384_LEN]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 844 | let mut okm = Zeroizing::new(vec![0; SHA512_LEN]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 851 | Ok(Products { secret, output: () }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:897:12 [INFO] [stdout] | [INFO] [stdout] 879 | fn generate(self) -> Result, FatalProcedureError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 880 | let secret = match self.hash_type { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 881 | Sha2Hash::Sha256 => { [INFO] [stdout] 882 | let mut buffer = Zeroizing::new(vec![0; SHA256_LEN]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 887 | let mut buffer = Zeroizing::new(vec![0; SHA384_LEN]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 892 | let mut buffer = Zeroizing::new(vec![0; SHA512_LEN]); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 897 | Ok(Products { secret, output: () }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1040:12 [INFO] [stdout] | [INFO] [stdout] 1033 | fn derive(self, guards: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1034 | let derived_key_material = match self.hash { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1040 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 1041 | | secret: derived_key_material, [INFO] [stdout] 1042 | | output: (), [INFO] [stdout] 1043 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1130:23 [INFO] [stdout] | [INFO] [stdout] 1129 | fn use_secret(self, guard: [Buffer; 2]) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1130 | self.wrap_key(guard[0].borrow().as_ref(), guard[1].borrow().as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1130:51 [INFO] [stdout] | [INFO] [stdout] 1129 | fn use_secret(self, guard: [Buffer; 2]) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1130 | self.wrap_key(guard[0].borrow().as_ref(), guard[1].borrow().as_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1169:12 [INFO] [stdout] | [INFO] [stdout] 1167 | fn derive(self, guard: [Buffer; 1]) -> Result, FatalProcedureError> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1168 | let plaintext = self.unwrap_key(guard[0].borrow().as_ref())?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1169 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 1170 | | secret: plaintext, [INFO] [stdout] 1171 | | output: (), [INFO] [stdout] 1172 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:1258:12 [INFO] [stdout] | [INFO] [stdout] 1251 | fn derive(self, guard: [Buffer; 2]) -> Result, FatalProcedureError> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1252 | let a = guard[0].borrow(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1255 | let b = guard[1].borrow(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1258 | Ok(Products { [INFO] [stdout] | ____________^ [INFO] [stdout] 1259 | | secret: [a, b].concat().into(), [INFO] [stdout] 1260 | | output: (), [INFO] [stdout] 1261 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procedures/primitives.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 364 | pub fn deserialize<'de, T, D>(d: D) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | String::deserialize(d).map(From::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 34 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iota_stronghold` (lib test) due to 35 previous errors [INFO] running `Command { std: "docker" "inspect" "73993558578ff557518d43fb93b6bb7c311f7ee6528d90bb1645f16c41c6410c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73993558578ff557518d43fb93b6bb7c311f7ee6528d90bb1645f16c41c6410c", kill_on_drop: false }` [INFO] [stdout] 73993558578ff557518d43fb93b6bb7c311f7ee6528d90bb1645f16c41c6410c