[INFO] fetching crate iop-morpheus-proto 0.0.16... [INFO] checking iop-morpheus-proto-0.0.16 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iop-morpheus-proto 0.0.16 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate iop-morpheus-proto 0.0.16 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iop-morpheus-proto 0.0.16 [INFO] finished tweaking crates.io crate iop-morpheus-proto 0.0.16 [INFO] tweaked toml for crates.io crate iop-morpheus-proto 0.0.16 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 122 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64ct v1.1.1 (latest: v1.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding crypto-mac v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding curve25519-dalek v3.2.0 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hmac v0.8.1 (latest: v0.12.1) [INFO] [stderr] Adding jwt-compact v0.5.0 (latest: v0.8.0) [INFO] [stderr] Adding pbkdf2 v0.11.0 (latest: v0.12.2) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4aa8c518c40cb7fb7d01ce273d9c7feefff9dd05673ed811ab34bf303de1343b [INFO] running `Command { std: "docker" "start" "-a" "4aa8c518c40cb7fb7d01ce273d9c7feefff9dd05673ed811ab34bf303de1343b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4aa8c518c40cb7fb7d01ce273d9c7feefff9dd05673ed811ab34bf303de1343b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4aa8c518c40cb7fb7d01ce273d9c7feefff9dd05673ed811ab34bf303de1343b", kill_on_drop: false }` [INFO] [stdout] 4aa8c518c40cb7fb7d01ce273d9c7feefff9dd05673ed811ab34bf303de1343b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73d5a53c1fc79923b19a44ece57bc921023e3e30ea97810e1a3c383cd45e58ff [INFO] running `Command { std: "docker" "start" "-a" "73d5a53c1fc79923b19a44ece57bc921023e3e30ea97810e1a3c383cd45e58ff", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking hmac v0.8.1 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling digest v0.9.0 [INFO] [stderr] Checking curve25519-dalek v3.2.0 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking hmac-drbg v0.3.0 [INFO] [stderr] Compiling libsecp256k1-core v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking fiat-crypto v0.2.9 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.13 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking data-encoding-macro v0.1.15 [INFO] [stderr] Checking bit_utils v0.1.1 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking tiny-bip39 v1.0.0 [INFO] [stderr] Checking varint v0.9.0 [INFO] [stderr] Compiling libsecp256k1-gen-genmult v0.3.0 [INFO] [stderr] Compiling libsecp256k1-gen-ecmult v0.3.0 [INFO] [stderr] Checking ripemd v0.1.3 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking base64ct v1.1.1 [INFO] [stderr] Checking iop-journal-proto v0.0.16 [INFO] [stderr] Compiling libsecp256k1 v0.7.1 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking serde_str v0.1.0 [INFO] [stderr] Checking jwt-compact v0.5.0 [INFO] [stderr] Checking json-digest v0.0.16 [INFO] [stderr] Checking orion v0.17.6 [INFO] [stderr] Checking iop-keyvault v0.0.16 [INFO] [stderr] Checking iop-morpheus-proto v0.0.16 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/sign.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 150 | fn sign_witness_request(&self, request: WitnessRequest) -> Result> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(Signed::new(public_key, request, signature)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/sign.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 157 | &self, statement: WitnessStatement, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Signed::new(public_key, statement, signature)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/sign.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 165 | &self, presentation: ClaimPresentation, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(Signed::new(public_key, presentation, signature)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/did.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 23 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | multicipher::MKeyId::deserialize(deserializer).map(Did::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/diddoc.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn map_all(f: impl Fn(&Right) -> T) -> HashMap { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | vec![Self::Update, Self::Impersonation].drain(..).map(|r| (r, f(&r))).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/diddoc.rs:37:71 [INFO] [stdout] | [INFO] [stdout] 37 | vec![Self::Update, Self::Impersonation].drain(..).map(|r| (r, f(&r))).collect() [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iop-morpheus-proto` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/sign.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 150 | fn sign_witness_request(&self, request: WitnessRequest) -> Result> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Ok(Signed::new(public_key, request, signature)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/sign.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 157 | &self, statement: WitnessStatement, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Signed::new(public_key, statement, signature)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/sign.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 165 | &self, presentation: ClaimPresentation, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | Ok(Signed::new(public_key, presentation, signature)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/did.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 23 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | multicipher::MKeyId::deserialize(deserializer).map(Did::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/diddoc.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn map_all(f: impl Fn(&Right) -> T) -> HashMap { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | vec![Self::Update, Self::Impersonation].drain(..).map(|r| (r, f(&r))).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/diddoc.rs:37:71 [INFO] [stdout] | [INFO] [stdout] 37 | vec![Self::Update, Self::Impersonation].drain(..).map(|r| (r, f(&r))).collect() [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iop-morpheus-proto` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "73d5a53c1fc79923b19a44ece57bc921023e3e30ea97810e1a3c383cd45e58ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73d5a53c1fc79923b19a44ece57bc921023e3e30ea97810e1a3c383cd45e58ff", kill_on_drop: false }` [INFO] [stdout] 73d5a53c1fc79923b19a44ece57bc921023e3e30ea97810e1a3c383cd45e58ff