[INFO] fetching crate ion_shell_lsp_server 0.2.0... [INFO] checking ion_shell_lsp_server-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ion_shell_lsp_server 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate ion_shell_lsp_server 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ion_shell_lsp_server 0.2.0 [INFO] finished tweaking crates.io crate ion_shell_lsp_server 0.2.0 [INFO] tweaked toml for crates.io crate ion_shell_lsp_server 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate ion_shell_lsp_server 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb533719776fb2fd6cb26535aceb2e78760c66ada6387f70469cb42a384581d4 [INFO] running `Command { std: "docker" "start" "-a" "cb533719776fb2fd6cb26535aceb2e78760c66ada6387f70469cb42a384581d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb533719776fb2fd6cb26535aceb2e78760c66ada6387f70469cb42a384581d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb533719776fb2fd6cb26535aceb2e78760c66ada6387f70469cb42a384581d4", kill_on_drop: false }` [INFO] [stdout] cb533719776fb2fd6cb26535aceb2e78760c66ada6387f70469cb42a384581d4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd0410e54ecdf4983d019a9cc8394cbe474bf3a7f1d61e75200183a6808f144f [INFO] running `Command { std: "docker" "start" "-a" "dd0410e54ecdf4983d019a9cc8394cbe474bf3a7f1d61e75200183a6808f144f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking nu-ansi-term v0.49.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking is-terminal v0.4.11 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking insta v1.34.0 [INFO] [stderr] Checking chrono v0.4.33 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Compiling pest v2.7.8 [INFO] [stderr] Checking flexi_logger v0.28.0 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Compiling pest_meta v2.7.8 [INFO] [stderr] Compiling pest_generator v2.7.8 [INFO] [stderr] Compiling pest_derive v2.7.8 [INFO] [stderr] Checking ion_shell_parser v0.2.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking lsp-types v0.95.1 [INFO] [stderr] Checking lsp-server v0.7.6 [INFO] [stderr] Checking ion_shell_lsp_server v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finding_symbols/find_references.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 82 | to_filter: impl Iterator, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let mut path: HashSet = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | to_filter.filter(move |next| path.contains(&next.scope())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finding_symbols/go_to_definition.rs:154:22 [INFO] [stdout] | [INFO] [stdout] 140 | to_filter: impl Iterator, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let mut path: HashSet = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | to_filter.filter(move |next| path.contains(&next.scope())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finding_symbols/go_to_definition.rs:178:22 [INFO] [stdout] | [INFO] [stdout] 160 | to_filter: impl Iterator, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let mut path: HashSet = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | to_filter.filter(move |next| path.contains(&next.scope())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | .map_err(|error| (error.into(), req_id.clone()))?; [INFO] [stdout] | ----- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_state.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(connection: Connection) -> AppResult<(Self, Connection)> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let new_self = Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok((new_self, connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ion_shell_lsp_server` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/test_utils.rs:12:10 [INFO] [stdout] | [INFO] [stdout] 12 | Send(Message), [INFO] [stdout] | ---- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ActionLspClient` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 12 | Send(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/test_utils.rs:13:14 [INFO] [stdout] | [INFO] [stdout] 13 | Received(Message), [INFO] [stdout] | -------- ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ActionLspClient` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 13 | Received(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finding_symbols/find_references.rs:110:22 [INFO] [stdout] | [INFO] [stdout] 82 | to_filter: impl Iterator, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let mut path: HashSet = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | to_filter.filter(move |next| path.contains(&next.scope())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finding_symbols/go_to_definition.rs:154:22 [INFO] [stdout] | [INFO] [stdout] 140 | to_filter: impl Iterator, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | let mut path: HashSet = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | to_filter.filter(move |next| path.contains(&next.scope())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finding_symbols/go_to_definition.rs:178:22 [INFO] [stdout] | [INFO] [stdout] 160 | to_filter: impl Iterator, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let mut path: HashSet = HashSet::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | to_filter.filter(move |next| path.contains(&next.scope())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/finding_symbols.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 96 | .map(|(found, rest)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | rest.map(|element| prepare_item_for_test_review(&parsed, element, INPUT)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/requests.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | .map_err(|error| (error.into(), req_id.clone()))?; [INFO] [stdout] | ----- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server_state.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(connection: Connection) -> AppResult<(Self, Connection)> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let new_self = Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok((new_self, connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utils.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn to_json_value(param: T) -> serde_json::Value [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | serde_json::to_value(param).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_utils/test_lsp_memory_fixture.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 59 | let (server_connection, client_connection) = Connection::memory(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let (mut context, server_connection) = ServerState::new(server_connection).unwrap(); [INFO] [stdout] | ------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | crate::main_loop(server_connection, &mut context).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ion_shell_lsp_server` (lib test) due to 9 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dd0410e54ecdf4983d019a9cc8394cbe474bf3a7f1d61e75200183a6808f144f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd0410e54ecdf4983d019a9cc8394cbe474bf3a7f1d61e75200183a6808f144f", kill_on_drop: false }` [INFO] [stdout] dd0410e54ecdf4983d019a9cc8394cbe474bf3a7f1d61e75200183a6808f144f