[INFO] fetching crate inter-struct-codegen 0.2.1... [INFO] checking inter-struct-codegen-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate inter-struct-codegen 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate inter-struct-codegen 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate inter-struct-codegen 0.2.1 [INFO] finished tweaking crates.io crate inter-struct-codegen 0.2.1 [INFO] tweaked toml for crates.io crate inter-struct-codegen 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6be11e25092bd7067bf880e9cde7248c4249f19a537fa68336d591180f667e7e [INFO] running `Command { std: "docker" "start" "-a" "6be11e25092bd7067bf880e9cde7248c4249f19a537fa68336d591180f667e7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6be11e25092bd7067bf880e9cde7248c4249f19a537fa68336d591180f667e7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6be11e25092bd7067bf880e9cde7248c4249f19a537fa68336d591180f667e7e", kill_on_drop: false }` [INFO] [stdout] 6be11e25092bd7067bf880e9cde7248c4249f19a537fa68336d591180f667e7e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a55363d718460fb1fcf556e363c7a284c9d9234ddc38ffd7469914de95e8470 [INFO] running `Command { std: "docker" "start" "-a" "3a55363d718460fb1fcf556e363c7a284c9d9234ddc38ffd7469914de95e8470", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking inter-struct-codegen v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/field.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn determine_field_type(ty: Type) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | match ty.clone() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | / { [INFO] [stdout] 5 | | #[allow(unused_imports)] [INFO] [stdout] 6 | | use syn::spanned::Spanned; [INFO] [stdout] 7 | | let message = format!($($text,)*); [INFO] [stdout] 8 | | let span = $span.span(); [INFO] [stdout] 9 | | quote::quote_spanned!( span => compile_error!(#message); ) [INFO] [stdout] 10 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/module.rs:11:49 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn get_struct_from_path(root_path: PathBuf, path: Path) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let mut segments = path.segments.into_iter().peekable(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | // Make sure the root of the path is the current crate. [INFO] [stdout] 17 | let first = segments.next().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let crate_token = Token![crate](first.span()); [INFO] [stdout] 19 | let crate_ident = Ident::from(crate_token); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let target_struct_name = loop { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let segment = segments.next().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let file_content = ok_or_err_return!( [INFO] [stdout] | ________________________- [INFO] [stdout] | |________________________| [INFO] [stdout] 78 | | std::fs::read_to_string(&file_path), [INFO] [stdout] 79 | | path_span, [INFO] [stdout] 80 | | "Failed to open file {:?}: {:?}", [INFO] [stdout] 81 | | file_path [INFO] [stdout] 82 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let file_ast = ok_or_err_return!( [INFO] [stdout] | _________--------___- [INFO] [stdout] | |_________|__________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | | syn::parse_file(&file_content), [INFO] [stdout] 86 | | path_span, [INFO] [stdout] 87 | | "Failed to parse file {:?}: {:?}", [INFO] [stdout] 88 | | file_path [INFO] [stdout] 89 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Err(err!( [INFO] [stdout] | _________- [INFO] [stdout] 100 | path_span, [INFO] [stdout] 101 | "Didn't find struct {} in file {:?}", [INFO] [stdout] 102 | target_struct_name, [INFO] [stdout] 103 | &file_path [INFO] [stdout] 104 | | )) [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `err` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `inter-struct-codegen` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generate/field.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn determine_field_type(ty: Type) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | match ty.clone() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 4 | / { [INFO] [stdout] 5 | | #[allow(unused_imports)] [INFO] [stdout] 6 | | use syn::spanned::Spanned; [INFO] [stdout] 7 | | let message = format!($($text,)*); [INFO] [stdout] 8 | | let span = $span.span(); [INFO] [stdout] 9 | | quote::quote_spanned!( span => compile_error!(#message); ) [INFO] [stdout] 10 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Err(error) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/module.rs:11:49 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn get_struct_from_path(root_path: PathBuf, path: Path) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let mut segments = path.segments.into_iter().peekable(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | // Make sure the root of the path is the current crate. [INFO] [stdout] 17 | let first = segments.next().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let crate_token = Token![crate](first.span()); [INFO] [stdout] 19 | let crate_ident = Ident::from(crate_token); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let target_struct_name = loop { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | let segment = segments.next().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let file_content = ok_or_err_return!( [INFO] [stdout] | ________________________- [INFO] [stdout] | |________________________| [INFO] [stdout] 78 | | std::fs::read_to_string(&file_path), [INFO] [stdout] 79 | | path_span, [INFO] [stdout] 80 | | "Failed to open file {:?}: {:?}", [INFO] [stdout] 81 | | file_path [INFO] [stdout] 82 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | [INFO] [stdout] 84 | let file_ast = ok_or_err_return!( [INFO] [stdout] | _________--------___- [INFO] [stdout] | |_________|__________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | | syn::parse_file(&file_content), [INFO] [stdout] 86 | | path_span, [INFO] [stdout] 87 | | "Failed to parse file {:?}: {:?}", [INFO] [stdout] 88 | | file_path [INFO] [stdout] 89 | | ); [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | Err(err!( [INFO] [stdout] | _________- [INFO] [stdout] 100 | path_span, [INFO] [stdout] 101 | "Didn't find struct {} in file {:?}", [INFO] [stdout] 102 | target_struct_name, [INFO] [stdout] 103 | &file_path [INFO] [stdout] 104 | | )) [INFO] [stdout] | |_____- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `err` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `inter-struct-codegen` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "3a55363d718460fb1fcf556e363c7a284c9d9234ddc38ffd7469914de95e8470", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a55363d718460fb1fcf556e363c7a284c9d9234ddc38ffd7469914de95e8470", kill_on_drop: false }` [INFO] [stdout] 3a55363d718460fb1fcf556e363c7a284c9d9234ddc38ffd7469914de95e8470