[INFO] fetching crate instant-glicko-2 0.2.0... [INFO] checking instant-glicko-2-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate instant-glicko-2 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate instant-glicko-2 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate instant-glicko-2 0.2.0 [INFO] finished tweaking crates.io crate instant-glicko-2 0.2.0 [INFO] tweaked toml for crates.io crate instant-glicko-2 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9cef810ed8eeaf8d092567ab098c24dfc52e4e7cad37699e7fe6ec030167297 [INFO] running `Command { std: "docker" "start" "-a" "d9cef810ed8eeaf8d092567ab098c24dfc52e4e7cad37699e7fe6ec030167297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9cef810ed8eeaf8d092567ab098c24dfc52e4e7cad37699e7fe6ec030167297", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9cef810ed8eeaf8d092567ab098c24dfc52e4e7cad37699e7fe6ec030167297", kill_on_drop: false }` [INFO] [stdout] d9cef810ed8eeaf8d092567ab098c24dfc52e4e7cad37699e7fe6ec030167297 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ca90d10c98113942504e9a4f653a9e1adb940b41597cc705d56751b5ed665bf [INFO] running `Command { std: "docker" "start" "-a" "3ca90d10c98113942504e9a4f653a9e1adb940b41597cc705d56751b5ed665bf", kill_on_drop: false }` [INFO] [stderr] Checking instant-glicko-2 v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:960:11 [INFO] [stdout] | [INFO] [stdout] 958 | games: impl IntoIterator, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 959 | ) -> f64 { [INFO] [stdout] 960 | 1.0 / games [INFO] [stdout] | ___________^ [INFO] [stdout] 961 | | .into_iter() [INFO] [stdout] 962 | | .map(|game| { [INFO] [stdout] 963 | | let opponent_rating = game.opponent(); [INFO] [stdout] ... | [INFO] [stdout] 968 | | g * g * e * (1.0 - e) [INFO] [stdout] 969 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:978:5 [INFO] [stdout] | [INFO] [stdout] 976 | games: impl IntoIterator, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | ) -> f64 { [INFO] [stdout] 978 | / games [INFO] [stdout] 979 | | .into_iter() [INFO] [stdout] 980 | | .map(|game| { [INFO] [stdout] 981 | | let opponent_rating = game.opponent(); [INFO] [stdout] ... | [INFO] [stdout] 986 | | g * (game.score() - e) [INFO] [stdout] 987 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `instant-glicko-2` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:960:11 [INFO] [stdout] | [INFO] [stdout] 958 | games: impl IntoIterator, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 959 | ) -> f64 { [INFO] [stdout] 960 | 1.0 / games [INFO] [stdout] | ___________^ [INFO] [stdout] 961 | | .into_iter() [INFO] [stdout] 962 | | .map(|game| { [INFO] [stdout] 963 | | let opponent_rating = game.opponent(); [INFO] [stdout] ... | [INFO] [stdout] 968 | | g * g * e * (1.0 - e) [INFO] [stdout] 969 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/algorithm.rs:978:5 [INFO] [stdout] | [INFO] [stdout] 976 | games: impl IntoIterator, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 977 | ) -> f64 { [INFO] [stdout] 978 | / games [INFO] [stdout] 979 | | .into_iter() [INFO] [stdout] 980 | | .map(|game| { [INFO] [stdout] 981 | | let opponent_rating = game.opponent(); [INFO] [stdout] ... | [INFO] [stdout] 986 | | g * (game.score() - e) [INFO] [stdout] 987 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `instant-glicko-2` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "3ca90d10c98113942504e9a4f653a9e1adb940b41597cc705d56751b5ed665bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ca90d10c98113942504e9a4f653a9e1adb940b41597cc705d56751b5ed665bf", kill_on_drop: false }` [INFO] [stdout] 3ca90d10c98113942504e9a4f653a9e1adb940b41597cc705d56751b5ed665bf