[INFO] fetching crate inox2d 0.2.0... [INFO] checking inox2d-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate inox2d 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate inox2d 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate inox2d 0.2.0 [INFO] finished tweaking crates.io crate inox2d 0.2.0 [INFO] tweaked toml for crates.io crate inox2d 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate inox2d 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a6832a52292a0f08f89fa95ded7e4276ceda82354bfe913bd206608ca60a3db0 [INFO] running `Command { std: "docker" "start" "-a" "a6832a52292a0f08f89fa95ded7e4276ceda82354bfe913bd206608ca60a3db0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a6832a52292a0f08f89fa95ded7e4276ceda82354bfe913bd206608ca60a3db0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6832a52292a0f08f89fa95ded7e4276ceda82354bfe913bd206608ca60a3db0", kill_on_drop: false }` [INFO] [stdout] a6832a52292a0f08f89fa95ded7e4276ceda82354bfe913bd206608ca60a3db0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93842c97517f1c655571481f9208fa99b01218e3fac4fe9e717ebbe4f97437e1 [INFO] running `Command { std: "docker" "start" "-a" "93842c97517f1c655571481f9208fa99b01218e3fac4fe9e717ebbe4f97437e1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking simple-tga-reader v0.1.0 [INFO] [stderr] Checking indextree v4.6.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking glam v0.25.0 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking png v0.17.11 [INFO] [stderr] Checking image v0.24.8 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking inox2d v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/inp.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn parse_inp(mut data: R) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | let payload = json::parse(payload)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let mut textures = Vec::with_capacity(tex_count); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let vendors = match read_n::<_, 8>(&mut data) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let mut vendors = Vec::with_capacity(ext_count); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let payload = json::parse(payload)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(Model { [INFO] [stdout] | ________^ [INFO] [stdout] 102 | | puppet, [INFO] [stdout] 103 | | textures, [INFO] [stdout] 104 | | vendors, [INFO] [stdout] 105 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/json.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn nested(self, key: &str) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | inner: Box::new(self), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | Ok(InoxNode { [INFO] [stdout] | ________^ [INFO] [stdout] 86 | | uuid: InoxNodeUuid(obj.get_u32("uuid")?), [INFO] [stdout] 87 | | name: obj.get_str("name")?.to_owned(), [INFO] [stdout] 88 | | enabled: obj.get_bool("enabled")?, [INFO] [stdout] ... | [INFO] [stdout] 92 | | data: vals("data", deserialize_node_data(node_type, obj, deserialize_node_custom))?, [INFO] [stdout] 93 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:118:44 [INFO] [stdout] | [INFO] [stdout] 118 | .map_err(|_| InoxParseError::JsonError(JsonError::ParseIntError("0".to_owned()).nested("textures")))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:127:44 [INFO] [stdout] | [INFO] [stdout] 127 | .map_err(|_| InoxParseError::JsonError(JsonError::ParseIntError("1".to_owned()).nested("textures")))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:136:44 [INFO] [stdout] | [INFO] [stdout] 136 | .map_err(|_| InoxParseError::JsonError(JsonError::ParseIntError("2".to_owned()).nested("textures")))?, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:213:25 [INFO] [stdout] | [INFO] [stdout] 213 | .filter_map(|mask| deserialize_mask(&JsonObject(mask.as_object()?)).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:318:5 [INFO] [stdout] | [INFO] [stdout] 307 | let nodes = vals( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | Ok(Puppet::new(meta, physics, nodes, parameters)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:323:22 [INFO] [stdout] | [INFO] [stdout] 323 | .map_while(|param| deserialize_param(&JsonObject(param.as_object()?)).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:346:25 [INFO] [stdout] | [INFO] [stdout] 346 | .filter_map(|binding| deserialize_binding(&JsonObject(binding.as_object()?)).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/formats/payload.rs:396:49 [INFO] [stdout] | [INFO] [stdout] 396 | .filter_map(|(i, vals)| Some(deserialize_f32s(as_nested_list(i, vals).ok()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `inox2d` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "93842c97517f1c655571481f9208fa99b01218e3fac4fe9e717ebbe4f97437e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93842c97517f1c655571481f9208fa99b01218e3fac4fe9e717ebbe4f97437e1", kill_on_drop: false }` [INFO] [stdout] 93842c97517f1c655571481f9208fa99b01218e3fac4fe9e717ebbe4f97437e1