[INFO] fetching crate inori 0.1.0... [INFO] checking inori-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate inori 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate inori 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate inori 0.1.0 [INFO] finished tweaking crates.io crate inori 0.1.0 [INFO] tweaked toml for crates.io crate inori 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate inori 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f424e5cf97a473457f5046a5d1183e9f8b86c072456aa3e5c8eef1d95bd0071 [INFO] running `Command { std: "docker" "start" "-a" "0f424e5cf97a473457f5046a5d1183e9f8b86c072456aa3e5c8eef1d95bd0071", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f424e5cf97a473457f5046a5d1183e9f8b86c072456aa3e5c8eef1d95bd0071", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f424e5cf97a473457f5046a5d1183e9f8b86c072456aa3e5c8eef1d95bd0071", kill_on_drop: false }` [INFO] [stdout] 0f424e5cf97a473457f5046a5d1183e9f8b86c072456aa3e5c8eef1d95bd0071 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0834b90dc15859a82645d0a17b331dff494201ba9045743c8608b649b3b402d5 [INFO] running `Command { std: "docker" "start" "-a" "0834b90dc15859a82645d0a17b331dff494201ba9045743c8608b649b3b402d5", kill_on_drop: false }` [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking nucleo-matcher v0.3.1 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking inori-mpd v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling stability v0.2.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking ratatui v0.27.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking inori v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `selected_track` is never used [INFO] [stdout] --> src/model/impl_library.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl LibraryState { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn selected_track(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 126 | let mut conn = Client::connect(mpd_url.clone()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(Model { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | state: State::Running, [INFO] [stdout] 131 | | status: conn.status()?, [INFO] [stdout] 132 | | conn, [INFO] [stdout] ... | [INFO] [stdout] 144 | | window_height: Some(100), [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/impl_queue.rs:42:31 [INFO] [stdout] | [INFO] [stdout] 42 | .and_then(|i| self.filter().cache.order.get(i).cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/proto.rs:64:27 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|i| self.contents().nth(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `selected_track` is never used [INFO] [stdout] --> src/model/impl_library.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl LibraryState { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 21 | pub fn selected_track(&self) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 126 | let mut conn = Client::connect(mpd_url.clone()) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(Model { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | state: State::Running, [INFO] [stdout] 131 | | status: conn.status()?, [INFO] [stdout] 132 | | conn, [INFO] [stdout] ... | [INFO] [stdout] 144 | | window_height: Some(100), [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/impl_queue.rs:42:31 [INFO] [stdout] | [INFO] [stdout] 42 | .and_then(|i| self.filter().cache.order.get(i).cloned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/proto.rs:64:27 [INFO] [stdout] | [INFO] [stdout] 64 | .and_then(|i| self.contents().nth(i)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `inori` (bin "inori") due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `inori` (bin "inori" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0834b90dc15859a82645d0a17b331dff494201ba9045743c8608b649b3b402d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0834b90dc15859a82645d0a17b331dff494201ba9045743c8608b649b3b402d5", kill_on_drop: false }` [INFO] [stdout] 0834b90dc15859a82645d0a17b331dff494201ba9045743c8608b649b3b402d5