[INFO] fetching crate indymilter-test 0.2.0... [INFO] checking indymilter-test-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate indymilter-test 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate indymilter-test 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate indymilter-test 0.2.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate indymilter-test 0.2.0 [INFO] tweaked toml for crates.io crate indymilter-test 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d7f2d0ca0f2c0e4daedbf6b30807ca2cb91fba6ad4732f748d167767a27fb486 [INFO] running `Command { std: "docker" "start" "-a" "d7f2d0ca0f2c0e4daedbf6b30807ca2cb91fba6ad4732f748d167767a27fb486", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d7f2d0ca0f2c0e4daedbf6b30807ca2cb91fba6ad4732f748d167767a27fb486", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7f2d0ca0f2c0e4daedbf6b30807ca2cb91fba6ad4732f748d167767a27fb486", kill_on_drop: false }` [INFO] [stdout] d7f2d0ca0f2c0e4daedbf6b30807ca2cb91fba6ad4732f748d167767a27fb486 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 27b19f7668587e326feac55420953d675fff10d8e188498c719702f7ce12a575 [INFO] running `Command { std: "docker" "start" "-a" "27b19f7668587e326feac55420953d675fff10d8e188498c719702f7ce12a575", kill_on_drop: false }` [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling byte-strings-proc_macros v0.3.1 [INFO] [stderr] Checking byte-strings v0.3.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking indymilter v0.3.0 [INFO] [stderr] Checking indymilter-test v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/basic.rs:70:44 [INFO] [stdout] | [INFO] [stdout] 70 | .on_negotiate(|_cx, _, _| Box::pin(async { Status::AllOpts })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/basic.rs:71:42 [INFO] [stdout] | [INFO] [stdout] 71 | .on_connect(|_cx, _, _| Box::pin(async { Status::Continue })) [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/basic.rs:72:36 [INFO] [stdout] | [INFO] [stdout] 72 | .on_helo(|_cx, _| Box::pin(async { Status::Continue })) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/basic.rs:73:36 [INFO] [stdout] | [INFO] [stdout] 73 | .on_mail(|_cx, _| Box::pin(async { Status::Continue })) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `indymilter-test` (test "basic") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/connection.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 20 | let called = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | / Callbacks::new() [INFO] [stdout] 23 | | .on_negotiate(|cx, _, _| { [INFO] [stdout] 24 | | Box::pin(async { [INFO] [stdout] 25 | | cx.requested_opts |= ProtoOpts::SKIP; [INFO] [stdout] ... | [INFO] [stdout] 28 | | }) [INFO] [stdout] 29 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/connection.rs:30:22 [INFO] [stdout] | [INFO] [stdout] 20 | let called = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | .on_body(move |_cx, _| { [INFO] [stdout] | ______________________^ [INFO] [stdout] 31 | | let called = called.clone(); [INFO] [stdout] 32 | | [INFO] [stdout] 33 | | Box::pin(async move { [INFO] [stdout] ... | [INFO] [stdout] 39 | | }) [INFO] [stdout] 40 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/connection.rs:33:26 [INFO] [stdout] | [INFO] [stdout] 20 | let called = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | .on_body(move |_cx, _| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | let called = called.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | [INFO] [stdout] 33 | Box::pin(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 34 | | if called.swap(true, Ordering::SeqCst) { [INFO] [stdout] 35 | | Status::Skip [INFO] [stdout] 36 | | } else { [INFO] [stdout] 37 | | Status::Continue [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/connection.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | .on_data(|_cx| Box::pin(async { Status::Noreply })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/connection.rs:88:45 [INFO] [stdout] | [INFO] [stdout] 88 | .on_header(|_cx, _, _| Box::pin(async { Status::Noreply })) [INFO] [stdout] | - - ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/connection.rs:91:36 [INFO] [stdout] | [INFO] [stdout] 91 | .on_eoh(|_cx| Box::pin(async { Status::Continue })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/connection.rs:128:52 [INFO] [stdout] | [INFO] [stdout] 128 | Callbacks::new().on_mail(|_cx, _| Box::pin(async { Status::Continue })) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `indymilter-test` (test "connection") due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "27b19f7668587e326feac55420953d675fff10d8e188498c719702f7ce12a575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "27b19f7668587e326feac55420953d675fff10d8e188498c719702f7ce12a575", kill_on_drop: false }` [INFO] [stdout] 27b19f7668587e326feac55420953d675fff10d8e188498c719702f7ce12a575