[INFO] fetching crate indexed-ring-buffer 0.1.3... [INFO] checking indexed-ring-buffer-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate indexed-ring-buffer 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate indexed-ring-buffer 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate indexed-ring-buffer 0.1.3 [INFO] finished tweaking crates.io crate indexed-ring-buffer 0.1.3 [INFO] tweaked toml for crates.io crate indexed-ring-buffer 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding criterion v0.2.11 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.3.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding lock_api v0.3.4 (latest: v0.4.12) [INFO] [stderr] Adding parking_lot v0.10.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.7.3 (latest: v0.9.10) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_xoshiro v0.1.0 (latest: v0.6.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (latest: v0.5.3) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d5d6b0f3eaed0478754ea10be22bfd02875e87119b84d3a7059196a9e4b2f513 [INFO] running `Command { std: "docker" "start" "-a" "d5d6b0f3eaed0478754ea10be22bfd02875e87119b84d3a7059196a9e4b2f513", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d5d6b0f3eaed0478754ea10be22bfd02875e87119b84d3a7059196a9e4b2f513", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d5d6b0f3eaed0478754ea10be22bfd02875e87119b84d3a7059196a9e4b2f513", kill_on_drop: false }` [INFO] [stdout] d5d6b0f3eaed0478754ea10be22bfd02875e87119b84d3a7059196a9e4b2f513 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60fa4082605509e0e1f222d7278a545901793d774b9f3ebf32856a181d945f78 [INFO] running `Command { std: "docker" "start" "-a" "60fa4082605509e0e1f222d7278a545901793d774b9f3ebf32856a181d945f78", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking indexed-ring-buffer v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_xoshiro v0.1.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | mem::replace(buf.get_unchecked_mut(tail), MaybeUninit::new(v)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 168 | let _ = mem::replace(buf.get_unchecked_mut(tail), MaybeUninit::new(v)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking criterion-plot v0.3.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.2.11 [INFO] [stdout] warning: unused imports: `Consumer` and `Producer` [INFO] [stdout] --> tests/threads.rs:2:48 [INFO] [stdout] | [INFO] [stdout] 2 | use indexed_ring_buffer::{indexed_ring_buffer, Consumer, Producer, Reader}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fm` [INFO] [stdout] --> tests/threads.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 22 | if let Some((fm, to, v)) = r.get_from(last_id.wrapping_add(1), READ_SIZE) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_fm` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Consumer`, `Producer`, and `Reader` [INFO] [stdout] --> tests/test.rs:3:48 [INFO] [stdout] | [INFO] [stdout] 3 | use indexed_ring_buffer::{indexed_ring_buffer, Consumer, Producer, Reader}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^ ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `arc_data` [INFO] [stdout] --> tests/threads.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | let arc_data = Arc::new(in_data.clone()); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_arc_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/threads.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 17 | fn reader_thread(n: usize, r: Reader, p: Arc>) -> JoinHandle<()> { [INFO] [stdout] | ---------------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 19 | | let mut recv_data = Vec::with_capacity(SIZE); [INFO] [stdout] 20 | | let mut last_id: usize = PREV_ID; [INFO] [stdout] 21 | | while recv_data.len() < SIZE { [INFO] [stdout] ... | [INFO] [stdout] 30 | | assert_eq!(in_data, recv_data); [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | mem::replace(buf.get_unchecked_mut(tail), MaybeUninit::new(v)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 168 | let _ = mem::replace(buf.get_unchecked_mut(tail), MaybeUninit::new(v)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `indexed-ring-buffer` (test "threads") due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `read` [INFO] [stdout] --> tests/test.rs:7:30 [INFO] [stdout] | [INFO] [stdout] 7 | let (mut prod, mut cons, read) = indexed_ring_buffer::(0, 1); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_read` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/test.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 19 | let (mut prod, mut cons, read) = indexed_ring_buffer::(0, 10); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/test.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | let (mut prod, mut cons, read) = indexed_ring_buffer::(0, 10); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cons` [INFO] [stdout] --> tests/test.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 94 | let (mut prod, mut cons, read) = indexed_ring_buffer::(n, 10); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cons` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/test.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | let (mut prod, mut cons, read) = indexed_ring_buffer::(n, 10); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "60fa4082605509e0e1f222d7278a545901793d774b9f3ebf32856a181d945f78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60fa4082605509e0e1f222d7278a545901793d774b9f3ebf32856a181d945f78", kill_on_drop: false }` [INFO] [stdout] 60fa4082605509e0e1f222d7278a545901793d774b9f3ebf32856a181d945f78