[INFO] fetching crate index_datamanip 0.5.2... [INFO] checking index_datamanip-0.5.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate index_datamanip 0.5.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate index_datamanip 0.5.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate index_datamanip 0.5.2 [INFO] finished tweaking crates.io crate index_datamanip 0.5.2 [INFO] tweaked toml for crates.io crate index_datamanip 0.5.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding libflate v0.1.27 (latest: v2.1.0) [INFO] [stderr] Adding nom v5.1.3 (latest: v7.1.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f68389261e487bc239ee4b77bc0e4e7938d33aa6905a2e315fadeb7ad8179b5b [INFO] running `Command { std: "docker" "start" "-a" "f68389261e487bc239ee4b77bc0e4e7938d33aa6905a2e315fadeb7ad8179b5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f68389261e487bc239ee4b77bc0e4e7938d33aa6905a2e315fadeb7ad8179b5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f68389261e487bc239ee4b77bc0e4e7938d33aa6905a2e315fadeb7ad8179b5b", kill_on_drop: false }` [INFO] [stdout] f68389261e487bc239ee4b77bc0e4e7938d33aa6905a2e315fadeb7ad8179b5b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39d782d6d4e77a35e8961338b44363732adbbf50acbf4f3b3827acea4f2b0c25 [INFO] running `Command { std: "docker" "start" "-a" "39d782d6d4e77a35e8961338b44363732adbbf50acbf4f3b3827acea4f2b0c25", kill_on_drop: false }` [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking libflate v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking index_datamanip v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parse7.rs:208:27 [INFO] [stdout] | [INFO] [stdout] 208 | fn deserialize_seq(mut self, visitor: V) -> Result [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `help_index` and `attributes` are never read [INFO] [stdout] --> src/parse_messages.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 49 | struct StashItem { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 52 | help_index: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 53 | attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StashItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `creator_version`, `required_read_version`, `archive_header_size`, and `file_header_size` are never read [INFO] [stdout] --> src/pigg.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 92 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 93 | creator_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 94 | required_read_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 95 | archive_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 96 | file_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name_id`, `size`, `timestamp`, `reserved`, `header_data_id`, and `checksum` are never read [INFO] [stdout] --> src/pigg.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 127 | struct FileHeader { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 128 | name_id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 129 | size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 130 | timestamp: u32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 131 | offset: u32, [INFO] [stdout] 132 | reserved: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 133 | header_data_id: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 134 | checksum: u128, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/defs.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 44 | let mut items = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok((input, items)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse7.rs:323:12 [INFO] [stdout] | [INFO] [stdout] 303 | visitor: V, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | Ok(visitor.visit_enum(self)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse7.rs:319:20 [INFO] [stdout] | [INFO] [stdout] 314 | seed: V, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let v = serde::de::DeserializeSeed::deserialize(seed, moo)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | Ok((v, self)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pigg.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let f = File::open(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | // TODO: Document this [INFO] [stdout] 26 | let mmap = unsafe { MmapOptions::new().map(&f)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Pigg { files, mmap }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/parse7.rs:208:27 [INFO] [stdout] | [INFO] [stdout] 208 | fn deserialize_seq(mut self, visitor: V) -> Result [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `help_index` and `attributes` are never read [INFO] [stdout] --> src/parse_messages.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 49 | struct StashItem { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 52 | help_index: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 53 | attributes: Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `StashItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `creator_version`, `required_read_version`, `archive_header_size`, and `file_header_size` are never read [INFO] [stdout] --> src/pigg.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 92 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 93 | creator_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 94 | required_read_version: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 95 | archive_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 96 | file_header_size: u16, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name_id`, `size`, `timestamp`, `reserved`, `header_data_id`, and `checksum` are never read [INFO] [stdout] --> src/pigg.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 127 | struct FileHeader { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 128 | name_id: i32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 129 | size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 130 | timestamp: u32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 131 | offset: u32, [INFO] [stdout] 132 | reserved: u32, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 133 | header_data_id: u32, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 134 | checksum: u128, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileHeader` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/defs.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 44 | let mut items = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok((input, items)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `index_datamanip` (lib) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse7.rs:323:12 [INFO] [stdout] | [INFO] [stdout] 303 | visitor: V, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | Ok(visitor.visit_enum(self)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse7.rs:319:20 [INFO] [stdout] | [INFO] [stdout] 314 | seed: V, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 318 | let v = serde::de::DeserializeSeed::deserialize(seed, moo)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | Ok((v, self)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pigg.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let f = File::open(path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | // TODO: Document this [INFO] [stdout] 26 | let mmap = unsafe { MmapOptions::new().map(&f)? }; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Ok(Pigg { files, mmap }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `index_datamanip` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "39d782d6d4e77a35e8961338b44363732adbbf50acbf4f3b3827acea4f2b0c25", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39d782d6d4e77a35e8961338b44363732adbbf50acbf4f3b3827acea4f2b0c25", kill_on_drop: false }` [INFO] [stdout] 39d782d6d4e77a35e8961338b44363732adbbf50acbf4f3b3827acea4f2b0c25