[INFO] fetching crate import_map 0.20.1... [INFO] checking import_map-0.20.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate import_map 0.20.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate import_map 0.20.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate import_map 0.20.1 [INFO] finished tweaking crates.io crate import_map 0.20.1 [INFO] tweaked toml for crates.io crate import_map 0.20.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 41 packages to latest compatible versions [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 192960daf90c85f0ebb2aad83233f51327461366ea756f80f21823553643be29 [INFO] running `Command { std: "docker" "start" "-a" "192960daf90c85f0ebb2aad83233f51327461366ea756f80f21823553643be29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "192960daf90c85f0ebb2aad83233f51327461366ea756f80f21823553643be29", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "192960daf90c85f0ebb2aad83233f51327461366ea756f80f21823553643be29", kill_on_drop: false }` [INFO] [stdout] 192960daf90c85f0ebb2aad83233f51327461366ea756f80f21823553643be29 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a181aa18487cde5d4935c9f6ba47de1f603a25dc4aa4e197c33a7f9444b07e27 [INFO] running `Command { std: "docker" "start" "-a" "a181aa18487cde5d4935c9f6ba47de1f603a25dc4aa4e197c33a7f9444b07e27", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking import_map v0.20.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:590:6 [INFO] [stdout] | [INFO] [stdout] 581 | options: ImportMapOptions, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | let (unresolved_imports, unresolved_scopes) = [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 585 | parse_json(json_string, &options, &mut diagnostics)?; [INFO] [stdout] 586 | let imports = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 587 | parse_specifier_map(unresolved_imports, &base_url, &mut diagnostics); [INFO] [stdout] 588 | let scopes = parse_scope_map(unresolved_scopes, &base_url, &mut diagnostics)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | [INFO] [stdout] 590 | Ok(ImportMapWithDiagnostics { [INFO] [stdout] | ______^ [INFO] [stdout] 591 | | diagnostics, [INFO] [stdout] 592 | | import_map: ImportMap { [INFO] [stdout] 593 | | base_url, [INFO] [stdout] ... | [INFO] [stdout] 596 | | }, [INFO] [stdout] 597 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:604:55 [INFO] [stdout] | [INFO] [stdout] 602 | json_value: Value, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | ) -> Result { [INFO] [stdout] 604 | parse_from_value_with_options(base_url, json_value, Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:619:6 [INFO] [stdout] | [INFO] [stdout] 609 | json_value: Value, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 610 | options: ImportMapOptions, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 613 | let (unresolved_imports, unresolved_scopes) = [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | parse_value(json_value, &options, &mut diagnostics)?; [INFO] [stdout] 615 | let imports = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 616 | parse_specifier_map(unresolved_imports, &base_url, &mut diagnostics); [INFO] [stdout] 617 | let scopes = parse_scope_map(unresolved_scopes, &base_url, &mut diagnostics)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 618 | [INFO] [stdout] 619 | Ok(ImportMapWithDiagnostics { [INFO] [stdout] | ______^ [INFO] [stdout] 620 | | diagnostics, [INFO] [stdout] 621 | | import_map: ImportMap { [INFO] [stdout] 622 | | base_url, [INFO] [stdout] ... | [INFO] [stdout] 625 | | }, [INFO] [stdout] 626 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:722:6 [INFO] [stdout] | [INFO] [stdout] 647 | v: Value, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 670 | let mut v = maybe_expand_imports(v, options); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | let imports = if v.get("imports").is_some() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 681 | match v["imports"].take() { [INFO] [stdout] 682 | Value::Object(imports_map) => { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 695 | let scopes = if v.get("scopes").is_some() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 696 | match v["scopes"].take() { [INFO] [stdout] 697 | Value::Object(scopes_map) => { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 710 | let mut keys: HashSet = v [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 722 | Ok((imports, scopes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:590:6 [INFO] [stdout] | [INFO] [stdout] 581 | options: ImportMapOptions, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 584 | let (unresolved_imports, unresolved_scopes) = [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 585 | parse_json(json_string, &options, &mut diagnostics)?; [INFO] [stdout] 586 | let imports = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 587 | parse_specifier_map(unresolved_imports, &base_url, &mut diagnostics); [INFO] [stdout] 588 | let scopes = parse_scope_map(unresolved_scopes, &base_url, &mut diagnostics)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | [INFO] [stdout] 590 | Ok(ImportMapWithDiagnostics { [INFO] [stdout] | ______^ [INFO] [stdout] 591 | | diagnostics, [INFO] [stdout] 592 | | import_map: ImportMap { [INFO] [stdout] 593 | | base_url, [INFO] [stdout] ... | [INFO] [stdout] 596 | | }, [INFO] [stdout] 597 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `import_map` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:604:55 [INFO] [stdout] | [INFO] [stdout] 602 | json_value: Value, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 603 | ) -> Result { [INFO] [stdout] 604 | parse_from_value_with_options(base_url, json_value, Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:619:6 [INFO] [stdout] | [INFO] [stdout] 609 | json_value: Value, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 610 | options: ImportMapOptions, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 613 | let (unresolved_imports, unresolved_scopes) = [INFO] [stdout] | ------------------ ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | parse_value(json_value, &options, &mut diagnostics)?; [INFO] [stdout] 615 | let imports = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 616 | parse_specifier_map(unresolved_imports, &base_url, &mut diagnostics); [INFO] [stdout] 617 | let scopes = parse_scope_map(unresolved_scopes, &base_url, &mut diagnostics)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 618 | [INFO] [stdout] 619 | Ok(ImportMapWithDiagnostics { [INFO] [stdout] | ______^ [INFO] [stdout] 620 | | diagnostics, [INFO] [stdout] 621 | | import_map: ImportMap { [INFO] [stdout] 622 | | base_url, [INFO] [stdout] ... | [INFO] [stdout] 625 | | }, [INFO] [stdout] 626 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:722:6 [INFO] [stdout] | [INFO] [stdout] 647 | v: Value, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 670 | let mut v = maybe_expand_imports(v, options); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 680 | let imports = if v.get("imports").is_some() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 681 | match v["imports"].take() { [INFO] [stdout] 682 | Value::Object(imports_map) => { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 695 | let scopes = if v.get("scopes").is_some() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 696 | match v["scopes"].take() { [INFO] [stdout] 697 | Value::Object(scopes_map) => { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 710 | let mut keys: HashSet = v [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 722 | Ok((imports, scopes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `import_map` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "a181aa18487cde5d4935c9f6ba47de1f603a25dc4aa4e197c33a7f9444b07e27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a181aa18487cde5d4935c9f6ba47de1f603a25dc4aa4e197c33a7f9444b07e27", kill_on_drop: false }` [INFO] [stdout] a181aa18487cde5d4935c9f6ba47de1f603a25dc4aa4e197c33a7f9444b07e27