[INFO] fetching crate impl_table 0.1.3... [INFO] checking impl_table-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate impl_table 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate impl_table 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate impl_table 0.1.3 [INFO] finished tweaking crates.io crate impl_table 0.1.3 [INFO] tweaked toml for crates.io crate impl_table 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 56 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding fallible-iterator v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding libsqlite3-sys v0.14.0 (latest: v0.30.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rusqlite v0.18.0 (latest: v0.32.1) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db8f39b1b03cd6bcbb7d11b9a6b53299b129a35d56b4ee148392e3c27a12b1d2 [INFO] running `Command { std: "docker" "start" "-a" "db8f39b1b03cd6bcbb7d11b9a6b53299b129a35d56b4ee148392e3c27a12b1d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db8f39b1b03cd6bcbb7d11b9a6b53299b129a35d56b4ee148392e3c27a12b1d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db8f39b1b03cd6bcbb7d11b9a6b53299b129a35d56b4ee148392e3c27a12b1d2", kill_on_drop: false }` [INFO] [stdout] db8f39b1b03cd6bcbb7d11b9a6b53299b129a35d56b4ee148392e3c27a12b1d2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3537f25d26530e0952a5a9954231f29ace808442205579ef6591122173f9af7b [INFO] running `Command { std: "docker" "start" "-a" "3537f25d26530e0952a5a9954231f29ace808442205579ef6591122173f9af7b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling libsqlite3-sys v0.14.0 [INFO] [stderr] Checking quote v0.6.13 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking impl_table v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking rusqlite v0.18.0 [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/lib.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | .into(); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 193 | return_error_with_msg!("Table name must be specified and non-empty.") [INFO] [stdout] | --------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `return_error_with_msg` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `return_error_with_msg` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/lib.rs:120:20 [INFO] [stdout] | [INFO] [stdout] 120 | .into(); [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 223 | return_error_with_msg!("impl_table can only be applied to structs.") [INFO] [stdout] | -------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `return_error_with_msg` [INFO] [stdout] = note: this warning originates in the macro `return_error_with_msg` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:90:11 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn derive_table(item: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | match derive_table::derive_table(item) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive_table.rs:170:8 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn derive_table(item: proc_macro::TokenStream) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let struct_def = syn::parse_macro_input::parse::(item)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let mut field_list: Vec = field_values.collect(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | let expr = quote! { [INFO] [stdout] | _________----___- [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | |_________|______| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | | impl #struct_name { [INFO] [stdout] 155 | | fn table_name() -> &'static str { [INFO] [stdout] 156 | | #struct_name::TABLE_NAME [INFO] [stdout] ... | [INFO] [stdout] 165 | | #(#field_list),* [INFO] [stdout] | | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 168 | | } [INFO] [stdout] 169 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_____| [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | | Ok(expr.into()) [INFO] [stdout] | | ^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `impl_table` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3537f25d26530e0952a5a9954231f29ace808442205579ef6591122173f9af7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3537f25d26530e0952a5a9954231f29ace808442205579ef6591122173f9af7b", kill_on_drop: false }` [INFO] [stdout] 3537f25d26530e0952a5a9954231f29ace808442205579ef6591122173f9af7b