[INFO] fetching crate impl-for 0.2.1... [INFO] checking impl-for-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate impl-for 0.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate impl-for 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate impl-for 0.2.1 [INFO] finished tweaking crates.io crate impl-for 0.2.1 [INFO] tweaked toml for crates.io crate impl-for 0.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a080d746dee31f585385d795de9a8928ee2d8e44f0bc2ef882531642c183907 [INFO] running `Command { std: "docker" "start" "-a" "0a080d746dee31f585385d795de9a8928ee2d8e44f0bc2ef882531642c183907", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a080d746dee31f585385d795de9a8928ee2d8e44f0bc2ef882531642c183907", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a080d746dee31f585385d795de9a8928ee2d8e44f0bc2ef882531642c183907", kill_on_drop: false }` [INFO] [stdout] 0a080d746dee31f585385d795de9a8928ee2d8e44f0bc2ef882531642c183907 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0336a9b560de29b0ef668720b62051117b0a3666b9be702b2234ee08d698c586 [INFO] running `Command { std: "docker" "start" "-a" "0336a9b560de29b0ef668720b62051117b0a3666b9be702b2234ee08d698c586", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking replace-types v0.2.0 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking impl-for v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|(ident, type_path)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ( [INFO] [stdout] 17 | / TypePath { [INFO] [stdout] 18 | | qself: None, [INFO] [stdout] 19 | | path: Path::from(ident), [INFO] [stdout] 20 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 58 | args: proc_macro::TokenStream, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | ) -> proc_macro::TokenStream { [INFO] [stdout] 61 | let mut input = parse_macro_input!(input as ItemImpl); [INFO] [stdout] | ----- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let mut substitutions_list: Vec> = Vec::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let mut attrs: Vec = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | let input_attrs = mem::take(&mut input.attrs); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | / substitutions_list [INFO] [stdout] 114 | | .into_iter() [INFO] [stdout] 115 | | .map(|substitutions| { [INFO] [stdout] 116 | | let mut item_impl = input.clone(); [INFO] [stdout] 117 | | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 118 | | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] 119 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 115 | .map(|substitutions| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut item_impl = input.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 118 | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|(ident, type_path)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | ( [INFO] [stdout] 17 | / TypePath { [INFO] [stdout] 18 | | qself: None, [INFO] [stdout] 19 | | path: Path::from(ident), [INFO] [stdout] 20 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 58 | args: proc_macro::TokenStream, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | ) -> proc_macro::TokenStream { [INFO] [stdout] 61 | let mut input = parse_macro_input!(input as ItemImpl); [INFO] [stdout] | ----- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | let mut substitutions_list: Vec> = Vec::new(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let mut attrs: Vec = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | [INFO] [stdout] 80 | let input_attrs = mem::take(&mut input.attrs); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | / substitutions_list [INFO] [stdout] 114 | | .into_iter() [INFO] [stdout] 115 | | .map(|substitutions| { [INFO] [stdout] 116 | | let mut item_impl = input.clone(); [INFO] [stdout] 117 | | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 118 | | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] 119 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 115 | .map(|substitutions| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let mut item_impl = input.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 118 | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 144 | args: proc_macro::TokenStream, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | ) -> proc_macro::TokenStream { [INFO] [stdout] 147 | let input = parse_macro_input!(input as ItemImpl); [INFO] [stdout] | ----- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | [INFO] [stdout] 149 | let substitutions_list: Vec> = match NestedMeta::parse_meta_list(args.into()).map_err(darling::Error::fro... [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(substitutions) => { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let t_type = TypePath { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / substitutions_list [INFO] [stdout] 171 | | .into_iter() [INFO] [stdout] 172 | | .map(|substitutions| { [INFO] [stdout] 173 | | let mut item_impl = input.clone(); [INFO] [stdout] 174 | | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 175 | | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] 176 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:43 [INFO] [stdout] | [INFO] [stdout] 172 | .map(|substitutions| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut item_impl = input.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 175 | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 144 | args: proc_macro::TokenStream, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | input: proc_macro::TokenStream, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | ) -> proc_macro::TokenStream { [INFO] [stdout] 147 | let input = parse_macro_input!(input as ItemImpl); [INFO] [stdout] | ----- ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | [INFO] [stdout] 149 | let substitutions_list: Vec> = match NestedMeta::parse_meta_list(args.into()).map_err(darling::Error::fro... [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | Ok(substitutions) => { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let t_type = TypePath { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / substitutions_list [INFO] [stdout] 171 | | .into_iter() [INFO] [stdout] 172 | | .map(|substitutions| { [INFO] [stdout] 173 | | let mut item_impl = input.clone(); [INFO] [stdout] 174 | | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 175 | | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] 176 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:43 [INFO] [stdout] | [INFO] [stdout] 172 | .map(|substitutions| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut item_impl = input.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | ReplaceTypes::new(substitutions).visit_item_impl_mut(&mut item_impl); [INFO] [stdout] 175 | proc_macro::TokenStream::from(item_impl.into_token_stream()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `impl-for` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `impl-for` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "0336a9b560de29b0ef668720b62051117b0a3666b9be702b2234ee08d698c586", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0336a9b560de29b0ef668720b62051117b0a3666b9be702b2234ee08d698c586", kill_on_drop: false }` [INFO] [stdout] 0336a9b560de29b0ef668720b62051117b0a3666b9be702b2234ee08d698c586