[INFO] fetching crate imagequant-sys 4.0.3... [INFO] checking imagequant-sys-4.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate imagequant-sys 4.0.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate imagequant-sys 4.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate imagequant-sys 4.0.3 [INFO] finished tweaking crates.io crate imagequant-sys 4.0.3 [INFO] tweaked toml for crates.io crate imagequant-sys 4.0.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6bf0dca8f58f355f635fc4dbb53b1645983440d0c16c70d650b3ae9dc744091 [INFO] running `Command { std: "docker" "start" "-a" "e6bf0dca8f58f355f635fc4dbb53b1645983440d0c16c70d650b3ae9dc744091", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6bf0dca8f58f355f635fc4dbb53b1645983440d0c16c70d650b3ae9dc744091", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6bf0dca8f58f355f635fc4dbb53b1645983440d0c16c70d650b3ae9dc744091", kill_on_drop: false }` [INFO] [stdout] e6bf0dca8f58f355f635fc4dbb53b1645983440d0c16c70d650b3ae9dc744091 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58d4d40ec4f82443a5d5548cdcf84051a7a40abdecbf4a4393a8217a3ca441bd [INFO] running `Command { std: "docker" "start" "-a" "58d4d40ec4f82443a5d5548cdcf84051a7a40abdecbf4a4393a8217a3ca441bd", kill_on_drop: false }` [INFO] [stderr] Compiling imagequant-sys v4.0.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking rgb v0.8.50 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking imagequant v4.3.3 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:290:50 [INFO] [stdout] | [INFO] [stdout] 290 | attr.quantize(img).ok().map(|inner| Box::new(liq_result { [INFO] [stdout] | __________________________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | | magic_header: LIQ_RESULT_MAGIC, [INFO] [stdout] 292 | | inner, [INFO] [stdout] 293 | | })) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 573 | let cb: Box], usize) + Send + Sync> = Box::new(move |row, y| row_callback(row.as_mut_ptr(), y as _, ro... [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | liq_image_create_custom_impl(&attr.inner, cb, width as _, height as _, gamma) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:575:36 [INFO] [stdout] | [INFO] [stdout] 575 | .map(move |inner| Box::new(liq_image { [INFO] [stdout] | ____________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | | magic_header: LIQ_IMAGE_MAGIC, [INFO] [stdout] 577 | | inner: ManuallyDrop::new(inner), [INFO] [stdout] 578 | | c_api_free: attr.c_api_free, [INFO] [stdout] 579 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:589:36 [INFO] [stdout] | [INFO] [stdout] 589 | .map(move |inner| Box::new(liq_image { [INFO] [stdout] | ____________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | | magic_header: LIQ_IMAGE_MAGIC, [INFO] [stdout] 591 | | inner: ManuallyDrop::new(inner), [INFO] [stdout] 592 | | c_api_free: attr.c_api_free, [INFO] [stdout] 593 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:602:5 [INFO] [stdout] | [INFO] [stdout] 601 | let rows = (0..height as usize).map(move |i| pixels.add(width as usize * i)).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 602 | liq_image_create_rgba_bitmap_impl(&attr.inner, rows, width as _, height as _, gamma) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:603:36 [INFO] [stdout] | [INFO] [stdout] 603 | .map(move |inner| Box::new(liq_image { [INFO] [stdout] | ____________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | | magic_header: LIQ_IMAGE_MAGIC, [INFO] [stdout] 605 | | inner: ManuallyDrop::new(inner), [INFO] [stdout] 606 | | c_api_free: attr.c_api_free, [INFO] [stdout] 607 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `imagequant-sys` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:290:50 [INFO] [stdout] | [INFO] [stdout] 290 | attr.quantize(img).ok().map(|inner| Box::new(liq_result { [INFO] [stdout] | __________________________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | | magic_header: LIQ_RESULT_MAGIC, [INFO] [stdout] 292 | | inner, [INFO] [stdout] 293 | | })) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 573 | let cb: Box], usize) + Send + Sync> = Box::new(move |row, y| row_callback(row.as_mut_ptr(), y as _, ro... [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 574 | liq_image_create_custom_impl(&attr.inner, cb, width as _, height as _, gamma) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:575:36 [INFO] [stdout] | [INFO] [stdout] 575 | .map(move |inner| Box::new(liq_image { [INFO] [stdout] | ____________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 576 | | magic_header: LIQ_IMAGE_MAGIC, [INFO] [stdout] 577 | | inner: ManuallyDrop::new(inner), [INFO] [stdout] 578 | | c_api_free: attr.c_api_free, [INFO] [stdout] 579 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:589:36 [INFO] [stdout] | [INFO] [stdout] 589 | .map(move |inner| Box::new(liq_image { [INFO] [stdout] | ____________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | | magic_header: LIQ_IMAGE_MAGIC, [INFO] [stdout] 591 | | inner: ManuallyDrop::new(inner), [INFO] [stdout] 592 | | c_api_free: attr.c_api_free, [INFO] [stdout] 593 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:602:5 [INFO] [stdout] | [INFO] [stdout] 601 | let rows = (0..height as usize).map(move |i| pixels.add(width as usize * i)).collect(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 602 | liq_image_create_rgba_bitmap_impl(&attr.inner, rows, width as _, height as _, gamma) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ffi.rs:603:36 [INFO] [stdout] | [INFO] [stdout] 603 | .map(move |inner| Box::new(liq_image { [INFO] [stdout] | ____________________-----___________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 604 | | magic_header: LIQ_IMAGE_MAGIC, [INFO] [stdout] 605 | | inner: ManuallyDrop::new(inner), [INFO] [stdout] 606 | | c_api_free: attr.c_api_free, [INFO] [stdout] 607 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `imagequant-sys` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "58d4d40ec4f82443a5d5548cdcf84051a7a40abdecbf4a4393a8217a3ca441bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58d4d40ec4f82443a5d5548cdcf84051a7a40abdecbf4a4393a8217a3ca441bd", kill_on_drop: false }` [INFO] [stdout] 58d4d40ec4f82443a5d5548cdcf84051a7a40abdecbf4a4393a8217a3ca441bd