[INFO] fetching crate imagemusic 1.0.1... [INFO] checking imagemusic-1.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate imagemusic 1.0.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate imagemusic 1.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate imagemusic 1.0.1 [INFO] finished tweaking crates.io crate imagemusic 1.0.1 [INFO] tweaked toml for crates.io crate imagemusic 1.0.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate imagemusic 1.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29874dad9d97e1eab0cea79544b5849809b1707e84f9da81b55db836103b14e5 [INFO] running `Command { std: "docker" "start" "-a" "29874dad9d97e1eab0cea79544b5849809b1707e84f9da81b55db836103b14e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29874dad9d97e1eab0cea79544b5849809b1707e84f9da81b55db836103b14e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29874dad9d97e1eab0cea79544b5849809b1707e84f9da81b55db836103b14e5", kill_on_drop: false }` [INFO] [stdout] 29874dad9d97e1eab0cea79544b5849809b1707e84f9da81b55db836103b14e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e0bbdd2e18260c410cbb1f71456f3f34992dee5b6670b503cdd1d190ce6287a9 [INFO] running `Command { std: "docker" "start" "-a" "e0bbdd2e18260c410cbb1f71456f3f34992dee5b6670b503cdd1d190ce6287a9", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.18 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling rayon-core v1.7.1 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.63 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling serde_json v1.0.55 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling bumpalo v3.4.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.63 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking adler32 v1.1.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking adler v0.2.2 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling rayon v1.3.1 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking deflate v0.8.4 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking quick-xml v0.17.2 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking miniz_oxide v0.4.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking png v0.16.6 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking ryu v1.0.5 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking bytemuck v1.2.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking flate2 v1.0.16 [INFO] [stderr] Checking rand_pcg v0.2.1 [INFO] [stderr] Checking minidom v0.12.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking base64 v0.12.1 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking bitflags v1.2.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking jpeg-decoder v0.1.19 [INFO] [stderr] Checking image v0.23.6 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.63 [INFO] [stderr] Compiling serde_derive v1.0.111 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.63 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.63 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking bstr v0.2.13 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Checking tinytemplate v1.1.0 [INFO] [stderr] Checking js-sys v0.3.40 [INFO] [stderr] Checking criterion v0.3.3 [INFO] [stderr] Checking web-sys v0.3.40 [INFO] [stderr] Checking imagemusic v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:53:22 [INFO] [stdout] | [INFO] [stdout] 53 | Ok(Box::into_raw(Box::new(song))) [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 64 | Ok(Box::into_raw(Box::new(song))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/lib.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | Box::from_raw(song); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 70 | let _ = Box::from_raw(song); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:123:22 [INFO] [stdout] | [INFO] [stdout] 116 | let mut decoder = GzDecoder::new(&payload[..]); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Box::into_raw(Box::new(song))) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/instrument.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Debug, Serialize, Deserialize, Copy, Clone, Hash, PartialEq, Eq, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/musicxml.rs:350:22 [INFO] [stdout] | [INFO] [stdout] 350 | for part_list in root.children().find(|e| e.name() == "part-list") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 350 | while let Some(part_list) = root.children().find(|e| e.name() == "part-list") { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 350 | if let Some(part_list) = root.children().find(|e| e.name() == "part-list") { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/musicxml.rs:352:23 [INFO] [stdout] | [INFO] [stdout] 352 | for id in score_part.attr("id") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 352 | while let Some(id) = score_part.attr("id") { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 352 | if let Some(id) = score_part.attr("id") { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/musicxml.rs:353:29 [INFO] [stdout] | [INFO] [stdout] 353 | for name in score_part.children().find(|e| e.name() == "part-name") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 353 | while let Some(name) = score_part.children().find(|e| e.name() == "part-name") { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 353 | if let Some(name) = score_part.children().find(|e| e.name() == "part-name") { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/note.rs:9:41 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq, Hash)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `imagemusic` (lib) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "e0bbdd2e18260c410cbb1f71456f3f34992dee5b6670b503cdd1d190ce6287a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0bbdd2e18260c410cbb1f71456f3f34992dee5b6670b503cdd1d190ce6287a9", kill_on_drop: false }` [INFO] [stdout] e0bbdd2e18260c410cbb1f71456f3f34992dee5b6670b503cdd1d190ce6287a9