[INFO] fetching crate image-recovery 0.3.1... [INFO] checking image-recovery-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate image-recovery 0.3.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate image-recovery 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate image-recovery 0.3.1 [INFO] finished tweaking crates.io crate image-recovery 0.3.1 [INFO] tweaked toml for crates.io crate image-recovery 0.3.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate image-recovery 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d44bda7bf98851c32497ba84793b06e7381af9588749f3a36ef3055f19725e9 [INFO] running `Command { std: "docker" "start" "-a" "5d44bda7bf98851c32497ba84793b06e7381af9588749f3a36ef3055f19725e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d44bda7bf98851c32497ba84793b06e7381af9588749f3a36ef3055f19725e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d44bda7bf98851c32497ba84793b06e7381af9588749f3a36ef3055f19725e9", kill_on_drop: false }` [INFO] [stdout] 5d44bda7bf98851c32497ba84793b06e7381af9588749f3a36ef3055f19725e9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6236acb2268794dbd7818fee9bf7276fac72fd0347a00ddca893ce838894495b [INFO] running `Command { std: "docker" "start" "-a" "6236acb2268794dbd7818fee9bf7276fac72fd0347a00ddca893ce838894495b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking simd-adler32 v0.3.5 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Compiling matrixmultiply v0.3.7 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking flate2 v1.0.26 [INFO] [stderr] Compiling quote v1.0.31 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking thread-tree v0.3.3 [INFO] [stderr] Compiling syn v2.0.26 [INFO] [stderr] Checking png v0.17.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking num-complex v0.4.3 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Checking tiff v0.8.1 [INFO] [stderr] Compiling pin-project-internal v1.1.2 [INFO] [stderr] Checking pin-project v1.1.2 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking exr v1.7.0 [INFO] [stderr] Checking image v0.24.6 [INFO] [stderr] Checking image-recovery v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image_array.rs:101:47 [INFO] [stdout] | [INFO] [stdout] 101 | let flat = self.map_axis(Axis(2), |v| v.map(|&x| x as u8).to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | let shifted = self.positive_shift_on_axis(axis)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Ok(self - &shifted) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 63 | let shifted = self.negative_shift_on_axis(axis)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | Ok(self - &shifted) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:89:43 [INFO] [stdout] | [INFO] [stdout] 88 | let (a, b) = self.view().split_at(Axis(axis), last_index_of_axis); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ndarray::concatenate(Axis(axis), &[b, a]) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:110:43 [INFO] [stdout] | [INFO] [stdout] 109 | let (a, b) = self.view().split_at(Axis(axis), 1); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ndarray::concatenate(Axis(axis), &[b, a]) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 69 | let mut current: Array3 = self.deref().clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut previous: Array3; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | // primal variable "bar" [INFO] [stdout] 72 | let mut current_bar = current.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | // dual variables [INFO] [stdout] 74 | let mut dual_a = current.positive_gradient_on_axis(0)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut dual_b = current.positive_gradient_on_axis(1)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(ImageArray::from(¤t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `image-recovery` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/image_array.rs:101:47 [INFO] [stdout] | [INFO] [stdout] 101 | let flat = self.map_axis(Axis(2), |v| v.map(|&x| x as u8).to_vec()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 38 | let shifted = self.positive_shift_on_axis(axis)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | [INFO] [stdout] 40 | Ok(self - &shifted) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 63 | let shifted = self.negative_shift_on_axis(axis)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | [INFO] [stdout] 65 | Ok(self - &shifted) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:89:43 [INFO] [stdout] | [INFO] [stdout] 88 | let (a, b) = self.view().split_at(Axis(axis), last_index_of_axis); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ndarray::concatenate(Axis(axis), &[b, a]) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:110:43 [INFO] [stdout] | [INFO] [stdout] 109 | let (a, b) = self.view().split_at(Axis(axis), 1); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ndarray::concatenate(Axis(axis), &[b, a]) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:329:39 [INFO] [stdout] | [INFO] [stdout] 329 | bench.iter(|| test::black_box(a.positive_gradient_on_axis(2).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/gradient.rs:337:39 [INFO] [stdout] | [INFO] [stdout] 337 | bench.iter(|| test::black_box(a.negative_gradient_on_axis(2).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops/vector_len.rs:112:39 [INFO] [stdout] | [INFO] [stdout] 112 | bench.iter(|| test::black_box(a.vector_len_on_axis(&b, 2).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/solvers.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 69 | let mut current: Array3 = self.deref().clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut previous: Array3; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | // primal variable "bar" [INFO] [stdout] 72 | let mut current_bar = current.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | // dual variables [INFO] [stdout] 74 | let mut dual_a = current.positive_gradient_on_axis(0)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let mut dual_b = current.positive_gradient_on_axis(1)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(ImageArray::from(¤t)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `image-recovery` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "6236acb2268794dbd7818fee9bf7276fac72fd0347a00ddca893ce838894495b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6236acb2268794dbd7818fee9bf7276fac72fd0347a00ddca893ce838894495b", kill_on_drop: false }` [INFO] [stdout] 6236acb2268794dbd7818fee9bf7276fac72fd0347a00ddca893ce838894495b