[INFO] fetching crate imag-notes 0.10.1... [INFO] checking imag-notes-0.10.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate imag-notes 0.10.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate imag-notes 0.10.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate imag-notes 0.10.1 [INFO] finished tweaking crates.io crate imag-notes 0.10.1 [INFO] tweaked toml for crates.io crate imag-notes 0.10.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate imag-notes 0.10.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bbfa4b4dd5978488000722e724542055207946e24d5f0038ef5d50a7a8b19a5 [INFO] running `Command { std: "docker" "start" "-a" "3bbfa4b4dd5978488000722e724542055207946e24d5f0038ef5d50a7a8b19a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bbfa4b4dd5978488000722e724542055207946e24d5f0038ef5d50a7a8b19a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bbfa4b4dd5978488000722e724542055207946e24d5f0038ef5d50a7a8b19a5", kill_on_drop: false }` [INFO] [stdout] 3bbfa4b4dd5978488000722e724542055207946e24d5f0038ef5d50a7a8b19a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7c74393041907ad4ac3e296e0b6ea049fb473a0dd559d1e2b34eaecee0dae651 [INFO] running `Command { std: "docker" "start" "-a" "7c74393041907ad4ac3e296e0b6ea049fb473a0dd559d1e2b34eaecee0dae651", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.67 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking aho-corasick v0.7.9 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling ucd-trie v0.1.2 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.12 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking backtrace v0.3.44 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking semver-parser v0.7.0 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling pest_generator v2.1.2 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking is-match v0.1.0 [INFO] [stderr] Checking boolinator v2.4.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking libimagutil v0.10.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking hashbrown v0.5.0 [INFO] [stderr] Compiling darling_core v0.8.6 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking interactor v0.1.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking handlebars v2.0.4 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking xdg-basedir v1.0.0 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking libimagerror v0.10.1 [INFO] [stderr] Checking resiter v0.4.0 [INFO] [stderr] Compiling darling_macro v0.8.6 [INFO] [stderr] Compiling darling v0.8.6 [INFO] [stderr] Compiling toml-query_derive v0.9.2 [INFO] [stderr] Checking toml-query v0.9.2 [INFO] [stderr] Checking libimagstore v0.10.1 [INFO] [stderr] Checking libimaginteraction v0.10.1 [INFO] [stderr] Checking libimagrt v0.10.1 [INFO] [stderr] Checking libimagentryedit v0.10.1 [INFO] [stderr] Checking libimagnotes v0.10.1 [INFO] [stderr] Checking imag-notes v0.10.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 116 | let mut note = rt.store().new_note(name, String::new())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | rt.report_touched(note.get_location()).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 135 | .and_then(|mut note| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | note.edit_content(rt).map_warn_err_str("Editing failed")?; [INFO] [stdout] 137 | rt.report_touched(note.get_location()).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:151:33 [INFO] [stdout] | [INFO] [stdout] 151 | .sorted_by(|a, b| match (a.get_name(), b.get_name()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 155 | .map(|note| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | rt.report_touched(note.get_location()).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn build_ui<'a>(app: App<'a, 'a>) -> App<'a, 'a> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | / app [INFO] [stdout] 24 | | .subcommand(SubCommand::with_name("create") [INFO] [stdout] 25 | | .about("Create a note") [INFO] [stdout] 26 | | .version("0.1") [INFO] [stdout] ... | [INFO] [stdout] 59 | | .value_name("NAME")) [INFO] [stdout] 60 | | ) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn build_ui<'a>(app: App<'a, 'a>) -> App<'a, 'a> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | .subcommand(SubCommand::with_name("list") [INFO] [stdout] | _____________________^ [INFO] [stdout] 63 | | .about("List Notes") [INFO] [stdout] 64 | | .version("0.1")) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `imag-notes` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 116 | let mut note = rt.store().new_note(name, String::new())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | rt.report_touched(note.get_location()).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 135 | .and_then(|mut note| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | note.edit_content(rt).map_warn_err_str("Editing failed")?; [INFO] [stdout] 137 | rt.report_touched(note.get_location()).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:151:33 [INFO] [stdout] | [INFO] [stdout] 151 | .sorted_by(|a, b| match (a.get_name(), b.get_name()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 155 | .map(|note| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | rt.report_touched(note.get_location()).map_err(Error::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn build_ui<'a>(app: App<'a, 'a>) -> App<'a, 'a> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | / app [INFO] [stdout] 24 | | .subcommand(SubCommand::with_name("create") [INFO] [stdout] 25 | | .about("Create a note") [INFO] [stdout] 26 | | .version("0.1") [INFO] [stdout] ... | [INFO] [stdout] 59 | | .value_name("NAME")) [INFO] [stdout] 60 | | ) [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui.rs:62:21 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn build_ui<'a>(app: App<'a, 'a>) -> App<'a, 'a> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | .subcommand(SubCommand::with_name("list") [INFO] [stdout] | _____________________^ [INFO] [stdout] 63 | | .about("List Notes") [INFO] [stdout] 64 | | .version("0.1")) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `imag-notes` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "7c74393041907ad4ac3e296e0b6ea049fb473a0dd559d1e2b34eaecee0dae651", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c74393041907ad4ac3e296e0b6ea049fb473a0dd559d1e2b34eaecee0dae651", kill_on_drop: false }` [INFO] [stdout] 7c74393041907ad4ac3e296e0b6ea049fb473a0dd559d1e2b34eaecee0dae651