[INFO] fetching crate illicit 1.1.2... [INFO] checking illicit-1.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate illicit 1.1.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate illicit 1.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate illicit 1.1.2 [INFO] finished tweaking crates.io crate illicit 1.1.2 [INFO] tweaked toml for crates.io crate illicit 1.1.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 85 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e72edd1ea3140c59cb42fd0d824f556823519685d042673ef279cbf9ffbcb34 [INFO] running `Command { std: "docker" "start" "-a" "8e72edd1ea3140c59cb42fd0d824f556823519685d042673ef279cbf9ffbcb34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e72edd1ea3140c59cb42fd0d824f556823519685d042673ef279cbf9ffbcb34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e72edd1ea3140c59cb42fd0d824f556823519685d042673ef279cbf9ffbcb34", kill_on_drop: false }` [INFO] [stdout] 8e72edd1ea3140c59cb42fd0d824f556823519685d042673ef279cbf9ffbcb34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a3a3059da84d4ba264a067a425f3aa819aadca15236d28fce0ba93d9ad953b76 [INFO] running `Command { std: "docker" "start" "-a" "a3a3059da84d4ba264a067a425f3aa819aadca15236d28fce0ba93d9ad953b76", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling illicit-macro v1.0.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking illicit v1.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking regex v1.10.6 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:408:28 [INFO] [stdout] | [INFO] [stdout] 407 | fn make_guard(self) -> impl Drop { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 408 | CURRENT_SCOPE.with(|parent| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 409 | | let mut parent = parent.borrow_mut(); [INFO] [stdout] 410 | | let parent = replace(&mut *parent, self); [INFO] [stdout] ... | [INFO] [stdout] 414 | | }) [INFO] [stdout] 415 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:456:9 [INFO] [stdout] | [INFO] [stdout] 455 | fn offer(self, op: impl FnOnce() -> R) -> R { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 456 | Layer::new().offer(self).enter(op) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:495:57 [INFO] [stdout] | [INFO] [stdout] 495 | let mut current: Layer = CURRENT_SCOPE.with(|s| (*s.borrow()).clone()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/anon_rc.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(inner: T, depth: u32) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let inner = Rc::new(inner); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | debug: inner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/anon_rc.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 36 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | ) -> Option + Debug + 'static> { [INFO] [stdout] 38 | / OwningRef::new(self.inner) [INFO] [stdout] 39 | | .try_map(|anon| { [INFO] [stdout] 40 | | let res: Result<&T, &str> = anon.downcast_ref().ok_or("invalid cast"); [INFO] [stdout] 41 | | res [INFO] [stdout] 42 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `illicit` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a3a3059da84d4ba264a067a425f3aa819aadca15236d28fce0ba93d9ad953b76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a3a3059da84d4ba264a067a425f3aa819aadca15236d28fce0ba93d9ad953b76", kill_on_drop: false }` [INFO] [stdout] a3a3059da84d4ba264a067a425f3aa819aadca15236d28fce0ba93d9ad953b76