[INFO] fetching crate ili9163_driver 1.0.0... [INFO] checking ili9163_driver-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ili9163_driver 1.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ili9163_driver 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ili9163_driver 1.0.0 [INFO] finished tweaking crates.io crate ili9163_driver 1.0.0 [INFO] tweaked toml for crates.io crate ili9163_driver 1.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4154229ee19457f5a4b82c070e7bf029868c99b8180c6aaa27ffe167fe199d2f [INFO] running `Command { std: "docker" "start" "-a" "4154229ee19457f5a4b82c070e7bf029868c99b8180c6aaa27ffe167fe199d2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4154229ee19457f5a4b82c070e7bf029868c99b8180c6aaa27ffe167fe199d2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4154229ee19457f5a4b82c070e7bf029868c99b8180c6aaa27ffe167fe199d2f", kill_on_drop: false }` [INFO] [stdout] 4154229ee19457f5a4b82c070e7bf029868c99b8180c6aaa27ffe167fe199d2f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3d623b2401f2ac00b0f253d8954139be02e38f8b0552d1f7567af0dc82495300 [INFO] running `Command { std: "docker" "start" "-a" "3d623b2401f2ac00b0f253d8954139be02e38f8b0552d1f7567af0dc82495300", kill_on_drop: false }` [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking ili9163_driver v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(spi: S, write_mode: G, delay: D, backlight: G, reset: G) -> Ili9163 { [INFO] [stdout] | ------ ------------- -------- ------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Ili9163{ [INFO] [stdout] 89 | driver: IliDriver::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 90 | | spi, write_mode, [INFO] [stdout] 91 | | delay, pixel_func::no_write, [INFO] [stdout] 92 | | bitmap_func::no_write), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn initialize_for_18bit_pixel(mut self) -> Result, IliErrorType> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let driver = IliDriver::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(Ili9163{ [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | driver, [INFO] [stdout] 109 | | reset_pin: self.reset_pin, [INFO] [stdout] 110 | | backlight: self.backlight, [INFO] [stdout] 111 | | rgb2pixel: rgb_convert::to_18bit [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn initialize_for_16bit_pixel(mut self) -> Result, IliErrorType> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let driver = IliDriver::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Ili9163{ [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | driver, [INFO] [stdout] 126 | | reset_pin: self.reset_pin, [INFO] [stdout] 127 | | backlight: self.backlight, [INFO] [stdout] 128 | | rgb2pixel: rgb_convert::to_16bit [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn initialize_for_12bit_pixel(mut self) -> Result, IliErrorType> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let driver = IliDriver::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(Ili9163{ [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | driver, [INFO] [stdout] 143 | | reset_pin: self.reset_pin, [INFO] [stdout] 144 | | backlight: self.backlight, [INFO] [stdout] 145 | | rgb2pixel: rgb_convert::to_12bit [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ili9163_driver` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn new(spi: S, write_mode: G, delay: D, backlight: G, reset: G) -> Ili9163 { [INFO] [stdout] | ------ ------------- -------- ------------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | Ili9163{ [INFO] [stdout] 89 | driver: IliDriver::new( [INFO] [stdout] | _____________________^ [INFO] [stdout] 90 | | spi, write_mode, [INFO] [stdout] 91 | | delay, pixel_func::no_write, [INFO] [stdout] 92 | | bitmap_func::no_write), [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:107:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn initialize_for_18bit_pixel(mut self) -> Result, IliErrorType> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let driver = IliDriver::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | Ok(Ili9163{ [INFO] [stdout] | ____________^ [INFO] [stdout] 108 | | driver, [INFO] [stdout] 109 | | reset_pin: self.reset_pin, [INFO] [stdout] 110 | | backlight: self.backlight, [INFO] [stdout] 111 | | rgb2pixel: rgb_convert::to_18bit [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:12 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn initialize_for_16bit_pixel(mut self) -> Result, IliErrorType> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let driver = IliDriver::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Ok(Ili9163{ [INFO] [stdout] | ____________^ [INFO] [stdout] 125 | | driver, [INFO] [stdout] 126 | | reset_pin: self.reset_pin, [INFO] [stdout] 127 | | backlight: self.backlight, [INFO] [stdout] 128 | | rgb2pixel: rgb_convert::to_16bit [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn initialize_for_12bit_pixel(mut self) -> Result, IliErrorType> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let driver = IliDriver::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | Ok(Ili9163{ [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | driver, [INFO] [stdout] 143 | | reset_pin: self.reset_pin, [INFO] [stdout] 144 | | backlight: self.backlight, [INFO] [stdout] 145 | | rgb2pixel: rgb_convert::to_12bit [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ili9163_driver` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "3d623b2401f2ac00b0f253d8954139be02e38f8b0552d1f7567af0dc82495300", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d623b2401f2ac00b0f253d8954139be02e38f8b0552d1f7567af0dc82495300", kill_on_drop: false }` [INFO] [stdout] 3d623b2401f2ac00b0f253d8954139be02e38f8b0552d1f7567af0dc82495300