[INFO] fetching crate igniter 0.1.2... [INFO] checking igniter-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate igniter 0.1.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate igniter 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate igniter 0.1.2 [INFO] finished tweaking crates.io crate igniter 0.1.2 [INFO] tweaked toml for crates.io crate igniter 0.1.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.9.1 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding config v0.7.1 (latest: v0.14.0) [INFO] [stderr] Adding csv v0.15.0 (latest: v1.3.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding linked-hash-map v0.3.0 (latest: v0.5.6) [INFO] [stderr] Adding memchr v1.0.2 (latest: v2.7.4) [INFO] [stderr] Adding nix v0.9.0 (latest: v0.29.0) [INFO] [stderr] Adding nom v3.2.1 (latest: v7.1.3) [INFO] [stderr] Adding num-traits v0.1.43 (latest: v0.2.19) [INFO] [stderr] Adding prettytable-rs v0.6.7 (latest: v0.10.0) [INFO] [stderr] Adding serde v0.8.23 (latest: v1.0.209) [INFO] [stderr] Adding serde-hjson v0.8.2 (latest: v1.0.0) [INFO] [stderr] Adding serde_test v0.8.23 (latest: v1.0.177) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding term v0.4.6 (latest: v1.0.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding toml v0.4.10 (latest: v0.8.19) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding yaml-rust v0.3.5 (latest: v0.4.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4cee36b7fe44eb1714081bebf7dbad52e175c3e5618287788e246a6db76277f0 [INFO] running `Command { std: "docker" "start" "-a" "4cee36b7fe44eb1714081bebf7dbad52e175c3e5618287788e246a6db76277f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4cee36b7fe44eb1714081bebf7dbad52e175c3e5618287788e246a6db76277f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4cee36b7fe44eb1714081bebf7dbad52e175c3e5618287788e246a6db76277f0", kill_on_drop: false }` [INFO] [stdout] 4cee36b7fe44eb1714081bebf7dbad52e175c3e5618287788e246a6db76277f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6003163c333554fbd7ff2eba262a309f404deff5ddb783743b8fc575dedea664 [INFO] running `Command { std: "docker" "start" "-a" "6003163c333554fbd7ff2eba262a309f404deff5ddb783743b8fc575dedea664", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking serde v0.8.23 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking bitflags v0.9.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking term v0.4.6 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking serde_test v0.8.23 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking linked-hash-map v0.3.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.9.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking ctrlc v3.4.5 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking serde-hjson v0.8.2 [INFO] [stderr] Checking config v0.7.1 [INFO] [stderr] Checking igniter v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/monitor/file.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::env::home_dir; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/monitor/file.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | format!("{}/.igniter/procs", home_dir().unwrap().display()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/monitor/file.rs:4:15 [INFO] [stdout] | [INFO] [stdout] 4 | use std::env::home_dir; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/monitor/file.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | format!("{}/.igniter/procs", home_dir().unwrap().display()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `pid`, `tty`, `time`, and `cmd` are never read [INFO] [stdout] --> src/os.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Process { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 10 | pid: i32, [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | tty: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | time: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | cmd: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Process` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/mod.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 41 | fs::read_dir(base_path).unwrap().map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let file = entry.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | file::read(path).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/file.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | match fs::File::create(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/process.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 33 | let mut command = Command::new(self.data.cmd.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match command.spawn() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 11 | let mut config = Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | config.try_into::().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 25 | let mut ps = Command::new("ps"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | match ps.output() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `igniter` (lib) due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `pid`, `tty`, `time`, and `cmd` are never read [INFO] [stdout] --> src/os.rs:10:3 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Process { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 10 | pid: i32, [INFO] [stdout] | ^^^ [INFO] [stdout] 11 | tty: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | time: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | cmd: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Process` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/mod.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 41 | fs::read_dir(base_path).unwrap().map(|entry| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | let file = entry.unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | file::read(path).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/file.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | match fs::File::create(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/monitor/process.rs:38:11 [INFO] [stdout] | [INFO] [stdout] 33 | let mut command = Command::new(self.data.cmd.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | match command.spawn() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/settings.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 11 | let mut config = Config::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | config.try_into::().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 25 | let mut ps = Command::new("ps"); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | match ps.output() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `igniter` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6003163c333554fbd7ff2eba262a309f404deff5ddb783743b8fc575dedea664", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6003163c333554fbd7ff2eba262a309f404deff5ddb783743b8fc575dedea664", kill_on_drop: false }` [INFO] [stdout] 6003163c333554fbd7ff2eba262a309f404deff5ddb783743b8fc575dedea664