[INFO] fetching crate iffi-macros 0.0.1... [INFO] checking iffi-macros-0.0.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iffi-macros 0.0.1 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate iffi-macros 0.0.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iffi-macros 0.0.1 [INFO] finished tweaking crates.io crate iffi-macros 0.0.1 [INFO] tweaked toml for crates.io crate iffi-macros 0.0.1 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 5 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 131db7932ce4e68e26218588916f0b6672919b052e55c420e3b1f4cee7221558 [INFO] running `Command { std: "docker" "start" "-a" "131db7932ce4e68e26218588916f0b6672919b052e55c420e3b1f4cee7221558", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "131db7932ce4e68e26218588916f0b6672919b052e55c420e3b1f4cee7221558", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "131db7932ce4e68e26218588916f0b6672919b052e55c420e3b1f4cee7221558", kill_on_drop: false }` [INFO] [stdout] 131db7932ce4e68e26218588916f0b6672919b052e55c420e3b1f4cee7221558 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c80246737ec4a12edb7b77a002d8d0b079a6a263bc8de1ee8c8c4fda34e1e8e [INFO] running `Command { std: "docker" "start" "-a" "9c80246737ec4a12edb7b77a002d8d0b079a6a263bc8de1ee8c8c4fda34e1e8e", kill_on_drop: false }` [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Checking iffi-macros v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 39 | let data = FieldData::from_attrs(&field.attrs)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let superset = match data.superset { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Superset::Default => quote! { [INFO] [stdout] | __________________________________- [INFO] [stdout] 42 | | iffi::MaybeInvalid<#ty> [INFO] [stdout] 43 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Superset::Type(ty) => ty.to_token_stream(), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Field { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 48 | | colon_token: field.colon_token, [INFO] [stdout] 49 | | mutability: FieldMutability::None, [INFO] [stdout] 50 | | vis: field.vis.clone(), [INFO] [stdout] ... | [INFO] [stdout] 53 | | ty: Type::Verbatim(superset), [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:308:24 [INFO] [stdout] | [INFO] [stdout] 291 | let named_fields = sanitize_fields(&variant.fields); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let mut fields = fields_def(&named_fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(Item { [INFO] [stdout] | ________________________^ [INFO] [stdout] 309 | | generics: input.generics.clone(), [INFO] [stdout] 310 | | data: ItemData::Struct(fields), [INFO] [stdout] 311 | | ident: variant_fields_ident(&variant.ident), [INFO] [stdout] 312 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:324:36 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | Field { [INFO] [stdout] 324 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:327:34 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | vis: Visibility::Inherited, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:328:33 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | ty: Type::Verbatim(quote! { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 329 | | ::core::mem::ManuallyDrop<#variant_fields> [INFO] [stdout] 330 | | }), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:331:36 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | ident: Some(variant.ident.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nicheless.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 36 | fn try_from(input: DeriveInput) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let data = match input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Data::Struct(data) => ItemData::Struct(data.fields), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Data::Enum(data) => ItemData::Enum(data.variants), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Data::Union(data) => ItemData::Union(data.fields), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Item { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | ident: input.ident, [INFO] [stdout] 45 | | generics: input.generics, [INFO] [stdout] 46 | | data, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 39 | let data = FieldData::from_attrs(&field.attrs)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let superset = match data.superset { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Superset::Default => quote! { [INFO] [stdout] | __________________________________- [INFO] [stdout] 42 | | iffi::MaybeInvalid<#ty> [INFO] [stdout] 43 | | }, [INFO] [stdout] | |_____________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Superset::Type(ty) => ty.to_token_stream(), [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Field { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 48 | | colon_token: field.colon_token, [INFO] [stdout] 49 | | mutability: FieldMutability::None, [INFO] [stdout] 50 | | vis: field.vis.clone(), [INFO] [stdout] ... | [INFO] [stdout] 53 | | ty: Type::Verbatim(superset), [INFO] [stdout] 54 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:308:24 [INFO] [stdout] | [INFO] [stdout] 291 | let named_fields = sanitize_fields(&variant.fields); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let mut fields = fields_def(&named_fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(Item { [INFO] [stdout] | ________________________^ [INFO] [stdout] 309 | | generics: input.generics.clone(), [INFO] [stdout] 310 | | data: ItemData::Struct(fields), [INFO] [stdout] 311 | | ident: variant_fields_ident(&variant.ident), [INFO] [stdout] 312 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:324:36 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 323 | Field { [INFO] [stdout] 324 | attrs: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:327:34 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 327 | vis: Visibility::Inherited, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:328:33 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | ty: Type::Verbatim(quote! { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 329 | | ::core::mem::ManuallyDrop<#variant_fields> [INFO] [stdout] 330 | | }), [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:331:36 [INFO] [stdout] | [INFO] [stdout] 322 | let variant_fields = variant_fields_ident(&variant.ident); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | ident: Some(variant.ident.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nicheless.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 36 | fn try_from(input: DeriveInput) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let data = match input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Data::Struct(data) => ItemData::Struct(data.fields), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Data::Enum(data) => ItemData::Enum(data.variants), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Data::Union(data) => ItemData::Union(data.fields), [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | Ok(Item { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | ident: input.ident, [INFO] [stdout] 45 | | generics: input.generics, [INFO] [stdout] 46 | | data, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iffi-macros` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iffi-macros` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "9c80246737ec4a12edb7b77a002d8d0b079a6a263bc8de1ee8c8c4fda34e1e8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c80246737ec4a12edb7b77a002d8d0b079a6a263bc8de1ee8c8c4fda34e1e8e", kill_on_drop: false }` [INFO] [stdout] 9c80246737ec4a12edb7b77a002d8d0b079a6a263bc8de1ee8c8c4fda34e1e8e