[INFO] fetching crate if-changed 0.3.2... [INFO] checking if-changed-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate if-changed 0.3.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate if-changed 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate if-changed 0.3.2 [INFO] finished tweaking crates.io crate if-changed 0.3.2 [INFO] tweaked toml for crates.io crate if-changed 0.3.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate if-changed 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd8d7d40dc52f0b6724b295c924b5cee5a26131952b4cfa9bc505b163c4c3b77 [INFO] running `Command { std: "docker" "start" "-a" "cd8d7d40dc52f0b6724b295c924b5cee5a26131952b4cfa9bc505b163c4c3b77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd8d7d40dc52f0b6724b295c924b5cee5a26131952b4cfa9bc505b163c4c3b77", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd8d7d40dc52f0b6724b295c924b5cee5a26131952b4cfa9bc505b163c4c3b77", kill_on_drop: false }` [INFO] [stdout] cd8d7d40dc52f0b6724b295c924b5cee5a26131952b4cfa9bc505b163c4c3b77 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68afef6abdabac93513fb91a618e130f7650b795f47bc60b975be1e77d514981 [INFO] running `Command { std: "docker" "start" "-a" "68afef6abdabac93513fb91a618e130f7650b795f47bc60b975be1e77d514981", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking genawaiter-macro v0.99.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling if-changed v0.3.2 (/opt/rustwide/workdir) [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking similar v2.5.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling syn-mid v0.5.4 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling genawaiter-proc-macro v0.99.1 [INFO] [stderr] Checking genawaiter v0.99.1 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:35:33 [INFO] [stdout] | [INFO] [stdout] 35 | .map(|head| head.peel_to_tree().unwrap()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|commit| commit.tree().unwrap()), [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 79 | fn diff(&self, mut options: impl BorrowMut) -> git2::Diff { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | / match &self.to_tree { [INFO] [stdout] 81 | | Some(to_tree) => self.repository.diff_tree_to_tree( [INFO] [stdout] 82 | | self.from_tree.as_ref(), [INFO] [stdout] 83 | | Some(to_tree), [INFO] [stdout] ... | [INFO] [stdout] 89 | | ), [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 151 | fn resolve(&self, path: impl AsRef) -> PathBuf { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | / self.repository [INFO] [stdout] 153 | | .workdir() [INFO] [stdout] 154 | | .expect("bare repos are not supported") [INFO] [stdout] 155 | | .canonicalize() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> parser.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 87 | relpath: impl AsRef, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> Result { [INFO] [stdout] 90 | Ok(Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | path: relpath.as_ref().to_owned(), [INFO] [stdout] 92 | | lines: io::BufReader::new(match fs::File::open(&path) { [INFO] [stdout] 93 | | Ok(file) => file, [INFO] [stdout] ... | [INFO] [stdout] 98 | | blocks: Vec::new(), [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `if-changed` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:35:33 [INFO] [stdout] | [INFO] [stdout] 35 | .map(|head| head.peel_to_tree().unwrap()), [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|commit| commit.tree().unwrap()), [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 79 | fn diff(&self, mut options: impl BorrowMut) -> git2::Diff { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | / match &self.to_tree { [INFO] [stdout] 81 | | Some(to_tree) => self.repository.diff_tree_to_tree( [INFO] [stdout] 82 | | self.from_tree.as_ref(), [INFO] [stdout] 83 | | Some(to_tree), [INFO] [stdout] ... | [INFO] [stdout] 89 | | ), [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine/git.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 151 | fn resolve(&self, path: impl AsRef) -> PathBuf { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | / self.repository [INFO] [stdout] 153 | | .workdir() [INFO] [stdout] 154 | | .expect("bare repos are not supported") [INFO] [stdout] 155 | | .canonicalize() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> parser.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 87 | relpath: impl AsRef, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | ) -> Result { [INFO] [stdout] 90 | Ok(Parser { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | path: relpath.as_ref().to_owned(), [INFO] [stdout] 92 | | lines: io::BufReader::new(match fs::File::open(&path) { [INFO] [stdout] 93 | | Ok(file) => file, [INFO] [stdout] ... | [INFO] [stdout] 98 | | blocks: Vec::new(), [INFO] [stdout] 99 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `if-changed` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "68afef6abdabac93513fb91a618e130f7650b795f47bc60b975be1e77d514981", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68afef6abdabac93513fb91a618e130f7650b795f47bc60b975be1e77d514981", kill_on_drop: false }` [INFO] [stdout] 68afef6abdabac93513fb91a618e130f7650b795f47bc60b975be1e77d514981