[INFO] fetching crate idlset 0.2.5... [INFO] checking idlset-0.2.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate idlset 0.2.5 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate idlset 0.2.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate idlset 0.2.5 [INFO] finished tweaking crates.io crate idlset 0.2.5 [INFO] tweaked toml for crates.io crate idlset 0.2.5 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b8dc646f137e9766faf053d9e9eb6de465f4a15d9a6bffd2435e5aea3ff0d0d [INFO] running `Command { std: "docker" "start" "-a" "8b8dc646f137e9766faf053d9e9eb6de465f4a15d9a6bffd2435e5aea3ff0d0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b8dc646f137e9766faf053d9e9eb6de465f4a15d9a6bffd2435e5aea3ff0d0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b8dc646f137e9766faf053d9e9eb6de465f4a15d9a6bffd2435e5aea3ff0d0d", kill_on_drop: false }` [INFO] [stdout] 8b8dc646f137e9766faf053d9e9eb6de465f4a15d9a6bffd2435e5aea3ff0d0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e7f3f0534879eeb0cc8027e69671829c37f2ad59bb1192d4b3330d1fe01e0ac [INFO] running `Command { std: "docker" "start" "-a" "7e7f3f0534879eeb0cc8027e69671829c37f2ad59bb1192d4b3330d1fe01e0ac", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking idlset v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::IDLSimple` [INFO] [stdout] --> benches/idl_simple.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | use super::IDLSimple; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `idlset::AndNot` [INFO] [stdout] --> benches/idl_simple.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 214 | use idlset::AndNot; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::FromIterator` [INFO] [stdout] --> benches/idl_simple.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | use std::iter::FromIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:165:38 [INFO] [stdout] | [INFO] [stdout] 165 | |t, RDuplex(a, b)| t.iter(|| { b | a }.sum()), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:170:39 [INFO] [stdout] | [INFO] [stdout] 170 | |t, V2Duplex(a, b)| t.iter(|| { b | a }.sum()), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:187:38 [INFO] [stdout] | [INFO] [stdout] 187 | |t, RDuplex(a, b)| t.iter(|| { b & a }.sum()), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:193:39 [INFO] [stdout] | [INFO] [stdout] 193 | |t, V2Duplex(a, b)| t.iter(|| { b & a }.sum()), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:450:42 [INFO] [stdout] | [INFO] [stdout] 450 | |t, RTriplex(a, b, c)| t.iter(|| { &(a | b) | c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:455:43 [INFO] [stdout] | [INFO] [stdout] 455 | |t, V2Triplex(a, b, c)| t.iter(|| { &(a | b) | c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:468:42 [INFO] [stdout] | [INFO] [stdout] 468 | |t, RTriplex(a, b, c)| t.iter(|| { &(a & b) & c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:473:43 [INFO] [stdout] | [INFO] [stdout] 473 | |t, V2Triplex(a, b, c)| t.iter(|| { &(a & b) & c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:486:42 [INFO] [stdout] | [INFO] [stdout] 486 | |t, RTriplex(a, b, c)| t.iter(|| { &(a & b) | c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:491:43 [INFO] [stdout] | [INFO] [stdout] 491 | |t, V2Triplex(a, b, c)| t.iter(|| { &(a & b) | c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:504:42 [INFO] [stdout] | [INFO] [stdout] 504 | |t, RTriplex(a, b, c)| t.iter(|| { &(a | b) & c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:509:43 [INFO] [stdout] | [INFO] [stdout] 509 | |t, V2Triplex(a, b, c)| t.iter(|| { &(a | b) & c }.sum()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:652:17 [INFO] [stdout] | [INFO] [stdout] 651 | let idl_inter = c.iter().fold(IDLBitRange::new(), |acc, x| &acc | x); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 652 | { &(a & b) & &idl_inter }.sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> benches/bench_idl.rs:662:17 [INFO] [stdout] | [INFO] [stdout] 661 | let idl_inter = c.iter().fold(IDLBitRangeV2::new(), |acc, x| &acc | x); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 662 | { &(a & b) & &idl_inter }.sum() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `idlset` (bench "bench_idl") due to 15 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "7e7f3f0534879eeb0cc8027e69671829c37f2ad59bb1192d4b3330d1fe01e0ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e7f3f0534879eeb0cc8027e69671829c37f2ad59bb1192d4b3330d1fe01e0ac", kill_on_drop: false }` [INFO] [stdout] 7e7f3f0534879eeb0cc8027e69671829c37f2ad59bb1192d4b3330d1fe01e0ac