[INFO] fetching crate idhash 0.3.0... [INFO] checking idhash-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate idhash 0.3.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate idhash 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate idhash 0.3.0 [INFO] finished tweaking crates.io crate idhash 0.3.0 [INFO] tweaked toml for crates.io crate idhash 0.3.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate idhash 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57e4553100a9f05c1878d33995b27dcf3a820cd5737e38013a41950e432127a4 [INFO] running `Command { std: "docker" "start" "-a" "57e4553100a9f05c1878d33995b27dcf3a820cd5737e38013a41950e432127a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57e4553100a9f05c1878d33995b27dcf3a820cd5737e38013a41950e432127a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57e4553100a9f05c1878d33995b27dcf3a820cd5737e38013a41950e432127a4", kill_on_drop: false }` [INFO] [stdout] 57e4553100a9f05c1878d33995b27dcf3a820cd5737e38013a41950e432127a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 770aa539af38e922e0dce6ea06e84b61942a95171bd40dd60ed18e1a0e613d09 [INFO] running `Command { std: "docker" "start" "-a" "770aa539af38e922e0dce6ea06e84b61942a95171bd40dd60ed18e1a0e613d09", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling proc-macro2 v1.0.42 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling unicode-ident v1.0.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking lexical-util v0.8.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_json v1.0.82 [INFO] [stderr] Checking simdutf8 v0.1.3 [INFO] [stderr] Checking seahash v3.0.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.140 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking plotters-backend v0.3.4 [INFO] [stderr] Checking hash_hasher v2.0.3 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-bigint v0.4.2 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking plotters-svg v0.3.2 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking lexical-parse-integer v0.8.0 [INFO] [stderr] Compiling fasthash-sys v0.3.2 [INFO] [stderr] Checking lexical-write-integer v0.8.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking lexical-write-float v0.8.2 [INFO] [stderr] Checking lexical-parse-float v0.8.2 [INFO] [stderr] Checking xoroshiro128 v0.3.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking lexical-core v0.8.2 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking plotters v0.3.2 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking bstr v0.2.16 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking num v0.4.0 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling bytemuck_derive v1.1.1 [INFO] [stderr] Checking bytemuck v1.11.0 [INFO] [stderr] Checking arrow2 v0.12.0 [INFO] [stderr] Checking fasthash v0.4.0 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking idhash v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn calculate_idhash(batch_input: I, schema: Arc, config: IdHashConfig) -> u128 [INFO] [stdout] | -------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | / batch_input [INFO] [stdout] 22 | | .map(|batch| idhash_batch(batch, &schema, config)) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn calculate_idhash_par(batch_input: I, schema: Arc, config: IdHashConfig) -> u128 [INFO] [stdout] | -------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | / batch_input [INFO] [stdout] 33 | | .into_par_iter() [INFO] [stdout] 34 | | .map(|batch| idhash_batch(batch, &schema, config)) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hash_builder.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 128 | input: Chunk, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | / HashIterator( [INFO] [stdout] 136 | | input [INFO] [stdout] 137 | | .columns() [INFO] [stdout] 138 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 150 | | ) [INFO] [stdout] 151 | | .map(|row| hash128(row.into_iter().flatten().collect::>())) [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/unf_vector.rs:18:18 [INFO] [stdout] | [INFO] [stdout] 17 | let unf_digits = self.to_unf(digits, has_nulls); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Box::new(unf_digits.into_iter().map(move |x| { [INFO] [stdout] | __________________^ [INFO] [stdout] 19 | | let mut encoded_string: Vec = Vec::with_capacity(characters + 4); [INFO] [stdout] 20 | | for item in x.chars().take(characters) { [INFO] [stdout] 21 | | encoded_string.push(item as u8); [INFO] [stdout] ... | [INFO] [stdout] 25 | | encoded_string.into_iter().map(|x| x as u8).collect() [INFO] [stdout] 26 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:75:20 [INFO] [stdout] | [INFO] [stdout] 72 | fn from(item: Arc>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let boxed_item: Box = item.to_boxed(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | ThreadArrayChunk { [INFO] [stdout] 75 | array: Arc::new(boxed_item), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:112:53 [INFO] [stdout] | [INFO] [stdout] 112 | .map(|x| ThreadArrayChunk::from(Arc::new(x))) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `idhash` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "770aa539af38e922e0dce6ea06e84b61942a95171bd40dd60ed18e1a0e613d09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "770aa539af38e922e0dce6ea06e84b61942a95171bd40dd60ed18e1a0e613d09", kill_on_drop: false }` [INFO] [stdout] 770aa539af38e922e0dce6ea06e84b61942a95171bd40dd60ed18e1a0e613d09