[INFO] fetching crate id3-cli 0.2.1... [INFO] checking id3-cli-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate id3-cli 0.2.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate id3-cli 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate id3-cli 0.2.1 [INFO] finished tweaking crates.io crate id3-cli 0.2.1 [INFO] tweaked toml for crates.io crate id3-cli 0.2.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate id3-cli 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f009452f18089dc1f6a732ea11aca8dc1b5d051a304a6d01120c1d32d0a7afd [INFO] running `Command { std: "docker" "start" "-a" "1f009452f18089dc1f6a732ea11aca8dc1b5d051a304a6d01120c1d32d0a7afd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f009452f18089dc1f6a732ea11aca8dc1b5d051a304a6d01120c1d32d0a7afd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f009452f18089dc1f6a732ea11aca8dc1b5d051a304a6d01120c1d32d0a7afd", kill_on_drop: false }` [INFO] [stdout] 1f009452f18089dc1f6a732ea11aca8dc1b5d051a304a6d01120c1d32d0a7afd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9f913b7f4f8c1c569861c08d954c31cfebd4977e5ee4ecf3e55638b8084a767b [INFO] running `Command { std: "docker" "start" "-a" "9f913b7f4f8c1c569861c08d954c31cfebd4977e5ee4ecf3e55638b8084a767b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.127 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling serde_derive v1.0.142 [INFO] [stderr] Checking os_str_bytes v6.2.0 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde v1.0.142 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking once_cell v1.13.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking miniz_oxide v0.5.3 [INFO] [stderr] Checking uuid v1.1.2 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling mediatype v0.19.5 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Compiling serde_json v1.0.83 [INFO] [stderr] Checking cfb v0.7.3 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking pipe-trait v0.4.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.2 [INFO] [stderr] Checking cpufeatures v0.2.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking id3 v1.3.0 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking chrono v0.4.20 [INFO] [stderr] Checking infer v0.9.0 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking pretty_assertions v1.2.1 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking assert-cmp v0.2.0 [INFO] [stderr] Checking command-extra v1.0.0 [INFO] [stderr] Checking fs_extra v1.2.0 [INFO] [stderr] Checking text-block-macros v0.1.1 [INFO] [stderr] Checking sha2 v0.10.2 [INFO] [stderr] Compiling clap_derive v3.2.15 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling typed-builder v0.10.0 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking clap v3.2.16 [INFO] [stderr] Checking clap_complete v3.2.3 [INFO] [stderr] Checking clap-utilities v0.1.0 [INFO] [stderr] Checking serde_yaml v0.9.4 [INFO] [stderr] Checking id3-cli v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/get.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 226 | let mut iter = tag.pictures().map(|picture| &picture.data); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | / fs::write(output_picture, data) [INFO] [stdout] 234 | | .map_err(PictureFileWriteFailure::from) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/set.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 21 | fn set_text(args: SetText, set: impl FnOnce(&mut Tag, String)) -> Result<(), Error> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | .run(move |tag| set(tag, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(source: $source) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | source.pipe($intermediate::from).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 119 | indirect_convert!(serde_json::Error, DeserializationFailure); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `indirect_convert` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(source: $source) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | source.pipe($intermediate::from).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 120 | indirect_convert!(serde_yaml::Error, DeserializationFailure); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `indirect_convert` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/text_data/picture_type.rs:8:40 [INFO] [stdout] | [INFO] [stdout] 8 | Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize, Display, ValueEnum, Subcommand, [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn read_tag_from_path(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | / path.pipe_as_ref(read_file) [INFO] [stdout] 29 | | .map_err(|error| FileReadFailure { [INFO] [stdout] 30 | | file: path.as_ref().to_path_buf(), [INFO] [stdout] 31 | | error, [INFO] [stdout] 32 | | })? [INFO] [stdout] 33 | | .pipe(read_tag_from_data) [INFO] [stdout] 34 | | .map_err(TagReadFailure::from) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) fn read_tag_from_data(data: impl AsRef<[u8]>) -> id3::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | data.pipe_as_ref(Tag::read_from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `id3-cli` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/get.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 226 | let mut iter = tag.pictures().map(|picture| &picture.data); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | / fs::write(output_picture, data) [INFO] [stdout] 234 | | .map_err(PictureFileWriteFailure::from) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/set.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 21 | fn set_text(args: SetText, set: impl FnOnce(&mut Tag, String)) -> Result<(), Error> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | .run(move |tag| set(tag, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(source: $source) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | source.pipe($intermediate::from).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 119 | indirect_convert!(serde_json::Error, DeserializationFailure); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `indirect_convert` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 112 | fn from(source: $source) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | source.pipe($intermediate::from).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 120 | indirect_convert!(serde_yaml::Error, DeserializationFailure); [INFO] [stdout] | ------------------------------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `indirect_convert` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/text_data/picture_type.rs:8:40 [INFO] [stdout] | [INFO] [stdout] 8 | Debug, Clone, Copy, PartialEq, Eq, Deserialize, Serialize, Display, ValueEnum, Subcommand, [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn read_tag_from_path(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | / path.pipe_as_ref(read_file) [INFO] [stdout] 29 | | .map_err(|error| FileReadFailure { [INFO] [stdout] 30 | | file: path.as_ref().to_path_buf(), [INFO] [stdout] 31 | | error, [INFO] [stdout] 32 | | })? [INFO] [stdout] 33 | | .pipe(read_tag_from_data) [INFO] [stdout] 34 | | .map_err(TagReadFailure::from) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub(crate) fn read_tag_from_data(data: impl AsRef<[u8]>) -> id3::Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | data.pipe_as_ref(Tag::read_from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `id3-cli` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "9f913b7f4f8c1c569861c08d954c31cfebd4977e5ee4ecf3e55638b8084a767b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f913b7f4f8c1c569861c08d954c31cfebd4977e5ee4ecf3e55638b8084a767b", kill_on_drop: false }` [INFO] [stdout] 9f913b7f4f8c1c569861c08d954c31cfebd4977e5ee4ecf3e55638b8084a767b