[INFO] fetching crate iconv-compat-win-sys 0.1.1... [INFO] checking iconv-compat-win-sys-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iconv-compat-win-sys 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate iconv-compat-win-sys 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/.cargo/config.toml [INFO] started tweaking crates.io crate iconv-compat-win-sys 0.1.1 [INFO] finished tweaking crates.io crate iconv-compat-win-sys 0.1.1 [INFO] tweaked toml for crates.io crate iconv-compat-win-sys 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ee7d8ab99325b3cf75600821bbcd14fdf6853515ef0b91a96940993649088db4 [INFO] running `Command { std: "docker" "start" "-a" "ee7d8ab99325b3cf75600821bbcd14fdf6853515ef0b91a96940993649088db4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ee7d8ab99325b3cf75600821bbcd14fdf6853515ef0b91a96940993649088db4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee7d8ab99325b3cf75600821bbcd14fdf6853515ef0b91a96940993649088db4", kill_on_drop: false }` [INFO] [stdout] ee7d8ab99325b3cf75600821bbcd14fdf6853515ef0b91a96940993649088db4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c60f5536bb4b1b63e0d3ab3e1b679090a69f01bc5e31ddffaefc2df6db0ff529 [INFO] running `Command { std: "docker" "start" "-a" "c60f5536bb4b1b63e0d3ab3e1b679090a69f01bc5e31ddffaefc2df6db0ff529", kill_on_drop: false }` [INFO] [stderr] Checking dyn_buf v0.1.0 [INFO] [stderr] Checking iconv-compat-win-sys v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 149 | let from_code = CString::new(from_encoding).unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let to_code = CString::new(to_encoding).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Iconv { cd: handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn new(reader: R, from_encoding: &str, to_encoding: &str) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let iconv = Iconv::new(from_encoding, to_encoding)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 236 | | iconv, [INFO] [stdout] 237 | | reader, [INFO] [stdout] 238 | | input: VecBuf::new(MIN_WRITE), [INFO] [stdout] 239 | | output: VecBuf::new(MIN_WRITE), [INFO] [stdout] 240 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn new(writer: W, from_encoding: &str, to_encoding: &str) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let iconv = Iconv::new(from_encoding, to_encoding)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 259 | | iconv, [INFO] [stdout] 260 | | writer, [INFO] [stdout] 261 | | input: VecBuf::new(MIN_WRITE), [INFO] [stdout] 262 | | output: VecBuf::new(MIN_WRITE), [INFO] [stdout] 263 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iconv-compat-win-sys` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 149 | let from_code = CString::new(from_encoding).unwrap(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let to_code = CString::new(to_encoding).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Iconv { cd: handle }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:235:12 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn new(reader: R, from_encoding: &str, to_encoding: &str) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let iconv = Iconv::new(from_encoding, to_encoding)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 236 | | iconv, [INFO] [stdout] 237 | | reader, [INFO] [stdout] 238 | | input: VecBuf::new(MIN_WRITE), [INFO] [stdout] 239 | | output: VecBuf::new(MIN_WRITE), [INFO] [stdout] 240 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:258:12 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn new(writer: W, from_encoding: &str, to_encoding: &str) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | let iconv = Iconv::new(from_encoding, to_encoding)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 259 | | iconv, [INFO] [stdout] 260 | | writer, [INFO] [stdout] 261 | | input: VecBuf::new(MIN_WRITE), [INFO] [stdout] 262 | | output: VecBuf::new(MIN_WRITE), [INFO] [stdout] 263 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iconv-compat-win-sys` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "c60f5536bb4b1b63e0d3ab3e1b679090a69f01bc5e31ddffaefc2df6db0ff529", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c60f5536bb4b1b63e0d3ab3e1b679090a69f01bc5e31ddffaefc2df6db0ff529", kill_on_drop: false }` [INFO] [stdout] c60f5536bb4b1b63e0d3ab3e1b679090a69f01bc5e31ddffaefc2df6db0ff529