[INFO] fetching crate ico-builder 0.1.1... [INFO] checking ico-builder-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ico-builder 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ico-builder 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ico-builder 0.1.1 [INFO] finished tweaking crates.io crate ico-builder 0.1.1 [INFO] tweaked toml for crates.io crate ico-builder 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate ico-builder 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 770cdd2b4f1b82853671cc5f896753df1995c8de780da37b4600a48179897a20 [INFO] running `Command { std: "docker" "start" "-a" "770cdd2b4f1b82853671cc5f896753df1995c8de780da37b4600a48179897a20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "770cdd2b4f1b82853671cc5f896753df1995c8de780da37b4600a48179897a20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "770cdd2b4f1b82853671cc5f896753df1995c8de780da37b4600a48179897a20", kill_on_drop: false }` [INFO] [stdout] 770cdd2b4f1b82853671cc5f896753df1995c8de780da37b4600a48179897a20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff01ea963cfde409df6e2c7645f5dc5b7f6d04a974d39dc6a42614e3eca4bc40 [INFO] running `Command { std: "docker" "start" "-a" "ff01ea963cfde409df6e2c7645f5dc5b7f6d04a974d39dc6a42614e3eca4bc40", kill_on_drop: false }` [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking bytemuck v1.13.1 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking flate2 v1.0.25 [INFO] [stderr] Checking png v0.17.7 [INFO] [stderr] Checking image v0.25.1 [INFO] [stderr] Checking ico-builder v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:31 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn add_source_file(&mut self, source_file: impl AsRef) -> &mut IcoBuilder { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.add_source_files(iter::once(source_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:19 [INFO] [stdout] | [INFO] [stdout] 174 | fn from(value: I) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | IconSizes(value.into_iter().copied().collect::>().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | icon_sources: impl IntoIterator>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> Result> { [INFO] [stdout] 190 | / icon_sources [INFO] [stdout] 191 | | .into_iter() [INFO] [stdout] 192 | | .map(|path| decode_icon(path.as_ref())) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ico-builder` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:31 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn add_source_file(&mut self, source_file: impl AsRef) -> &mut IcoBuilder { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.add_source_files(iter::once(source_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:19 [INFO] [stdout] | [INFO] [stdout] 174 | fn from(value: I) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | IconSizes(value.into_iter().copied().collect::>().into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 188 | icon_sources: impl IntoIterator>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> Result> { [INFO] [stdout] 190 | / icon_sources [INFO] [stdout] 191 | | .into_iter() [INFO] [stdout] 192 | | .map(|path| decode_icon(path.as_ref())) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ico-builder` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "ff01ea963cfde409df6e2c7645f5dc5b7f6d04a974d39dc6a42614e3eca4bc40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff01ea963cfde409df6e2c7645f5dc5b7f6d04a974d39dc6a42614e3eca4bc40", kill_on_drop: false }` [INFO] [stdout] ff01ea963cfde409df6e2c7645f5dc5b7f6d04a974d39dc6a42614e3eca4bc40