[INFO] fetching crate icmp 0.3.0... [INFO] checking icmp-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate icmp 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate icmp 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate icmp 0.3.0 [INFO] finished tweaking crates.io crate icmp 0.3.0 [INFO] tweaked toml for crates.io crate icmp 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bfae40df9fafc34b1646afee87d09c5c673b0b26eb19828732587b223773e92e [INFO] running `Command { std: "docker" "start" "-a" "bfae40df9fafc34b1646afee87d09c5c673b0b26eb19828732587b223773e92e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bfae40df9fafc34b1646afee87d09c5c673b0b26eb19828732587b223773e92e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bfae40df9fafc34b1646afee87d09c5c673b0b26eb19828732587b223773e92e", kill_on_drop: false }` [INFO] [stdout] bfae40df9fafc34b1646afee87d09c5c673b0b26eb19828732587b223773e92e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc40ae5ed702e08983f8e607eba7de6c8656c8b746c1444e26845979ed4c5b48 [INFO] running `Command { std: "docker" "start" "-a" "bc40ae5ed702e08983f8e607eba7de6c8656c8b746c1444e26845979ed4c5b48", kill_on_drop: false }` [INFO] [stderr] Checking icmp v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/compat.rs:79:49 [INFO] [stdout] | [INFO] [stdout] 79 | s_addr: ip.to_be() as libc::uint32_t, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sys/unix.rs:60:54 [INFO] [stdout] | [INFO] [stdout] 60 | let mut peer: libc::sockaddr = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `libc::uint32_t`: Use u32 instead. [INFO] [stdout] --> src/compat.rs:79:49 [INFO] [stdout] | [INFO] [stdout] 79 | s_addr: ip.to_be() as libc::uint32_t, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sys/unix.rs:60:54 [INFO] [stdout] | [INFO] [stdout] 60 | let mut peer: libc::sockaddr = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 45 | let inner = Socket::connect(addr)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(IcmpSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | inner, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/unix.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(Socket { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | fd: fd, [INFO] [stdout] 37 | | family: family, [INFO] [stdout] 38 | | peer: addr.into_inner(), [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `sockaddr` does not permit being left uninitialized [INFO] [stdout] --> src/sys/unix.rs:60:49 [INFO] [stdout] | [INFO] [stdout] 60 | let mut peer: libc::sockaddr = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/socket.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 45 | let inner = Socket::connect(addr)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(IcmpSocket { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | inner, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sys/unix.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(Socket { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | fd: fd, [INFO] [stdout] 37 | | family: family, [INFO] [stdout] 38 | | peer: addr.into_inner(), [INFO] [stdout] 39 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `sockaddr` does not permit being left uninitialized [INFO] [stdout] --> src/sys/unix.rs:60:49 [INFO] [stdout] | [INFO] [stdout] 60 | let mut peer: libc::sockaddr = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icmp` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `icmp` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bc40ae5ed702e08983f8e607eba7de6c8656c8b746c1444e26845979ed4c5b48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc40ae5ed702e08983f8e607eba7de6c8656c8b746c1444e26845979ed4c5b48", kill_on_drop: false }` [INFO] [stdout] bc40ae5ed702e08983f8e607eba7de6c8656c8b746c1444e26845979ed4c5b48