[INFO] fetching crate icepipe 0.5.1... [INFO] checking icepipe-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate icepipe 0.5.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate icepipe 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate icepipe 0.5.1 [INFO] finished tweaking crates.io crate icepipe 0.5.1 [INFO] tweaked toml for crates.io crate icepipe 0.5.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 152 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.24.3 (latest: v0.29.0) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding rustls v0.20.9 (latest: v0.23.12) [INFO] [stderr] Adding rustls-native-certs v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding stun v0.4.4 (latest: v0.6.0) [INFO] [stderr] Adding tokio-rustls v0.23.4 (latest: v0.26.0) [INFO] [stderr] Adding tokio-tungstenite v0.18.0 (latest: v0.23.1) [INFO] [stderr] Adding tungstenite v0.18.0 (latest: v0.24.0) [INFO] [stderr] Adding turn v0.6.1 (latest: v0.8.0) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webrtc-ice v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding webrtc-mdns v0.5.2 (latest: v0.7.0) [INFO] [stderr] Adding webrtc-sctp v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding webrtc-util v0.7.0 (latest: v0.9.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding x25519-dalek v1.2.0 (latest: v2.0.1) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7694978c804f500c2fd68bd13d26a90a8e8e037397f7df87dcff55b5d691034c [INFO] running `Command { std: "docker" "start" "-a" "7694978c804f500c2fd68bd13d26a90a8e8e037397f7df87dcff55b5d691034c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7694978c804f500c2fd68bd13d26a90a8e8e037397f7df87dcff55b5d691034c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7694978c804f500c2fd68bd13d26a90a8e8e037397f7df87dcff55b5d691034c", kill_on_drop: false }` [INFO] [stdout] 7694978c804f500c2fd68bd13d26a90a8e8e037397f7df87dcff55b5d691034c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb46fa0478c0c63c558e187afa6f02124a39ac4054d6c126a8fb85a2cbb592b5 [INFO] running `Command { std: "docker" "start" "-a" "bb46fa0478c0c63c558e187afa6f02124a39ac4054d6c126a8fb85a2cbb592b5", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Checking untrusted v0.7.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling webrtc-util v0.7.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling rustls v0.20.9 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking crc-catalog v2.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ring v0.17.8 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking crc v3.2.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking waitgroup v0.1.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking x25519-dalek v1.2.0 [INFO] [stderr] Checking webpki v0.22.4 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-rustls v0.23.4 [INFO] [stderr] Checking tungstenite v0.18.0 [INFO] [stderr] Checking stun v0.4.4 [INFO] [stderr] Checking webrtc-mdns v0.5.2 [INFO] [stderr] Checking webrtc-sctp v0.7.0 [INFO] [stderr] Checking tokio-tungstenite v0.18.0 [INFO] [stderr] Checking turn v0.6.1 [INFO] [stderr] Checking webrtc-ice v0.9.1 [INFO] [stderr] Checking icepipe v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agreement.rs:56:50 [INFO] [stdout] | [INFO] [stdout] 56 | .map_err(|e| AgreementError::BadAuth(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:133:27 [INFO] [stdout] | [INFO] [stdout] 132 | fn from(value: IceError) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | Self::StreamError(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto_stream.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new(basekey: &[u8], dialer: bool, underlying: S) -> Chacha20Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(Chacha20Stream { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | sealing_key, [INFO] [stdout] 95 | | opening_key, [INFO] [stdout] 96 | | underlying, [INFO] [stdout] 97 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ice.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 173 | let (exchange, candidates_tx) = CandidateExchange::new(signalling).await?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | agent.on_candidate(Box::new(move |c| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let send = candidates_tx.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Box::pin(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 177 | | if let Some(c) = c { [INFO] [stdout] 178 | | send.send(c.marshal()).await.unwrap(); [INFO] [stdout] 179 | | } [INFO] [stdout] 180 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icepipe` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/agreement.rs:56:50 [INFO] [stdout] | [INFO] [stdout] 56 | .map_err(|e| AgreementError::BadAuth(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connect.rs:133:27 [INFO] [stdout] | [INFO] [stdout] 132 | fn from(value: IceError) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | Self::StreamError(value.into()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto_stream.rs:93:12 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn new(basekey: &[u8], dialer: bool, underlying: S) -> Chacha20Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | Ok(Chacha20Stream { [INFO] [stdout] | ____________^ [INFO] [stdout] 94 | | sealing_key, [INFO] [stdout] 95 | | opening_key, [INFO] [stdout] 96 | | underlying, [INFO] [stdout] 97 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ice.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 173 | let (exchange, candidates_tx) = CandidateExchange::new(signalling).await?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | agent.on_candidate(Box::new(move |c| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let send = candidates_tx.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Box::pin(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 177 | | if let Some(c) = c { [INFO] [stdout] 178 | | send.send(c.marshal()).await.unwrap(); [INFO] [stdout] 179 | | } [INFO] [stdout] 180 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icepipe` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "bb46fa0478c0c63c558e187afa6f02124a39ac4054d6c126a8fb85a2cbb592b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb46fa0478c0c63c558e187afa6f02124a39ac4054d6c126a8fb85a2cbb592b5", kill_on_drop: false }` [INFO] [stdout] bb46fa0478c0c63c558e187afa6f02124a39ac4054d6c126a8fb85a2cbb592b5