[INFO] fetching crate iceberg-rust-spec 0.5.7... [INFO] checking iceberg-rust-spec-0.5.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iceberg-rust-spec 0.5.7 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate iceberg-rust-spec 0.5.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iceberg-rust-spec 0.5.7 [INFO] finished tweaking crates.io crate iceberg-rust-spec 0.5.7 [INFO] tweaked toml for crates.io crate iceberg-rust-spec 0.5.7 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 240 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive-getters v0.3.0 (latest: v0.5.0) [INFO] [stderr] Adding derive_builder v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding object_store v0.10.2 (latest: v0.11.0) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (latest: v0.8.0) [INFO] [stderr] Adding snafu v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding typed-builder v0.19.1 (latest: v0.20.0) [INFO] [stderr] Adding typed-builder-macro v0.19.1 (latest: v0.20.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d80c1c33dd6ff5affd85ed281164377b3fb529ce8c8a9f5e98694f19c89a00e [INFO] running `Command { std: "docker" "start" "-a" "3d80c1c33dd6ff5affd85ed281164377b3fb529ce8c8a9f5e98694f19c89a00e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d80c1c33dd6ff5affd85ed281164377b3fb529ce8c8a9f5e98694f19c89a00e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d80c1c33dd6ff5affd85ed281164377b3fb529ce8c8a9f5e98694f19c89a00e", kill_on_drop: false }` [INFO] [stdout] 3d80c1c33dd6ff5affd85ed281164377b3fb529ce8c8a9f5e98694f19c89a00e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8236fa570c5aca091bea7ae0a5dd48ea2dfe3b3215fde554004d038ffd0e936a [INFO] running `Command { std: "docker" "start" "-a" "8236fa570c5aca091bea7ae0a5dd48ea2dfe3b3215fde554004d038ffd0e936a", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling bigdecimal v0.4.5 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking atomic v0.6.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling typed-builder-macro v0.19.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking dary_heap v0.3.6 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking murmur3 v0.5.2 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking typed-builder v0.19.1 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking libflate_lz77 v2.1.0 [INFO] [stderr] Checking libflate v2.1.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling derive-getters v0.3.0 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking quick-xml v0.36.1 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking apache-avro v0.17.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking iceberg-rust-spec v0.5.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/schema.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 22 | let fields = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(ArrowSchema { fields, metadata }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/schema.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut ids = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let fields = value [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(StructType::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(reader: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let reader = AvroReader::new(reader)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let schema: Schema = match format_version { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | reader: reader [INFO] [stdout] 105 | | .zip(repeat(Arc::new((schema, partition_spec, format_version)))) [INFO] [stdout] 106 | | .map(avro_value_to_manifest_entry), [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:166:12 [INFO] [stdout] | [INFO] [stdout] 129 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let mut avro_writer = AvroWriter::new(schema, writer); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(ManifestWriter(avro_writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn into_inner(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | Ok(self.0.into_inner()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:572:24 [INFO] [stdout] | [INFO] [stdout] 572 | value: (*value).clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:589:12 [INFO] [stdout] | [INFO] [stdout] 584 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | let vec: Vec> = Vec::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | Ok(AvroMap(HashMap::from_iter( [INFO] [stdout] | ____________^ [INFO] [stdout] 590 | | vec.into_iter().map(|x| (x.key, x.value)), [INFO] [stdout] 591 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest_list.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 46 | reader: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | reader: AvroReader::new(reader)? [INFO] [stdout] 51 | | .zip(repeat(table_metadata)) [INFO] [stdout] 52 | | .map(avro_value_to_manifest_file), [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/schema.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 66 | fn try_from(value: SchemaV2) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Ok(Schema { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | schema_id: value.schema_id, [INFO] [stdout] 69 | | identifier_field_ids: value.identifier_field_ids, [INFO] [stdout] 70 | | fields: value.fields, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/schema.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn try_from(value: SchemaV1) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Ok(Schema { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | schema_id: value.schema_id.unwrap_or(0), [INFO] [stdout] 80 | | identifier_field_ids: value.identifier_field_ids, [INFO] [stdout] 81 | | fields: value.fields, [INFO] [stdout] 82 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:485:16 [INFO] [stdout] | [INFO] [stdout] 464 | fn try_from(value: TableMetadataV2) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | let schemas = HashMap::from_iter( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | Ok(TableMetadata { [INFO] [stdout] | ________________^ [INFO] [stdout] 486 | | format_version: FormatVersion::V2, [INFO] [stdout] 487 | | table_uuid: value.table_uuid, [INFO] [stdout] 488 | | location: value.location, [INFO] [stdout] ... | [INFO] [stdout] 517 | | refs, [INFO] [stdout] 518 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:474:38 [INFO] [stdout] | [INFO] [stdout] 474 | .map(|schema| Ok((schema.schema_id, schema.try_into()?))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:560:16 [INFO] [stdout] | [INFO] [stdout] 524 | fn try_from(value: TableMetadataV1) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 525 | let schemas = value [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | Ok(TableMetadata { [INFO] [stdout] | ________________^ [INFO] [stdout] 561 | | format_version: FormatVersion::V1, [INFO] [stdout] 562 | | table_uuid: value.table_uuid.unwrap_or_default(), [INFO] [stdout] 563 | | location: value.location, [INFO] [stdout] ... | [INFO] [stdout] 620 | | )]), [INFO] [stdout] 621 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:528:36 [INFO] [stdout] | [INFO] [stdout] 527 | .map(|schemas| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 528 | Ok::<_, Error>(HashMap::from_iter( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 529 | | schemas [INFO] [stdout] 530 | | .into_iter() [INFO] [stdout] 531 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 536 | | .into_iter(), [INFO] [stdout] 537 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:533:36 [INFO] [stdout] | [INFO] [stdout] 532 | ... .map(|(i, schema)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | ... Ok((schema.schema_id.unwrap_or(i as i32), schema.try_into()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:540:26 [INFO] [stdout] | [INFO] [stdout] 524 | fn try_from(value: TableMetadataV1) -> Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 540 | Some(Ok(HashMap::from_iter(vec![( [INFO] [stdout] | __________________________^ [INFO] [stdout] 541 | | value.schema.schema_id.unwrap_or(0), [INFO] [stdout] 542 | | value.schema.try_into().ok()?, [INFO] [stdout] 543 | | )]))) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:634:26 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | schemas: v.schemas.into_values().map(|x| x.into()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:636:34 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | partition_specs: v.partition_specs.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:641:33 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 641 | snapshots: Some(v.snapshots.into_values().map(|x| x.into()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:644:30 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 644 | sort_orders: v.sort_orders.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:659:25 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | schema: v.schemas.get(&v.current_schema_id).unwrap().clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:660:26 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | schemas: Some(v.schemas.into_values().map(|x| x.into()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:667:39 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 667 | partition_specs: Some(v.partition_specs.into_values().collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:672:33 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 672 | snapshots: Some(v.snapshots.into_values().map(|x| x.into()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:675:35 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 675 | sort_orders: Some(v.sort_orders.into_values().collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/types.rs:237:20 [INFO] [stdout] | [INFO] [stdout] 218 | fn visit_map(self, mut map: V) -> std::result::Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let mut fields = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | let fields: Vec = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Ok(StructType::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/values.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | Ok(( [INFO] [stdout] | ____________________^ [INFO] [stdout] 170 | | partition_field.name().clone(), [INFO] [stdout] 171 | | field.field_type.tranform(partition_field.transform())?, [INFO] [stdout] 172 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/values.rs:260:23 [INFO] [stdout] | [INFO] [stdout] 230 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Box::leak(vec![].into_boxed_slice()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 195 | fn try_from(value: ViewMetadataV1) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Ok(GeneralViewMetadata { [INFO] [stdout] | ________________^ [INFO] [stdout] 197 | | view_uuid: value.view_uuid, [INFO] [stdout] 198 | | format_version: FormatVersion::V1, [INFO] [stdout] 199 | | location: value.location, [INFO] [stdout] ... | [INFO] [stdout] 210 | | ), [INFO] [stdout] 211 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | .map(|x| Ok((x.schema_id, x.try_into()?))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:222:27 [INFO] [stdout] | [INFO] [stdout] 216 | fn from(value: GeneralViewMetadata) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | versions: value.versions.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:229:26 [INFO] [stdout] | [INFO] [stdout] 216 | fn from(value: GeneralViewMetadata) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | schemas: value.schemas.into_values().map(Into::into).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 32 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/schema.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 22 | let fields = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | Ok(ArrowSchema { fields, metadata }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/schema.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 47 | let mut ids = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let fields = value [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(StructType::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new(reader: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let reader = AvroReader::new(reader)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let schema: Schema = match format_version { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | reader: reader [INFO] [stdout] 105 | | .zip(repeat(Arc::new((schema, partition_spec, format_version)))) [INFO] [stdout] 106 | | .map(avro_value_to_manifest_entry), [INFO] [stdout] 107 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:166:12 [INFO] [stdout] | [INFO] [stdout] 129 | writer: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let mut avro_writer = AvroWriter::new(schema, writer); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | Ok(ManifestWriter(avro_writer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iceberg-rust-spec` (lib) due to 33 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn into_inner(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | Ok(self.0.into_inner()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:572:24 [INFO] [stdout] | [INFO] [stdout] 572 | value: (*value).clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest.rs:589:12 [INFO] [stdout] | [INFO] [stdout] 584 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 588 | let vec: Vec> = Vec::deserialize(deserializer)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 589 | Ok(AvroMap(HashMap::from_iter( [INFO] [stdout] | ____________^ [INFO] [stdout] 590 | | vec.into_iter().map(|x| (x.key, x.value)), [INFO] [stdout] 591 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/manifest_list.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 46 | reader: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 50 | | reader: AvroReader::new(reader)? [INFO] [stdout] 51 | | .zip(repeat(table_metadata)) [INFO] [stdout] 52 | | .map(avro_value_to_manifest_file), [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/schema.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 66 | fn try_from(value: SchemaV2) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | Ok(Schema { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | schema_id: value.schema_id, [INFO] [stdout] 69 | | identifier_field_ids: value.identifier_field_ids, [INFO] [stdout] 70 | | fields: value.fields, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/schema.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn try_from(value: SchemaV1) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | Ok(Schema { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | schema_id: value.schema_id.unwrap_or(0), [INFO] [stdout] 80 | | identifier_field_ids: value.identifier_field_ids, [INFO] [stdout] 81 | | fields: value.fields, [INFO] [stdout] 82 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:485:16 [INFO] [stdout] | [INFO] [stdout] 464 | fn try_from(value: TableMetadataV2) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | let schemas = HashMap::from_iter( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 485 | Ok(TableMetadata { [INFO] [stdout] | ________________^ [INFO] [stdout] 486 | | format_version: FormatVersion::V2, [INFO] [stdout] 487 | | table_uuid: value.table_uuid, [INFO] [stdout] 488 | | location: value.location, [INFO] [stdout] ... | [INFO] [stdout] 517 | | refs, [INFO] [stdout] 518 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:474:38 [INFO] [stdout] | [INFO] [stdout] 474 | .map(|schema| Ok((schema.schema_id, schema.try_into()?))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:560:16 [INFO] [stdout] | [INFO] [stdout] 524 | fn try_from(value: TableMetadataV1) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 525 | let schemas = value [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 560 | Ok(TableMetadata { [INFO] [stdout] | ________________^ [INFO] [stdout] 561 | | format_version: FormatVersion::V1, [INFO] [stdout] 562 | | table_uuid: value.table_uuid.unwrap_or_default(), [INFO] [stdout] 563 | | location: value.location, [INFO] [stdout] ... | [INFO] [stdout] 620 | | )]), [INFO] [stdout] 621 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:528:36 [INFO] [stdout] | [INFO] [stdout] 527 | .map(|schemas| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 528 | Ok::<_, Error>(HashMap::from_iter( [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 529 | | schemas [INFO] [stdout] 530 | | .into_iter() [INFO] [stdout] 531 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 536 | | .into_iter(), [INFO] [stdout] 537 | | )) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:533:36 [INFO] [stdout] | [INFO] [stdout] 532 | ... .map(|(i, schema)| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | ... Ok((schema.schema_id.unwrap_or(i as i32), schema.try_into()?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:540:26 [INFO] [stdout] | [INFO] [stdout] 524 | fn try_from(value: TableMetadataV1) -> Result { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 540 | Some(Ok(HashMap::from_iter(vec![( [INFO] [stdout] | __________________________^ [INFO] [stdout] 541 | | value.schema.schema_id.unwrap_or(0), [INFO] [stdout] 542 | | value.schema.try_into().ok()?, [INFO] [stdout] 543 | | )]))) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:634:26 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 634 | schemas: v.schemas.into_values().map(|x| x.into()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:636:34 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | partition_specs: v.partition_specs.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:641:33 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 641 | snapshots: Some(v.snapshots.into_values().map(|x| x.into()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:644:30 [INFO] [stdout] | [INFO] [stdout] 626 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 644 | sort_orders: v.sort_orders.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:659:25 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | schema: v.schemas.get(&v.current_schema_id).unwrap().clone().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:660:26 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 660 | schemas: Some(v.schemas.into_values().map(|x| x.into()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:667:39 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 667 | partition_specs: Some(v.partition_specs.into_values().collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:672:33 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 672 | snapshots: Some(v.snapshots.into_values().map(|x| x.into()).collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:675:35 [INFO] [stdout] | [INFO] [stdout] 652 | fn from(v: TableMetadata) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 675 | sort_orders: Some(v.sort_orders.into_values().collect()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/table_metadata.rs:1323:13 [INFO] [stdout] | [INFO] [stdout] 1320 | let desered: Result = serde_json::from_str(&metadata); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1323 | desered.unwrap_err().to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/types.rs:237:20 [INFO] [stdout] | [INFO] [stdout] 218 | fn visit_map(self, mut map: V) -> std::result::Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let mut fields = None; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | let fields: Vec = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 237 | Ok(StructType::new(fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/values.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | Ok(( [INFO] [stdout] | ____________________^ [INFO] [stdout] 170 | | partition_field.name().clone(), [INFO] [stdout] 171 | | field.field_type.tranform(partition_field.transform())?, [INFO] [stdout] 172 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/values.rs:260:23 [INFO] [stdout] | [INFO] [stdout] 230 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Box::leak(vec![].into_boxed_slice()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:196:16 [INFO] [stdout] | [INFO] [stdout] 195 | fn try_from(value: ViewMetadataV1) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | Ok(GeneralViewMetadata { [INFO] [stdout] | ________________^ [INFO] [stdout] 197 | | view_uuid: value.view_uuid, [INFO] [stdout] 198 | | format_version: FormatVersion::V1, [INFO] [stdout] 199 | | location: value.location, [INFO] [stdout] ... | [INFO] [stdout] 210 | | ), [INFO] [stdout] 211 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | .map(|x| Ok((x.schema_id, x.try_into()?))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:222:27 [INFO] [stdout] | [INFO] [stdout] 216 | fn from(value: GeneralViewMetadata) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | versions: value.versions.into_values().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/spec/view_metadata.rs:229:26 [INFO] [stdout] | [INFO] [stdout] 216 | fn from(value: GeneralViewMetadata) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | schemas: value.schemas.into_values().map(Into::into).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 33 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iceberg-rust-spec` (lib test) due to 34 previous errors [INFO] running `Command { std: "docker" "inspect" "8236fa570c5aca091bea7ae0a5dd48ea2dfe3b3215fde554004d038ffd0e936a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8236fa570c5aca091bea7ae0a5dd48ea2dfe3b3215fde554004d038ffd0e936a", kill_on_drop: false }` [INFO] [stdout] 8236fa570c5aca091bea7ae0a5dd48ea2dfe3b3215fde554004d038ffd0e936a