[INFO] fetching crate iceberg-rust 0.5.7... [INFO] checking iceberg-rust-0.5.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate iceberg-rust 0.5.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate iceberg-rust 0.5.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate iceberg-rust 0.5.7 [INFO] finished tweaking crates.io crate iceberg-rust 0.5.7 [INFO] tweaked toml for crates.io crate iceberg-rust 0.5.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 305 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bytecheck v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding bytecheck_derive v0.6.12 (latest: v0.7.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding darling v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (latest: v0.20.10) [INFO] [stderr] Adding derive-getters v0.3.0 (latest: v0.5.0) [INFO] [stderr] Adding derive_builder v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_core v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding derive_builder_macro v0.12.0 (latest: v0.20.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding integer-encoding v3.0.4 (latest: v4.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding object_store v0.10.2 (latest: v0.11.0) [INFO] [stderr] Adding ordered-float v2.10.1 (latest: v4.2.2) [INFO] [stderr] Adding ptr_meta v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding ptr_meta_derive v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustls-native-certs v0.7.3 (latest: v0.8.0) [INFO] [stderr] Adding snafu v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.7.5 (latest: v0.8.4) [INFO] [stderr] Adding sqlparser v0.47.0 (latest: v0.50.0) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding typed-builder v0.19.1 (latest: v0.20.0) [INFO] [stderr] Adding typed-builder-macro v0.19.1 (latest: v0.20.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding zstd-sys v2.0.12+zstd.1.5.6 (latest: v2.0.13+zstd.1.5.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9363b072042fe1004f6b17e8ce6c64446bb461ea198ee20a6b340a536dc58b99 [INFO] running `Command { std: "docker" "start" "-a" "9363b072042fe1004f6b17e8ce6c64446bb461ea198ee20a6b340a536dc58b99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9363b072042fe1004f6b17e8ce6c64446bb461ea198ee20a6b340a536dc58b99", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9363b072042fe1004f6b17e8ce6c64446bb461ea198ee20a6b340a536dc58b99", kill_on_drop: false }` [INFO] [stdout] 9363b072042fe1004f6b17e8ce6c64446bb461ea198ee20a6b340a536dc58b99 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bc4bda25c509c9bc4086f5142964bbd19a7c2549dedcfab4d8e8b6d5a0612ea [INFO] running `Command { std: "docker" "start" "-a" "8bc4bda25c509c9bc4086f5142964bbd19a7c2549dedcfab4d8e8b6d5a0612ea", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking arrow-schema v52.2.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling bigdecimal v0.4.5 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking atomic v0.6.0 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Checking quick-xml v0.36.1 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling typed-builder-macro v0.19.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking dary_heap v0.3.6 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Compiling snap v1.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking typed-builder v0.19.1 [INFO] [stderr] Checking integer-encoding v3.0.4 [INFO] [stderr] Checking regex-lite v0.1.6 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking libflate_lz77 v2.1.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking thrift v0.17.0 [INFO] [stderr] Checking libflate v2.1.0 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling zstd-sys v2.0.12+zstd.1.5.6 [INFO] [stderr] Checking ordered-float v4.2.2 [INFO] [stderr] Compiling sqlparser_derive v0.2.2 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v52.2.0 [INFO] [stderr] Compiling derive-getters v0.3.0 [INFO] [stderr] Checking murmur3 v0.5.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling seq-macro v0.3.5 [INFO] [stderr] Checking sqlparser v0.47.0 [INFO] [stderr] Checking apache-avro v0.17.0 [INFO] [stderr] Checking arrow-data v52.2.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking arrow-array v52.2.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking arrow-select v52.2.0 [INFO] [stderr] Checking arrow-row v52.2.0 [INFO] [stderr] Checking arrow-arith v52.2.0 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Checking arrow-cast v52.2.0 [INFO] [stderr] Checking arrow-ord v52.2.0 [INFO] [stderr] Checking arrow-string v52.2.0 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking arrow-ipc v52.2.0 [INFO] [stderr] Checking arrow-json v52.2.0 [INFO] [stderr] Checking arrow-csv v52.2.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking arrow v52.2.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking iceberg-rust-spec v0.5.7 [INFO] [stderr] Checking parquet v52.2.0 [INFO] [stderr] Checking iceberg-rust v0.5.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:74:41 [INFO] [stdout] | [INFO] [stdout] 74 | transform_arrow(array.clone(), field.transform()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:79:46 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|x| distinct_values(x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:109:36 [INFO] [stdout] | [INFO] [stdout] 108 | ... let res = eq(&StringArray::new_scalar(&x), value)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ... Ok((Value::String(x), res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:116:29 [INFO] [stdout] | [INFO] [stdout] 115 | |acc, predicates| { [INFO] [stdout] | --- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / iproduct!(acc, predicates?.iter()) [INFO] [stdout] 117 | | .map(|((mut values, x), (value, y))| { [INFO] [stdout] 118 | | values.push(value.clone()); [INFO] [stdout] 119 | | Ok((values, and(&x, y)?)) [INFO] [stdout] 120 | | }) [INFO] [stdout] 121 | | .filter_ok(|x| x.1.true_count() != 0) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:119:40 [INFO] [stdout] | [INFO] [stdout] 117 | ... .map(|((mut values, x), (value, y))| { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | ... values.push(value.clone()); [INFO] [stdout] 119 | ... Ok((values, and(&x, y)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:127:28 [INFO] [stdout] | [INFO] [stdout] 126 | .map(|(values, predicate)| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok((values, filter_record_batch(&record_batch, &predicate)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:142:77 [INFO] [stdout] | [INFO] [stdout] 142 | ... |err| ArrowError::ExternalError(Box::new(err)), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:151:74 [INFO] [stdout] | [INFO] [stdout] 151 | ... .map_err(|err| ArrowError::ExternalError(Box::new(err)))?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write.rs:179:68 [INFO] [stdout] | [INFO] [stdout] 179 | .map_err(|err| ArrowError::from_external_error(err.into()))? [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write.rs:221:50 [INFO] [stdout] | [INFO] [stdout] 221 | .map_err(|err| ArrowError::ExternalError(Box::new(err))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 95 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(TableMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | format_version: Default::default(), [INFO] [stdout] 106 | | table_uuid: Uuid::new_v4(), [INFO] [stdout] 107 | | location: self [INFO] [stdout] ... | [INFO] [stdout] 134 | | refs: HashMap::new(), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 182 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(ViewMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 184 | | view_uuid: Uuid::new_v4(), [INFO] [stdout] 185 | | format_version: Default::default(), [INFO] [stdout] 186 | | location: self [INFO] [stdout] ... | [INFO] [stdout] 193 | | properties: self.properties, [INFO] [stdout] 194 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 200 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(MaterializedViewMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | view_uuid: Uuid::new_v4(), [INFO] [stdout] 203 | | format_version: Default::default(), [INFO] [stdout] 204 | | location: self [INFO] [stdout] ... | [INFO] [stdout] 211 | | properties: self.properties, [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:323:13 [INFO] [stdout] | [INFO] [stdout] 320 | fn into(self) -> (CreateView, CreateTable) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | / CreateView { [INFO] [stdout] 324 | | name: self.name.clone(), [INFO] [stdout] 325 | | location: self.location.clone(), [INFO] [stdout] 326 | | schema: self.schema.clone(), [INFO] [stdout] 327 | | view_version: self.view_version, [INFO] [stdout] 328 | | properties: self.properties, [INFO] [stdout] 329 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:330:13 [INFO] [stdout] | [INFO] [stdout] 320 | fn into(self) -> (CreateView, CreateTable) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | / CreateTable { [INFO] [stdout] 331 | | name: storage_table, [INFO] [stdout] 332 | | location: self.location, [INFO] [stdout] 333 | | schema: self.schema, [INFO] [stdout] ... | [INFO] [stdout] 337 | | properties: self.table_properties, [INFO] [stdout] 338 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 107 | fn from(value: Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ArrowError::from_external_error(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/mod.rs:191:20 [INFO] [stdout] | [INFO] [stdout] 181 | let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let reader = ManifestReader::new(bytes)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Ok(stream::iter(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:243:38 [INFO] [stdout] | [INFO] [stdout] 230 | ... let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | ... let datafiles = datafiles.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | ... .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:271:38 [INFO] [stdout] | [INFO] [stdout] 258 | ... let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | ... let datafiles = datafiles.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | ... .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:417:30 [INFO] [stdout] | [INFO] [stdout] 402 | let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | let datafiles = datafiles.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:740:5 [INFO] [stdout] | [INFO] [stdout] 737 | partition_values: impl Iterator, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 740 | / partition_values [INFO] [stdout] 741 | | .filter(|value| { [INFO] [stdout] 742 | | partition_spec [INFO] [stdout] 743 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 808 | | }) [INFO] [stdout] 809 | | .map(Clone::clone) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:74:41 [INFO] [stdout] | [INFO] [stdout] 74 | transform_arrow(array.clone(), field.transform()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:79:46 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|x| distinct_values(x.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:109:36 [INFO] [stdout] | [INFO] [stdout] 108 | ... let res = eq(&StringArray::new_scalar(&x), value)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | ... Ok((Value::String(x), res)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:116:29 [INFO] [stdout] | [INFO] [stdout] 115 | |acc, predicates| { [INFO] [stdout] | --- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / iproduct!(acc, predicates?.iter()) [INFO] [stdout] 117 | | .map(|((mut values, x), (value, y))| { [INFO] [stdout] 118 | | values.push(value.clone()); [INFO] [stdout] 119 | | Ok((values, and(&x, y)?)) [INFO] [stdout] 120 | | }) [INFO] [stdout] 121 | | .filter_ok(|x| x.1.true_count() != 0) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:119:40 [INFO] [stdout] | [INFO] [stdout] 117 | ... .map(|((mut values, x), (value, y))| { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | ... values.push(value.clone()); [INFO] [stdout] 119 | ... Ok((values, and(&x, y)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:127:28 [INFO] [stdout] | [INFO] [stdout] 126 | .map(|(values, predicate)| { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok((values, filter_record_batch(&record_batch, &predicate)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:142:77 [INFO] [stdout] | [INFO] [stdout] 142 | ... |err| ArrowError::ExternalError(Box::new(err)), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:151:74 [INFO] [stdout] | [INFO] [stdout] 151 | ... .map_err(|err| ArrowError::ExternalError(Box::new(err)))?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/partition.rs:313:60 [INFO] [stdout] | [INFO] [stdout] 313 | .then(|s| async move { s.1.collect::>().await }) [INFO] [stdout] | - ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write.rs:179:68 [INFO] [stdout] | [INFO] [stdout] 179 | .map_err(|err| ArrowError::from_external_error(err.into()))? [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arrow/write.rs:221:50 [INFO] [stdout] | [INFO] [stdout] 221 | .map_err(|err| ArrowError::ExternalError(Box::new(err))) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iceberg-rust` (lib) due to 22 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:104:12 [INFO] [stdout] | [INFO] [stdout] 95 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Ok(TableMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 105 | | format_version: Default::default(), [INFO] [stdout] 106 | | table_uuid: Uuid::new_v4(), [INFO] [stdout] 107 | | location: self [INFO] [stdout] ... | [INFO] [stdout] 134 | | refs: HashMap::new(), [INFO] [stdout] 135 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:183:12 [INFO] [stdout] | [INFO] [stdout] 182 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(ViewMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 184 | | view_uuid: Uuid::new_v4(), [INFO] [stdout] 185 | | format_version: Default::default(), [INFO] [stdout] 186 | | location: self [INFO] [stdout] ... | [INFO] [stdout] 193 | | properties: self.properties, [INFO] [stdout] 194 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 200 | fn try_into(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | Ok(MaterializedViewMetadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | view_uuid: Uuid::new_v4(), [INFO] [stdout] 203 | | format_version: Default::default(), [INFO] [stdout] 204 | | location: self [INFO] [stdout] ... | [INFO] [stdout] 211 | | properties: self.properties, [INFO] [stdout] 212 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:323:13 [INFO] [stdout] | [INFO] [stdout] 320 | fn into(self) -> (CreateView, CreateTable) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 323 | / CreateView { [INFO] [stdout] 324 | | name: self.name.clone(), [INFO] [stdout] 325 | | location: self.location.clone(), [INFO] [stdout] 326 | | schema: self.schema.clone(), [INFO] [stdout] 327 | | view_version: self.view_version, [INFO] [stdout] 328 | | properties: self.properties, [INFO] [stdout] 329 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/catalog/create.rs:330:13 [INFO] [stdout] | [INFO] [stdout] 320 | fn into(self) -> (CreateView, CreateTable) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | / CreateTable { [INFO] [stdout] 331 | | name: storage_table, [INFO] [stdout] 332 | | location: self.location, [INFO] [stdout] 333 | | schema: self.schema, [INFO] [stdout] ... | [INFO] [stdout] 337 | | properties: self.table_properties, [INFO] [stdout] 338 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:108:41 [INFO] [stdout] | [INFO] [stdout] 107 | fn from(value: Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ArrowError::from_external_error(Box::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/mod.rs:191:20 [INFO] [stdout] | [INFO] [stdout] 181 | let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let reader = ManifestReader::new(bytes)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | Ok(stream::iter(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:243:38 [INFO] [stdout] | [INFO] [stdout] 230 | ... let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | ... let datafiles = datafiles.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 243 | ... .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:271:38 [INFO] [stdout] | [INFO] [stdout] 258 | ... let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | ... let datafiles = datafiles.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | ... .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:417:30 [INFO] [stdout] | [INFO] [stdout] 402 | let object_store = object_store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | let datafiles = datafiles.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/transaction/operation.rs:740:5 [INFO] [stdout] | [INFO] [stdout] 737 | partition_values: impl Iterator, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 740 | / partition_values [INFO] [stdout] 741 | | .filter(|value| { [INFO] [stdout] 742 | | partition_spec [INFO] [stdout] 743 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 808 | | }) [INFO] [stdout] 809 | | .map(Clone::clone) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 22 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `iceberg-rust` (lib test) due to 23 previous errors [INFO] running `Command { std: "docker" "inspect" "8bc4bda25c509c9bc4086f5142964bbd19a7c2549dedcfab4d8e8b6d5a0612ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bc4bda25c509c9bc4086f5142964bbd19a7c2549dedcfab4d8e8b6d5a0612ea", kill_on_drop: false }` [INFO] [stdout] 8bc4bda25c509c9bc4086f5142964bbd19a7c2549dedcfab4d8e8b6d5a0612ea