[INFO] fetching crate icbiadb 0.3.7... [INFO] checking icbiadb-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate icbiadb 0.3.7 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate icbiadb 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate icbiadb 0.3.7 [INFO] finished tweaking crates.io crate icbiadb 0.3.7 [INFO] tweaked toml for crates.io crate icbiadb 0.3.7 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate icbiadb 0.3.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54e2963a64ce201500ce0af5b023e578ce18a8183c5327537e6ee5a0c237d52e [INFO] running `Command { std: "docker" "start" "-a" "54e2963a64ce201500ce0af5b023e578ce18a8183c5327537e6ee5a0c237d52e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54e2963a64ce201500ce0af5b023e578ce18a8183c5327537e6ee5a0c237d52e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54e2963a64ce201500ce0af5b023e578ce18a8183c5327537e6ee5a0c237d52e", kill_on_drop: false }` [INFO] [stdout] 54e2963a64ce201500ce0af5b023e578ce18a8183c5327537e6ee5a0c237d52e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 18fb488f36cd0861b25d03e5db30423cc15bb51723b1f3e8e8c00946796fc19e [INFO] running `Command { std: "docker" "start" "-a" "18fb488f36cd0861b25d03e5db30423cc15bb51723b1f3e8e8c00946796fc19e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking icbiadb v0.3.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `ICBIA_STAMP` is never used [INFO] [stdout] --> src/byte_size.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | pub const ICBIA_STAMP: usize = 5; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 34 | let f = std::fs::OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let mut reader = fio::reader::Reader::new(BufReader::new(f)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(KvDb:: { [INFO] [stdout] | ________^ [INFO] [stdout] 50 | | file_name: file_name.to_string(), [INFO] [stdout] 51 | | records: reader.read_kv_records()?, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn read_from(read: R) -> std::io::Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let mut reader = fio::reader::Reader::new(BufReader::new(read)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(KvDb:: { [INFO] [stdout] | ________^ [INFO] [stdout] 72 | | file_name: String::new(), [INFO] [stdout] 73 | | records: reader.read_kv_records()?, [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 389 | fn filter(&self, cb: F) -> Vec<(&BvString, &BvObject)> [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | (&self.records).into_iter().filter(|t| cb(*t)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 402 | fn starts_with>(&self, key_part: S) -> Vec<(&BvString, &BvObject)> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | let k_part = key_part.as_ref().as_bytes(); [INFO] [stdout] 404 | / (&self.records) [INFO] [stdout] 405 | | .into_iter() [INFO] [stdout] 406 | | .filter_map(|(k, v)| { [INFO] [stdout] 407 | | if k.starts_with(k_part) { [INFO] [stdout] ... | [INFO] [stdout] 411 | | None [INFO] [stdout] 412 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 416 | fn ends_with>(&self, key_part: S) -> Vec<(&BvString, &BvObject)> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | / (&self.records) [INFO] [stdout] 418 | | .into_iter() [INFO] [stdout] 419 | | .filter_map(|(k, v)| { [INFO] [stdout] 420 | | if k.ends_with(key_part.as_ref().as_bytes()) { [INFO] [stdout] ... | [INFO] [stdout] 424 | | None [INFO] [stdout] 425 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:430:9 [INFO] [stdout] | [INFO] [stdout] 429 | fn contains>(&self, key_part: S) -> Vec<(&BvString, &BvObject)> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | / (&self.records) [INFO] [stdout] 431 | | .into_iter() [INFO] [stdout] 432 | | .filter_map(|(k, v)| { [INFO] [stdout] 433 | | if k.contains(key_part.as_ref()) { [INFO] [stdout] ... | [INFO] [stdout] 437 | | None [INFO] [stdout] 438 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fio/mod.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(f: W) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | writer: RwLock::new(Writer::new(BufWriter::new(f))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icbiadb` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `ICBIA_STAMP` is never used [INFO] [stdout] --> src/byte_size.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 11 | pub const ICBIA_STAMP: usize = 5; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 34 | let f = std::fs::OpenOptions::new() [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | let mut reader = fio::reader::Reader::new(BufReader::new(f)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(KvDb:: { [INFO] [stdout] | ________^ [INFO] [stdout] 50 | | file_name: file_name.to_string(), [INFO] [stdout] 51 | | records: reader.read_kv_records()?, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn read_from(read: R) -> std::io::Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | let mut reader = fio::reader::Reader::new(BufReader::new(read)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(KvDb:: { [INFO] [stdout] | ________^ [INFO] [stdout] 72 | | file_name: String::new(), [INFO] [stdout] 73 | | records: reader.read_kv_records()?, [INFO] [stdout] 74 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:393:9 [INFO] [stdout] | [INFO] [stdout] 389 | fn filter(&self, cb: F) -> Vec<(&BvString, &BvObject)> [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | (&self.records).into_iter().filter(|t| cb(*t)).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:404:9 [INFO] [stdout] | [INFO] [stdout] 402 | fn starts_with>(&self, key_part: S) -> Vec<(&BvString, &BvObject)> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | let k_part = key_part.as_ref().as_bytes(); [INFO] [stdout] 404 | / (&self.records) [INFO] [stdout] 405 | | .into_iter() [INFO] [stdout] 406 | | .filter_map(|(k, v)| { [INFO] [stdout] 407 | | if k.starts_with(k_part) { [INFO] [stdout] ... | [INFO] [stdout] 411 | | None [INFO] [stdout] 412 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 416 | fn ends_with>(&self, key_part: S) -> Vec<(&BvString, &BvObject)> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | / (&self.records) [INFO] [stdout] 418 | | .into_iter() [INFO] [stdout] 419 | | .filter_map(|(k, v)| { [INFO] [stdout] 420 | | if k.ends_with(key_part.as_ref().as_bytes()) { [INFO] [stdout] ... | [INFO] [stdout] 424 | | None [INFO] [stdout] 425 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/kv/mod.rs:430:9 [INFO] [stdout] | [INFO] [stdout] 429 | fn contains>(&self, key_part: S) -> Vec<(&BvString, &BvObject)> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 430 | / (&self.records) [INFO] [stdout] 431 | | .into_iter() [INFO] [stdout] 432 | | .filter_map(|(k, v)| { [INFO] [stdout] 433 | | if k.contains(key_part.as_ref()) { [INFO] [stdout] ... | [INFO] [stdout] 437 | | None [INFO] [stdout] 438 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fio/mod.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(f: W) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | writer: RwLock::new(Writer::new(BufWriter::new(f))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `icbiadb` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "18fb488f36cd0861b25d03e5db30423cc15bb51723b1f3e8e8c00946796fc19e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18fb488f36cd0861b25d03e5db30423cc15bb51723b1f3e8e8c00946796fc19e", kill_on_drop: false }` [INFO] [stdout] 18fb488f36cd0861b25d03e5db30423cc15bb51723b1f3e8e8c00946796fc19e