[INFO] fetching crate ic_candy 0.2.0... [INFO] checking ic_candy-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ic_candy 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ic_candy 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ic_candy 0.2.0 [INFO] finished tweaking crates.io crate ic_candy 0.2.0 [INFO] tweaked toml for crates.io crate ic_candy 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding ic-cdk v0.14.1 (latest: v0.16.0) [INFO] [stderr] Adding ic-cdk-macros v0.14.0 (latest: v0.16.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding yansi v0.5.1 (latest: v1.0.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 416356b0fb13c8fb8dc9a815d63b1245889862e0a24aa3d1c96f472e49aa0284 [INFO] running `Command { std: "docker" "start" "-a" "416356b0fb13c8fb8dc9a815d63b1245889862e0a24aa3d1c96f472e49aa0284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "416356b0fb13c8fb8dc9a815d63b1245889862e0a24aa3d1c96f472e49aa0284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "416356b0fb13c8fb8dc9a815d63b1245889862e0a24aa3d1c96f472e49aa0284", kill_on_drop: false }` [INFO] [stdout] 416356b0fb13c8fb8dc9a815d63b1245889862e0a24aa3d1c96f472e49aa0284 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63ff8da8276ea9dc264dfc97946cf61a48549c0bcfda6b4469a6d0288c4d0ca6 [INFO] running `Command { std: "docker" "start" "-a" "63ff8da8276ea9dc264dfc97946cf61a48549c0bcfda6b4469a6d0288c4d0ca6", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling psm v0.1.22 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling cpufeatures v0.2.13 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling typed-arena v2.0.2 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling pretty v0.12.3 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crypto-common v0.1.6 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Checking ic0 v0.23.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Compiling sha2 v0.10.8 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling candid_derive v0.6.6 [INFO] [stderr] Compiling binread v2.2.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking ic_principal v0.1.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling serde_tokenstream v0.2.2 [INFO] [stderr] Checking candid v0.10.10 [INFO] [stderr] Compiling ic-cdk-macros v0.14.0 [INFO] [stderr] Checking ic-cdk v0.14.1 [INFO] [stderr] Checking ic_candy v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:38:62 [INFO] [stdout] | [INFO] [stdout] 38 | let prop_strings: Vec = props.iter().map(|p| p.clone().to_json()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:415:30 [INFO] [stdout] | [INFO] [stdout] 415 | .map(|i| i.clone().to_json()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 152 | fn to_bytes_buffer(self) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | / self.into_iter() [INFO] [stdout] 154 | | .map(DataChunk::to_blob) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:222:89 [INFO] [stdout] | [INFO] [stdout] 222 | current_zone.resize_with((chunk.1 + 1) as usize, || CandyShared::Option(None)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic_candy` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types.rs:38:62 [INFO] [stdout] | [INFO] [stdout] 38 | let prop_strings: Vec = props.iter().map(|p| p.clone().to_json()).collect(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:415:30 [INFO] [stdout] | [INFO] [stdout] 415 | .map(|i| i.clone().to_json()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 152 | fn to_bytes_buffer(self) -> Vec> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | / self.into_iter() [INFO] [stdout] 154 | | .map(DataChunk::to_blob) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/workspace.rs:222:89 [INFO] [stdout] | [INFO] [stdout] 222 | current_zone.resize_with((chunk.1 + 1) as usize, || CandyShared::Option(None)); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic_candy` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "63ff8da8276ea9dc264dfc97946cf61a48549c0bcfda6b4469a6d0288c4d0ca6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63ff8da8276ea9dc264dfc97946cf61a48549c0bcfda6b4469a6d0288c4d0ca6", kill_on_drop: false }` [INFO] [stdout] 63ff8da8276ea9dc264dfc97946cf61a48549c0bcfda6b4469a6d0288c4d0ca6