[INFO] fetching crate ic-pluto 0.3.3... [INFO] checking ic-pluto-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ic-pluto 0.3.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate ic-pluto 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ic-pluto 0.3.3 [INFO] finished tweaking crates.io crate ic-pluto 0.3.3 [INFO] tweaked toml for crates.io crate ic-pluto 0.3.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 92 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding ic-cdk v0.13.5 (latest: v0.16.0) [INFO] [stderr] Adding ic-cdk-macros v0.13.2 (latest: v0.16.0) [INFO] [stderr] Adding ic0 v0.21.1 (latest: v0.23.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding serde_tokenstream v0.1.7 (latest: v0.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 402d45c96c8b364d87cc5fc595f04eef203814a60a414a5b570caff961185c6b [INFO] running `Command { std: "docker" "start" "-a" "402d45c96c8b364d87cc5fc595f04eef203814a60a414a5b570caff961185c6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "402d45c96c8b364d87cc5fc595f04eef203814a60a414a5b570caff961185c6b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "402d45c96c8b364d87cc5fc595f04eef203814a60a414a5b570caff961185c6b", kill_on_drop: false }` [INFO] [stdout] 402d45c96c8b364d87cc5fc595f04eef203814a60a414a5b570caff961185c6b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e3c472a0383763563fdecb378fbf5a722fe4f474a34ab07335a733c12edf523 [INFO] running `Command { std: "docker" "start" "-a" "1e3c472a0383763563fdecb378fbf5a722fe4f474a34ab07335a733c12edf523", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling psm v0.1.22 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling candid_derive v0.6.6 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Compiling pretty v0.12.3 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking ic0 v0.21.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking ic_principal v0.1.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Compiling serde_tokenstream v0.1.7 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Checking binread v2.2.0 [INFO] [stderr] Checking candid v0.10.10 [INFO] [stderr] Checking ic-pluto v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `is_safe` and `is_idempotent` are never used [INFO] [stdout] --> src/method.rs:149:19 [INFO] [stdout] | [INFO] [stdout] 70 | impl Method { [INFO] [stdout] | ----------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 149 | pub(crate) fn is_safe(&self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 161 | pub(crate) fn is_idempotent(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http.rs:320:26 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn new_with_router(r: Router, init_name: &str) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 320 | cors_policy: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:158:36 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn get(&mut self, path: &str, upgrade: bool, handler: impl Handler + 'static) -> &mut Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | self.handle(path, upgrade, Method::GET, handler) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:191:36 [INFO] [stdout] | [INFO] [stdout] 189 | handler: impl Handler + 'static, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | ) -> &mut Self { [INFO] [stdout] 191 | self.handle(path, upgrade, Method::HEAD, handler) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:224:36 [INFO] [stdout] | [INFO] [stdout] 222 | handler: impl Handler + 'static, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | ) -> &mut Self { [INFO] [stdout] 224 | self.handle(path, upgrade, Method::OPTIONS, handler) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:257:36 [INFO] [stdout] | [INFO] [stdout] 255 | handler: impl Handler + 'static, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | ) -> &mut Self { [INFO] [stdout] 257 | self.handle(path, upgrade, Method::POST, handler) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:285:36 [INFO] [stdout] | [INFO] [stdout] 284 | pub fn put(&mut self, path: &str, upgrade: bool, handler: impl Handler + 'static) -> &mut Self { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | self.handle(path, upgrade, Method::PUT, handler) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:318:36 [INFO] [stdout] | [INFO] [stdout] 316 | handler: impl Handler + 'static, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 317 | ) -> &mut Self { [INFO] [stdout] 318 | self.handle(path, upgrade, Method::PATCH, handler) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:351:36 [INFO] [stdout] | [INFO] [stdout] 349 | handler: impl Handler + 'static, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 350 | ) -> &mut Self { [INFO] [stdout] 351 | self.handle(path, upgrade, Method::DELETE, handler) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:442:49 [INFO] [stdout] | [INFO] [stdout] 442 | .filter(|&method| method != Method::OPTIONS) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/router.rs:451:45 [INFO] [stdout] | [INFO] [stdout] 451 | .filter(|&method| method != Method::OPTIONS) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-pluto` (lib) due to 11 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1e3c472a0383763563fdecb378fbf5a722fe4f474a34ab07335a733c12edf523", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e3c472a0383763563fdecb378fbf5a722fe4f474a34ab07335a733c12edf523", kill_on_drop: false }` [INFO] [stdout] 1e3c472a0383763563fdecb378fbf5a722fe4f474a34ab07335a733c12edf523