[INFO] fetching crate ic-kit 0.5.0-alpha.4... [INFO] checking ic-kit-0.5.0-alpha.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ic-kit 0.5.0-alpha.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ic-kit 0.5.0-alpha.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ic-kit 0.5.0-alpha.4 [INFO] finished tweaking crates.io crate ic-kit 0.5.0-alpha.4 [INFO] tweaked toml for crates.io crate ic-kit 0.5.0-alpha.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 158 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding candid v0.7.18 (latest: v0.10.10) [INFO] [stderr] Adding candid_derive v0.4.5 (latest: v0.6.6) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding ic-types v0.4.2 (latest: v0.7.0) [INFO] [stderr] Adding ic-types v0.5.0 (latest: v0.7.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding lalrpop v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.19.12 (latest: v0.21.0) [INFO] [stderr] Adding logos v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding logos-derive v0.12.1 (latest: v0.14.1) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding phf_shared v0.10.0 (latest: v0.11.2) [INFO] [stderr] Adding pretty v0.10.0 (latest: v0.12.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding serde_tokenstream v0.1.7 (latest: v0.2.2) [INFO] [stderr] Adding siphasher v0.3.11 (latest: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding term v0.7.0 (latest: v1.0.0) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] edfa56782db325bd58131143b59178a4db09b1fb65913589b7fb5db687bba24c [INFO] running `Command { std: "docker" "start" "-a" "edfa56782db325bd58131143b59178a4db09b1fb65913589b7fb5db687bba24c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "edfa56782db325bd58131143b59178a4db09b1fb65913589b7fb5db687bba24c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edfa56782db325bd58131143b59178a4db09b1fb65913589b7fb5db687bba24c", kill_on_drop: false }` [INFO] [stdout] edfa56782db325bd58131143b59178a4db09b1fb65913589b7fb5db687bba24c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 762f736ae8aef0d5d7794b2f723add2937784c05cc00a00d56200bdf09d88a00 [INFO] running `Command { std: "docker" "start" "-a" "762f736ae8aef0d5d7794b2f723add2937784c05cc00a00d56200bdf09d88a00", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling lalrpop-util v0.19.12 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Checking binread v2.2.0 [INFO] [stderr] Compiling num_enum_derive v0.5.11 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking pretty v0.10.0 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Compiling candid_derive v0.4.5 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Compiling actix_derive v0.6.1 [INFO] [stderr] Checking num_enum v0.5.11 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking ic-kit-sys v0.1.3 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking thread-local-panic-hook v0.1.0 [INFO] [stderr] Checking actix v0.13.5 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking ic-types v0.5.0 [INFO] [stderr] Checking ic-types v0.4.2 [INFO] [stderr] Compiling serde_tokenstream v0.1.7 [INFO] [stderr] Compiling ic-kit-macros v0.1.1-alpha.0 [INFO] [stderr] Compiling candid v0.7.18 [INFO] [stderr] Checking ic-kit-runtime v0.1.0-alpha.1 [INFO] [stderr] Checking ic-kit v0.5.0-alpha.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures.rs:95:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | WasmCell(Arc::new(InnerCell::new(val))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::into_raw` that must be used [INFO] [stdout] --> src/futures.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | Box::into_raw(boxed_future_ptr_ptr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 321 | let _ = Box::into_raw(boxed_future_ptr_ptr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::into_raw` that must be used [INFO] [stdout] --> src/futures.rs:322:13 [INFO] [stdout] | [INFO] [stdout] 322 | Box::into_raw(boxed_future); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 322 | let _ = Box::into_raw(boxed_future); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:25:45 [INFO] [stdout] | [INFO] [stdout] 25 | .or_insert_with(|| RefCell::new(Box::new(T::default()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn maybe_with U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let tid = TypeId::of::(); [INFO] [stdout] 49 | / unsafe { self.storage.try_borrow_unguarded() } [INFO] [stdout] 50 | | .unwrap() [INFO] [stdout] 51 | | .get(&tid) [INFO] [stdout] 52 | | .map(|c| c.borrow()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn maybe_with U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | .map(|c| callback(c.borrow().downcast_ref::().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn maybe_with_mut U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let tid = TypeId::of::(); [INFO] [stdout] 74 | / unsafe { self.storage.try_borrow_unguarded() } [INFO] [stdout] 75 | | .unwrap() [INFO] [stdout] 76 | | .get(&tid) [INFO] [stdout] 77 | | .map(|c| c.borrow_mut()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn maybe_with_mut U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | .map(|mut c| callback(c.borrow_mut().downcast_mut::().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:88:26 [INFO] [stdout] | [INFO] [stdout] 88 | .map(|cell| *cell.into_inner().downcast::().unwrap()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn swap(&self, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let tid = TypeId::of::(); [INFO] [stdout] 95 | match self.storage.borrow_mut().entry(tid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:156:53 [INFO] [stdout] | [INFO] [stdout] 156 | .or_insert_with(|| RefCell::new(Box::new($name::default()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | / implement_borrow_many!( [INFO] [stdout] 209 | | (A0) [INFO] [stdout] 210 | | (A0 A1) [INFO] [stdout] 211 | | (A0 A1 A3) [INFO] [stdout] ... | [INFO] [stdout] 217 | | (A0 A1 A3 A4 A5 A6 A7 A8 A9) [INFO] [stdout] 218 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `implement_borrow_many` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:185:53 [INFO] [stdout] | [INFO] [stdout] 185 | .or_insert_with(|| RefCell::new(Box::new($name::default()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | / implement_borrow_many!( [INFO] [stdout] 209 | | (A0) [INFO] [stdout] 210 | | (A0 A1) [INFO] [stdout] 211 | | (A0 A1 A3) [INFO] [stdout] ... | [INFO] [stdout] 217 | | (A0 A1 A3 A4 A5 A6 A7 A8 A9) [INFO] [stdout] 218 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `implement_borrow_many` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn with U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | STORAGE.with(|storage| storage.with(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn maybe_with U>(callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | STORAGE.with(|storage| storage.maybe_with(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn with_mut U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | STORAGE.with(|storage| storage.with_mut(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn maybe_with_mut U>(callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | STORAGE.with(|storage| storage.maybe_with_mut(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn swap(value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | STORAGE.with(|storage| storage.swap(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn with_many U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | STORAGE.with(|storage| storage.with_many(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:103:18 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn with_many_mut U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | STORAGE.with(|storage| storage.with_many_mut(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/futures.rs:95:22 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(val: T) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | WasmCell(Arc::new(InnerCell::new(val))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::into_raw` that must be used [INFO] [stdout] --> src/futures.rs:321:13 [INFO] [stdout] | [INFO] [stdout] 321 | Box::into_raw(boxed_future_ptr_ptr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 321 | let _ = Box::into_raw(boxed_future_ptr_ptr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::into_raw` that must be used [INFO] [stdout] --> src/futures.rs:322:13 [INFO] [stdout] | [INFO] [stdout] 322 | Box::into_raw(boxed_future); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 322 | let _ = Box::into_raw(boxed_future); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:25:45 [INFO] [stdout] | [INFO] [stdout] 25 | .or_insert_with(|| RefCell::new(Box::new(T::default()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn maybe_with U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let tid = TypeId::of::(); [INFO] [stdout] 49 | / unsafe { self.storage.try_borrow_unguarded() } [INFO] [stdout] 50 | | .unwrap() [INFO] [stdout] 51 | | .get(&tid) [INFO] [stdout] 52 | | .map(|c| c.borrow()) [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:53:18 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn maybe_with U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | .map(|c| callback(c.borrow().downcast_ref::().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn maybe_with_mut U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | let tid = TypeId::of::(); [INFO] [stdout] 74 | / unsafe { self.storage.try_borrow_unguarded() } [INFO] [stdout] 75 | | .unwrap() [INFO] [stdout] 76 | | .get(&tid) [INFO] [stdout] 77 | | .map(|c| c.borrow_mut()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:78:18 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn maybe_with_mut U>(&self, callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | .map(|mut c| callback(c.borrow_mut().downcast_mut::().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:88:26 [INFO] [stdout] | [INFO] [stdout] 88 | .map(|cell| *cell.into_inner().downcast::().unwrap()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn swap(&self, value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let tid = TypeId::of::(); [INFO] [stdout] 95 | match self.storage.borrow_mut().entry(tid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:156:53 [INFO] [stdout] | [INFO] [stdout] 156 | .or_insert_with(|| RefCell::new(Box::new($name::default()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | / implement_borrow_many!( [INFO] [stdout] 209 | | (A0) [INFO] [stdout] 210 | | (A0 A1) [INFO] [stdout] 211 | | (A0 A1 A3) [INFO] [stdout] ... | [INFO] [stdout] 217 | | (A0 A1 A3 A4 A5 A6 A7 A8 A9) [INFO] [stdout] 218 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `implement_borrow_many` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage.rs:185:53 [INFO] [stdout] | [INFO] [stdout] 185 | .or_insert_with(|| RefCell::new(Box::new($name::default()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 208 | / implement_borrow_many!( [INFO] [stdout] 209 | | (A0) [INFO] [stdout] 210 | | (A0 A1) [INFO] [stdout] 211 | | (A0 A1 A3) [INFO] [stdout] ... | [INFO] [stdout] 217 | | (A0 A1 A3 A4 A5 A6 A7 A8 A9) [INFO] [stdout] 218 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `implement_borrow_many` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:16:18 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn with U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | STORAGE.with(|storage| storage.with(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn maybe_with U>(callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | STORAGE.with(|storage| storage.maybe_with(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn with_mut U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | STORAGE.with(|storage| storage.with_mut(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-kit` (lib test) due to 18 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn maybe_with_mut U>(callback: F) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | STORAGE.with(|storage| storage.maybe_with_mut(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:50:18 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn swap(value: T) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | STORAGE.with(|storage| storage.swap(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn with_many U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | STORAGE.with(|storage| storage.with_many(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ic/storage.rs:103:18 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn with_many_mut U>(callback: F) -> U { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | STORAGE.with(|storage| storage.with_many_mut(callback)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-kit` (lib) due to 18 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "762f736ae8aef0d5d7794b2f723add2937784c05cc00a00d56200bdf09d88a00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "762f736ae8aef0d5d7794b2f723add2937784c05cc00a00d56200bdf09d88a00", kill_on_drop: false }` [INFO] [stdout] 762f736ae8aef0d5d7794b2f723add2937784c05cc00a00d56200bdf09d88a00