[INFO] fetching crate ic-http-certification 2.6.0... [INFO] checking ic-http-certification-2.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ic-http-certification 2.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate ic-http-certification 2.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ic-http-certification 2.6.0 [INFO] finished tweaking crates.io crate ic-http-certification 2.6.0 [INFO] tweaked toml for crates.io crate ic-http-certification 2.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 90 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding rstest v0.18.2 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.18.2 (latest: v0.22.0) [INFO] [stderr] Adding rstest_reuse v0.2.0 (latest: v0.7.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6ca9967f75e3bab9083159c7434f8f7812603f4ae7a6d085345451b7254b938 [INFO] running `Command { std: "docker" "start" "-a" "c6ca9967f75e3bab9083159c7434f8f7812603f4ae7a6d085345451b7254b938", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6ca9967f75e3bab9083159c7434f8f7812603f4ae7a6d085345451b7254b938", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6ca9967f75e3bab9083159c7434f8f7812603f4ae7a6d085345451b7254b938", kill_on_drop: false }` [INFO] [stdout] c6ca9967f75e3bab9083159c7434f8f7812603f4ae7a6d085345451b7254b938 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bcccb72a35c00b58641444c7531f38ceadb688506e25eae59a9bbcae2c2e7cea [INFO] running `Command { std: "docker" "start" "-a" "bcccb72a35c00b58641444c7531f38ceadb688506e25eae59a9bbcae2c2e7cea", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking cpufeatures v0.2.13 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling rstest_macros v0.18.2 [INFO] [stderr] Compiling psm v0.1.22 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking leb128 v0.2.5 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking pretty v0.12.3 [INFO] [stderr] Compiling rstest_reuse v0.2.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking ic-certification v2.6.0 [INFO] [stderr] Checking ic-representation-independent-hash v2.6.0 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling candid_derive v0.6.6 [INFO] [stderr] Checking binread v2.2.0 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking rstest v0.18.2 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking ic_principal v0.1.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking candid v0.10.10 [INFO] [stderr] Checking ic-http-certification v2.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/certification_tree.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 65 | let witness = match entry.path.get_type() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let witness = self.tree.witness(&requested_tree_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let witness = merge_hash_trees(witness, self.tree.witness(&responding_tree_path)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(labeled(PATH_PREFIX_BYTES, witness)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/certification_tree.rs:91:47 [INFO] [stdout] | [INFO] [stdout] 90 | .fold(witness, |acc, path| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | merge_hash_trees(acc, self.tree.witness(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-http-certification` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/certification_tree.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 65 | let witness = match entry.path.get_type() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let witness = self.tree.witness(&requested_tree_path); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let witness = merge_hash_trees(witness, self.tree.witness(&responding_tree_path)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(labeled(PATH_PREFIX_BYTES, witness)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree/certification_tree.rs:91:47 [INFO] [stdout] | [INFO] [stdout] 90 | .fold(witness, |acc, path| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | merge_hash_trees(acc, self.tree.witness(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-http-certification` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "bcccb72a35c00b58641444c7531f38ceadb688506e25eae59a9bbcae2c2e7cea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bcccb72a35c00b58641444c7531f38ceadb688506e25eae59a9bbcae2c2e7cea", kill_on_drop: false }` [INFO] [stdout] bcccb72a35c00b58641444c7531f38ceadb688506e25eae59a9bbcae2c2e7cea