[INFO] fetching crate ic-certified-map 0.4.0... [INFO] checking ic-certified-map-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ic-certified-map 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate ic-certified-map 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ic-certified-map 0.4.0 [INFO] finished tweaking crates.io crate ic-certified-map 0.4.0 [INFO] tweaked toml for crates.io crate ic-certified-map 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 77 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding candid v0.9.11 (latest: v0.10.10) [INFO] [stderr] Adding candid_derive v0.6.4 (latest: v0.6.6) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding ic-cdk v0.10.1 (latest: v0.16.0) [INFO] [stderr] Adding ic-cdk-macros v0.7.1 (latest: v0.16.0) [INFO] [stderr] Adding ic0 v0.18.11 (latest: v0.23.0) [INFO] [stderr] Adding num_enum v0.6.1 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.6.1 (latest: v0.7.3) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding serde_tokenstream v0.1.7 (latest: v0.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a11a9d034b2fdf3d68105ad953695a82328fa4be1adcd45ad2bb0013a1c4276c [INFO] running `Command { std: "docker" "start" "-a" "a11a9d034b2fdf3d68105ad953695a82328fa4be1adcd45ad2bb0013a1c4276c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a11a9d034b2fdf3d68105ad953695a82328fa4be1adcd45ad2bb0013a1c4276c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a11a9d034b2fdf3d68105ad953695a82328fa4be1adcd45ad2bb0013a1c4276c", kill_on_drop: false }` [INFO] [stdout] a11a9d034b2fdf3d68105ad953695a82328fa4be1adcd45ad2bb0013a1c4276c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 687ff6db4acb30d8c0f489cb8ac8e848e5524eb6231f9ce98006581a8f50ac63 [INFO] running `Command { std: "docker" "start" "-a" "687ff6db4acb30d8c0f489cb8ac8e848e5524eb6231f9ce98006581a8f50ac63", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Compiling candid v0.9.11 [INFO] [stderr] Compiling psm v0.1.22 [INFO] [stderr] Compiling stacker v0.1.17 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling cpufeatures v0.2.13 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling typed-arena v2.0.2 [INFO] [stderr] Compiling arrayvec v0.5.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling codespan-reporting v0.11.1 [INFO] [stderr] Compiling pretty v0.12.3 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling data-encoding v2.6.0 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking ic0 v0.18.11 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling num_enum_derive v0.6.1 [INFO] [stderr] Compiling candid_derive v0.6.4 [INFO] [stderr] Compiling num_enum v0.6.1 [INFO] [stderr] Compiling binread_derive v2.1.0 [INFO] [stderr] Compiling binread v2.2.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking ic-certified-map v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling serde_tokenstream v0.1.7 [INFO] [stdout] warning: struct `DebugView` is never constructed [INFO] [stdout] --> src/rbtree.rs:994:8 [INFO] [stdout] | [INFO] [stdout] 994 | struct DebugView<'a, K, V>(&'a NodeRef); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashtree.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn fork<'a>(l: HashTree<'a>, r: HashTree<'a>) -> HashTree<'a> { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | HashTree::Fork(Box::new((l, r))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hashtree.rs:35:26 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn labeled<'a>(l: &'a [u8], t: HashTree<'a>) -> HashTree<'a> { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | HashTree::Labeled(l, Box::new(t)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree.rs:109:18 [INFO] [stdout] | [INFO] [stdout] 106 | fn new(key: K, value: V) -> Box> { [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Box::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 110 | | key, [INFO] [stdout] 111 | | value, [INFO] [stdout] 112 | | left: None, [INFO] [stdout] ... | [INFO] [stdout] 115 | | subtree_hash: data_hash, [INFO] [stdout] 116 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree.rs:153:36 [INFO] [stdout] | [INFO] [stdout] 152 | fn subtree_with<'a>(&'a self, f: impl FnOnce(&'a V) -> HashTree<'a>) -> HashTree<'a> { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | labeled(self.key.as_ref(), f(&self.value)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree.rs:714:33 [INFO] [stdout] | [INFO] [stdout] 712 | f: impl FnOnce(&'a V) -> HashTree<'a>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 713 | ) -> Option> { [INFO] [stdout] 714 | n.as_ref().and_then(|n| match key.cmp(n.key.as_ref()) { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 715 | | Equal => Some(three_way_fork( [INFO] [stdout] 716 | | n.left_hash_tree(), [INFO] [stdout] 717 | | n.subtree_with(f), [INFO] [stdout] ... | [INFO] [stdout] 735 | | } [INFO] [stdout] 736 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree.rs:827:18 [INFO] [stdout] | [INFO] [stdout] 815 | mut h: Box>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 827 | Some(balance(h)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree.rs:864:18 [INFO] [stdout] | [INFO] [stdout] 831 | mut h: Box>, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 864 | Some(balance(h)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbtree.rs:892:11 [INFO] [stdout] | [INFO] [stdout] 891 | fn three_way_fork<'a>(l: HashTree<'a>, m: HashTree<'a>, r: HashTree<'a>) -> HashTree<'a> { [INFO] [stdout] | --------------- --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 892 | match (l, m, r) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ic-certified-map` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "687ff6db4acb30d8c0f489cb8ac8e848e5524eb6231f9ce98006581a8f50ac63", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "687ff6db4acb30d8c0f489cb8ac8e848e5524eb6231f9ce98006581a8f50ac63", kill_on_drop: false }` [INFO] [stdout] 687ff6db4acb30d8c0f489cb8ac8e848e5524eb6231f9ce98006581a8f50ac63