[INFO] fetching crate i3-workspace-groups 0.2.2... [INFO] checking i3-workspace-groups-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate i3-workspace-groups 0.2.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate i3-workspace-groups 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate i3-workspace-groups 0.2.2 [INFO] finished tweaking crates.io crate i3-workspace-groups 0.2.2 [INFO] tweaked toml for crates.io crate i3-workspace-groups 0.2.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 55 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.6.2 (latest: v0.11.5) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (latest: v2.1.0) [INFO] [stderr] Adding i3ipc v0.9.0 (latest: v0.10.1) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding structopt v0.2.18 (latest: v0.3.26) [INFO] [stderr] Adding structopt-derive v0.2.18 (latest: v0.4.18) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcd7c2ff2a21fa8bd1829861a31c0c6074975fec569638d98067d7178a1f6c8d [INFO] running `Command { std: "docker" "start" "-a" "dcd7c2ff2a21fa8bd1829861a31c0c6074975fec569638d98067d7178a1f6c8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcd7c2ff2a21fa8bd1829861a31c0c6074975fec569638d98067d7178a1f6c8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcd7c2ff2a21fa8bd1829861a31c0c6074975fec569638d98067d7178a1f6c8d", kill_on_drop: false }` [INFO] [stdout] dcd7c2ff2a21fa8bd1829861a31c0c6074975fec569638d98067d7178a1f6c8d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 249da6fdcb3d3c17a279a6bd5c78decd7dd36c838c7a16f047f8cf843aa76641 [INFO] running `Command { std: "docker" "start" "-a" "249da6fdcb3d3c17a279a6bd5c78decd7dd36c838c7a16f047f8cf843aa76641", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking i3ipc v0.9.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling structopt-derive v0.2.18 [INFO] [stderr] Checking structopt v0.2.18 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking i3-workspace-groups v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/common.rs:40:61 [INFO] [stdout] | [INFO] [stdout] 40 | $e.keys().map(|key| &key[..]).collect::>(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] ::: src/controller.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | keys_to_strptr_vec!(self.get_groups()) [INFO] [stdout] | -------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `keys_to_strptr_vec` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `keys_to_strptr_vec` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trailing semicolon in macro used in expression position [INFO] [stdout] --> src/common.rs:40:61 [INFO] [stdout] | [INFO] [stdout] 40 | $e.keys().map(|key| &key[..]).collect::>(); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] ::: src/controller.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | keys_to_strptr_vec!(self.get_groups()) [INFO] [stdout] | -------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = note: for more information, see issue #79813 [INFO] [stdout] = note: macro invocations at the end of a block are treated as expressions [INFO] [stdout] = note: to ignore the value produced by the macro, add a semicolon after the invocation of `keys_to_strptr_vec` [INFO] [stdout] = note: `#[warn(semicolon_in_expressions_from_macros)]` on by default [INFO] [stdout] = note: this warning originates in the macro `keys_to_strptr_vec` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(i3connection: I3Connection, dry_run: bool) -> WorkspaceGroupsController { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | WorkspaceGroupsController { [INFO] [stdout] 90 | i3connection: Mutex::new(i3connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(i3connection: I3Connection, dry_run: bool) -> WorkspaceGroupsController { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | WorkspaceGroupsController { [INFO] [stdout] 90 | i3connection: Mutex::new(i3connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `i3-workspace-groups` (bin "i3-workspace-groups" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `i3-workspace-groups` (bin "i3-workspace-groups") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "249da6fdcb3d3c17a279a6bd5c78decd7dd36c838c7a16f047f8cf843aa76641", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "249da6fdcb3d3c17a279a6bd5c78decd7dd36c838c7a16f047f8cf843aa76641", kill_on_drop: false }` [INFO] [stdout] 249da6fdcb3d3c17a279a6bd5c78decd7dd36c838c7a16f047f8cf843aa76641