[INFO] fetching crate hzrd 0.0.6... [INFO] checking hzrd-0.0.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hzrd 0.0.6 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate hzrd 0.0.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hzrd 0.0.6 [INFO] finished tweaking crates.io crate hzrd 0.0.6 [INFO] tweaked toml for crates.io crate hzrd 0.0.6 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate hzrd 0.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdc58a8f8a9cc6b23778894f02e786dbbe85f90d5c9e1881557dfc3ae9cae07b [INFO] running `Command { std: "docker" "start" "-a" "cdc58a8f8a9cc6b23778894f02e786dbbe85f90d5c9e1881557dfc3ae9cae07b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdc58a8f8a9cc6b23778894f02e786dbbe85f90d5c9e1881557dfc3ae9cae07b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdc58a8f8a9cc6b23778894f02e786dbbe85f90d5c9e1881557dfc3ae9cae07b", kill_on_drop: false }` [INFO] [stdout] cdc58a8f8a9cc6b23778894f02e786dbbe85f90d5c9e1881557dfc3ae9cae07b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eb490fdc0044149659936e6317f6ce734ee28c0b6ae981d786857ae0cfe5b3f6 [INFO] running `Command { std: "docker" "start" "-a" "eb490fdc0044149659936e6317f6ce734ee28c0b6ae981d786857ae0cfe5b3f6", kill_on_drop: false }` [INFO] [stderr] Checking hzrd v0.0.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains.rs:126:34 [INFO] [stdout] | [INFO] [stdout] 124 | fn new<'t>(hzrd_ptrs: impl Iterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Self { [INFO] [stdout] 126 | list: Vec::from_iter(hzrd_ptrs.map(HzrdPtr::get)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains.rs:274:37 [INFO] [stdout] | [INFO] [stdout] 273 | fn just_retire(&self, ret_ptr: RetiredPtr) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | LOCAL_RETIRED_POINTERS.with(|cell| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 275 | | let retired_ptrs = unsafe { &mut *cell.0.get() }; [INFO] [stdout] 276 | | retired_ptrs.push(ret_ptr) [INFO] [stdout] 277 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains.rs:283:68 [INFO] [stdout] | [INFO] [stdout] 283 | let hzrd_ptrs = || hzrd_ptrs.get_or_init(|| HzrdPtrs::load(HAZARD_POINTERS.iter())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hzrd` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains.rs:126:34 [INFO] [stdout] | [INFO] [stdout] 124 | fn new<'t>(hzrd_ptrs: impl Iterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Self { [INFO] [stdout] 126 | list: Vec::from_iter(hzrd_ptrs.map(HzrdPtr::get)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains.rs:274:37 [INFO] [stdout] | [INFO] [stdout] 273 | fn just_retire(&self, ret_ptr: RetiredPtr) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | LOCAL_RETIRED_POINTERS.with(|cell| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 275 | | let retired_ptrs = unsafe { &mut *cell.0.get() }; [INFO] [stdout] 276 | | retired_ptrs.push(ret_ptr) [INFO] [stdout] 277 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domains.rs:283:68 [INFO] [stdout] | [INFO] [stdout] 283 | let hzrd_ptrs = || hzrd_ptrs.get_or_init(|| HzrdPtrs::load(HAZARD_POINTERS.iter())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hzrd` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "eb490fdc0044149659936e6317f6ce734ee28c0b6ae981d786857ae0cfe5b3f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb490fdc0044149659936e6317f6ce734ee28c0b6ae981d786857ae0cfe5b3f6", kill_on_drop: false }` [INFO] [stdout] eb490fdc0044149659936e6317f6ce734ee28c0b6ae981d786857ae0cfe5b3f6