[INFO] fetching crate hypersync-format 0.2.4... [INFO] checking hypersync-format-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hypersync-format 0.2.4 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate hypersync-format 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hypersync-format 0.2.4 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate hypersync-format 0.2.4 [INFO] tweaked toml for crates.io crate hypersync-format 0.2.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 163 packages to latest compatible versions [INFO] [stderr] Adding alloy-primitives v0.7.7 (latest: v0.8.0) [INFO] [stderr] Adding ark-ff v0.3.0 (latest: v0.4.2) [INFO] [stderr] Adding ark-ff-asm v0.3.0 (latest: v0.4.2) [INFO] [stderr] Adding ark-ff-macros v0.3.0 (latest: v0.4.2) [INFO] [stderr] Adding ark-serialize v0.3.0 (latest: v0.4.2) [INFO] [stderr] Adding ark-std v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustc_version v0.3.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.11.0 (latest: v1.0.23) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 31d99afcf26e1a01725f011ddd962fdc3c037408c6300b758b8feb40f8737878 [INFO] running `Command { std: "docker" "start" "-a" "31d99afcf26e1a01725f011ddd962fdc3c037408c6300b758b8feb40f8737878", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "31d99afcf26e1a01725f011ddd962fdc3c037408c6300b758b8feb40f8737878", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "31d99afcf26e1a01725f011ddd962fdc3c037408c6300b758b8feb40f8737878", kill_on_drop: false }` [INFO] [stdout] 31d99afcf26e1a01725f011ddd962fdc3c037408c6300b758b8feb40f8737878 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dcb5180753fb4d64e8e9d44d08fa6745cb21daa9c68f58ebcf1e3c0fc9bcb6db [INFO] running `Command { std: "docker" "start" "-a" "dcb5180753fb4d64e8e9d44d08fa6745cb21daa9c68f58ebcf1e3c0fc9bcb6db", kill_on_drop: false }` [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling ruint-macro v1.2.1 [INFO] [stderr] Checking fastrange-rs v0.1.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Compiling convert_case v0.6.0 [INFO] [stderr] Checking const-hex v1.12.0 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking xxhash-rust v0.8.12 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking sbbf-rs v0.2.8 [INFO] [stderr] Checking sbbf-rs-safe v0.3.2 [INFO] [stderr] Checking ruint v1.12.3 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking alloy-primitives v0.7.7 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_test v1.0.177 [INFO] [stderr] Checking hypersync-format v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/bloom_filter_wrapper.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn from_keys<'a, I>(keys: I, bits_per_key: Option) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let keys = keys.into_iter().map(xxh3_64).collect::>(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut filter = Filter::new(bits_per_key, num_keys); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(FilterWrapper(filter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/bloom_filter_wrapper.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | let data = Data::decode_hex(hex)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / Filter::from_bytes(data.as_ref()) [INFO] [stdout] 113 | | .ok_or(Error::BloomFilterFromBytes) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(Data::from(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/fixed_size_data.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 65 | let buf: Box<[u8; N]> = buf.try_into().map_err(|_| Error::UnexpectedLength { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(FixedSizeData(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/fixed_size_data.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | Self::Value::try_from(buf).map_err(|e| E::custom(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/quantity.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | Ok(Quantity::from(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hypersync-format` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/bloom_filter_wrapper.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn from_keys<'a, I>(keys: I, bits_per_key: Option) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let keys = keys.into_iter().map(xxh3_64).collect::>(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut filter = Filter::new(bits_per_key, num_keys); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(FilterWrapper(filter)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/bloom_filter_wrapper.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 111 | let data = Data::decode_hex(hex)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | / Filter::from_bytes(data.as_ref()) [INFO] [stdout] 113 | | .ok_or(Error::BloomFilterFromBytes) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/data.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | Ok(Data::from(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/fixed_size_data.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 65 | let buf: Box<[u8; N]> = buf.try_into().map_err(|_| Error::UnexpectedLength { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(FixedSizeData(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/fixed_size_data.rs:100:9 [INFO] [stdout] | [INFO] [stdout] 100 | Self::Value::try_from(buf).map_err(|e| E::custom(e.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/quantity.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | Ok(Quantity::from(buf)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hypersync-format` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "dcb5180753fb4d64e8e9d44d08fa6745cb21daa9c68f58ebcf1e3c0fc9bcb6db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcb5180753fb4d64e8e9d44d08fa6745cb21daa9c68f58ebcf1e3c0fc9bcb6db", kill_on_drop: false }` [INFO] [stdout] dcb5180753fb4d64e8e9d44d08fa6745cb21daa9c68f58ebcf1e3c0fc9bcb6db