[INFO] fetching crate hyperminhash 0.1.3... [INFO] checking hyperminhash-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hyperminhash 0.1.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate hyperminhash 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hyperminhash 0.1.3 [INFO] finished tweaking crates.io crate hyperminhash 0.1.3 [INFO] tweaked toml for crates.io crate hyperminhash 0.1.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate hyperminhash 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08aae569f3d48500418ef4531446a0854edf1a05c27ca0ea065aedc9c1680e50 [INFO] running `Command { std: "docker" "start" "-a" "08aae569f3d48500418ef4531446a0854edf1a05c27ca0ea065aedc9c1680e50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08aae569f3d48500418ef4531446a0854edf1a05c27ca0ea065aedc9c1680e50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08aae569f3d48500418ef4531446a0854edf1a05c27ca0ea065aedc9c1680e50", kill_on_drop: false }` [INFO] [stdout] 08aae569f3d48500418ef4531446a0854edf1a05c27ca0ea065aedc9c1680e50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af5170d28d9ae81cd08d268b519cb7f0703f03764d2a78664e6384509f37aa47 [INFO] running `Command { std: "docker" "start" "-a" "af5170d28d9ae81cd08d268b519cb7f0703f03764d2a78664e6384509f37aa47", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking xxhash-rust v0.8.10 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking hyperminhash v0.1.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/parallel.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 28 | fn new(num_threads: usize, init: U, f: V) -> (channel::Sender, Self) [INFO] [stdout] | ------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let (s, recv) = channel::bounded(num_threads + 1); [INFO] [stdout] | - ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let t = (0..num_threads) [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | (s, AsyncSink { t }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/parallel.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 38 | let state = Arc::new(Mutex::new(init())); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let t_state = state.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let t_recv = recv.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let t_f = f.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | / thread::spawn(move || { [INFO] [stdout] 45 | | for item in t_recv { [INFO] [stdout] 46 | | t_f(&mut t_state.lock().unwrap(), item)?; [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | Ok(t_state) [INFO] [stdout] 49 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/parallel.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn join(self) -> thread::Result, E>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 67 | / self.t [INFO] [stdout] 68 | | .into_iter() [INFO] [stdout] 69 | | .map(|t| t.1.join()) [INFO] [stdout] 70 | | .map(|r| { [INFO] [stdout] ... | [INFO] [stdout] 79 | | }) [INFO] [stdout] 80 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/parallel.rs:91:41 [INFO] [stdout] | [INFO] [stdout] 91 | .fold(state, |st, t| f(st, &t.0.lock().unwrap())) [INFO] [stdout] | -- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/parallel.rs:172:42 [INFO] [stdout] | [INFO] [stdout] 172 | String::from_utf8(items).map(|s| lines(&s).for_each(|l| sk.add_bytes(l.as_bytes()))) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hyperminhash` (example "parallel") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "af5170d28d9ae81cd08d268b519cb7f0703f03764d2a78664e6384509f37aa47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af5170d28d9ae81cd08d268b519cb7f0703f03764d2a78664e6384509f37aa47", kill_on_drop: false }` [INFO] [stdout] af5170d28d9ae81cd08d268b519cb7f0703f03764d2a78664e6384509f37aa47