[INFO] fetching crate hyena 0.2.4... [INFO] checking hyena-0.2.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hyena 0.2.4 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate hyena 0.2.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hyena 0.2.4 [INFO] finished tweaking crates.io crate hyena 0.2.4 [INFO] tweaked toml for crates.io crate hyena 0.2.4 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8554e23fb8716135b7ad5d74fafa2cf2e3d116e95b94bde82b240bd9e8a5779 [INFO] running `Command { std: "docker" "start" "-a" "f8554e23fb8716135b7ad5d74fafa2cf2e3d116e95b94bde82b240bd9e8a5779", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8554e23fb8716135b7ad5d74fafa2cf2e3d116e95b94bde82b240bd9e8a5779", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8554e23fb8716135b7ad5d74fafa2cf2e3d116e95b94bde82b240bd9e8a5779", kill_on_drop: false }` [INFO] [stdout] f8554e23fb8716135b7ad5d74fafa2cf2e3d116e95b94bde82b240bd9e8a5779 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50f5ab594246d8fa689b1c2b636f884b00bd20e78b4275232a0046bd56728315 [INFO] running `Command { std: "docker" "start" "-a" "50f5ab594246d8fa689b1c2b636f884b00bd20e78b4275232a0046bd56728315", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking hyena v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | GLOBAL_POOL.get_or_init(|| TaskPool::new().expect("Failed to create global task pool.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 129 | let shutdown = Event::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | [INFO] [stdout] 131 | let executor = Arc::new(Executor::new()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let threads: Vec<_> = (0..num_threads) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | executor, [INFO] [stdout] 163 | | inner: Arc::new(TaskPoolInner { threads, shutdown }), [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:151:38 [INFO] [stdout] | [INFO] [stdout] 137 | let executor = executor.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let shutdown = shutdown.listen(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | thread_builder.spawn(move || { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 152 | | let fut = executor.run(shutdown); [INFO] [stdout] 153 | | future::block_on(fut); [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:179:19 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn spawn(&self, future: impl Future + Send + 'static) -> Task [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Task::new(self.executor.spawn(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:188:19 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn spawn_local(&self, future: impl Future + 'static) -> Task [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Task::new(Self::LOCAL_EXECUTOR.with(|executor| executor.spawn(future))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hyena` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:105:36 [INFO] [stdout] | [INFO] [stdout] 105 | GLOBAL_POOL.get_or_init(|| TaskPool::new().expect("Failed to create global task pool.")) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:161:12 [INFO] [stdout] | [INFO] [stdout] 129 | let shutdown = Event::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | [INFO] [stdout] 131 | let executor = Arc::new(Executor::new()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | let threads: Vec<_> = (0..num_threads) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 162 | | executor, [INFO] [stdout] 163 | | inner: Arc::new(TaskPoolInner { threads, shutdown }), [INFO] [stdout] 164 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:151:38 [INFO] [stdout] | [INFO] [stdout] 137 | let executor = executor.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let shutdown = shutdown.listen(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | thread_builder.spawn(move || { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 152 | | let fut = executor.run(shutdown); [INFO] [stdout] 153 | | future::block_on(fut); [INFO] [stdout] 154 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:179:19 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn spawn(&self, future: impl Future + Send + 'static) -> Task [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Task::new(self.executor.spawn(future)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task_pool.rs:188:19 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn spawn_local(&self, future: impl Future + 'static) -> Task [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | Task::new(Self::LOCAL_EXECUTOR.with(|executor| executor.spawn(future))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hyena` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "50f5ab594246d8fa689b1c2b636f884b00bd20e78b4275232a0046bd56728315", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50f5ab594246d8fa689b1c2b636f884b00bd20e78b4275232a0046bd56728315", kill_on_drop: false }` [INFO] [stdout] 50f5ab594246d8fa689b1c2b636f884b00bd20e78b4275232a0046bd56728315