[INFO] fetching crate hydroflow_cli_integration 0.5.2... [INFO] checking hydroflow_cli_integration-0.5.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hydroflow_cli_integration 0.5.2 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate hydroflow_cli_integration 0.5.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hydroflow_cli_integration 0.5.2 [INFO] finished tweaking crates.io crate hydroflow_cli_integration 0.5.2 [INFO] tweaked toml for crates.io crate hydroflow_cli_integration 0.5.2 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 62d2740d0b1d6d68f10a82e78b2bc6b3af87f1cd08355f35d584f84c69b65b92 [INFO] running `Command { std: "docker" "start" "-a" "62d2740d0b1d6d68f10a82e78b2bc6b3af87f1cd08355f35d584f84c69b65b92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "62d2740d0b1d6d68f10a82e78b2bc6b3af87f1cd08355f35d584f84c69b65b92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "62d2740d0b1d6d68f10a82e78b2bc6b3af87f1cd08355f35d584f84c69b65b92", kill_on_drop: false }` [INFO] [stdout] 62d2740d0b1d6d68f10a82e78b2bc6b3af87f1cd08355f35d584f84c69b65b92 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f2dc942b55ef71a4dd0d661de4b3a10d0247875ad26e99d831021ca98fdb81d [INFO] running `Command { std: "docker" "start" "-a" "6f2dc942b55ef71a4dd0d661de4b3a10d0247875ad26e99d831021ca98fdb81d", kill_on_drop: false }` [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking hydroflow_cli_integration v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:77 [INFO] [stdout] | [INFO] [stdout] 89 | RealizedServerPort::Demux(bindings.iter().map(|(k, v)| (*k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:54 [INFO] [stdout] | [INFO] [stdout] 124 | let bound = UnixListener::bind(socket_path).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | BoundConnection::UnixSocket( [INFO] [stdout] 126 | tokio::spawn(async move { Ok(bound.accept().await?.0) }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:37 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn connect_local_blocking(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let _guard = handle.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | futures::executor::block_on(T::from_defn(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:387:53 [INFO] [stdout] | [INFO] [stdout] 387 | async fn from_defn(pipe: ServerOrBound) -> Self { [INFO] [stdout] | ________________________-------------------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | | match pipe { [INFO] [stdout] 389 | | ServerOrBound::Server(RealizedServerPort::UnixSocket(stream)) => { [INFO] [stdout] 390 | | #[cfg(unix)] [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:89:77 [INFO] [stdout] | [INFO] [stdout] 89 | RealizedServerPort::Demux(bindings.iter().map(|(k, v)| (*k, v.into())).collect()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 416 | let sources = futures::future::join_all(merge.into_iter().map(|port| async { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | / ConnectedDirect::from_defn(ServerOrBound::Server(port)) [INFO] [stdout] 418 | | .await [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:126:54 [INFO] [stdout] | [INFO] [stdout] 124 | let bound = UnixListener::bind(socket_path).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | BoundConnection::UnixSocket( [INFO] [stdout] 126 | tokio::spawn(async move { Ok(bound.accept().await?.0) }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:543:53 [INFO] [stdout] | [INFO] [stdout] 543 | async fn from_defn(pipe: ServerOrBound) -> Self { [INFO] [stdout] | ________________________-------------------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 544 | | match pipe { [INFO] [stdout] 545 | | ServerOrBound::Server(RealizedServerPort::Demux(demux)) => { [INFO] [stdout] 546 | | let mut connected_demux = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 597 | | } [INFO] [stdout] 598 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:609:9 [INFO] [stdout] | [INFO] [stdout] 608 | fn into_sink(mut self) -> Self::Sink { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 609 | self.sink.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:177:37 [INFO] [stdout] | [INFO] [stdout] 174 | pub fn connect_local_blocking(self) -> T { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let handle = tokio::runtime::Handle::current(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let _guard = handle.enter(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | futures::executor::block_on(T::from_defn(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:691:53 [INFO] [stdout] | [INFO] [stdout] 691 | async fn from_defn(pipe: ServerOrBound) -> Self { [INFO] [stdout] | ________________________-------------------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 692 | | let sources = match pipe { [INFO] [stdout] 693 | | ServerOrBound::Server(RealizedServerPort::Tagged(pipe, id)) => { [INFO] [stdout] 694 | | vec![( [INFO] [stdout] ... | [INFO] [stdout] 772 | | ConnectedTagged { source: muxer } [INFO] [stdout] 773 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:387:53 [INFO] [stdout] | [INFO] [stdout] 387 | async fn from_defn(pipe: ServerOrBound) -> Self { [INFO] [stdout] | ________________________-------------------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | | match pipe { [INFO] [stdout] 389 | | ServerOrBound::Server(RealizedServerPort::UnixSocket(stream)) => { [INFO] [stdout] 390 | | #[cfg(unix)] [INFO] [stdout] ... | [INFO] [stdout] 451 | | } [INFO] [stdout] 452 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:21 [INFO] [stdout] | [INFO] [stdout] 416 | let sources = futures::future::join_all(merge.into_iter().map(|port| async { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 417 | / ConnectedDirect::from_defn(ServerOrBound::Server(port)) [INFO] [stdout] 418 | | .await [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:543:53 [INFO] [stdout] | [INFO] [stdout] 543 | async fn from_defn(pipe: ServerOrBound) -> Self { [INFO] [stdout] | ________________________-------------------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 544 | | match pipe { [INFO] [stdout] 545 | | ServerOrBound::Server(RealizedServerPort::Demux(demux)) => { [INFO] [stdout] 546 | | let mut connected_demux = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 597 | | } [INFO] [stdout] 598 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:609:9 [INFO] [stdout] | [INFO] [stdout] 608 | fn into_sink(mut self) -> Self::Sink { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 609 | self.sink.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hydroflow_cli_integration` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:691:53 [INFO] [stdout] | [INFO] [stdout] 691 | async fn from_defn(pipe: ServerOrBound) -> Self { [INFO] [stdout] | ________________________-------------------__________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 692 | | let sources = match pipe { [INFO] [stdout] 693 | | ServerOrBound::Server(RealizedServerPort::Tagged(pipe, id)) => { [INFO] [stdout] 694 | | vec![( [INFO] [stdout] ... | [INFO] [stdout] 772 | | ConnectedTagged { source: muxer } [INFO] [stdout] 773 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hydroflow_cli_integration` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "6f2dc942b55ef71a4dd0d661de4b3a10d0247875ad26e99d831021ca98fdb81d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f2dc942b55ef71a4dd0d661de4b3a10d0247875ad26e99d831021ca98fdb81d", kill_on_drop: false }` [INFO] [stdout] 6f2dc942b55ef71a4dd0d661de4b3a10d0247875ad26e99d831021ca98fdb81d