[INFO] fetching crate hydrate-base 0.0.2... [INFO] checking hydrate-base-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hydrate-base 0.0.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate hydrate-base 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hydrate-base 0.0.2 [INFO] finished tweaking crates.io crate hydrate-base 0.0.2 [INFO] tweaked toml for crates.io crate hydrate-base 0.0.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 29 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ed656e43ce0ab082107adec89c177ae6b93eaa2b0a1eaa4e30d3cdaeeb841f6 [INFO] running `Command { std: "docker" "start" "-a" "0ed656e43ce0ab082107adec89c177ae6b93eaa2b0a1eaa4e30d3cdaeeb841f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ed656e43ce0ab082107adec89c177ae6b93eaa2b0a1eaa4e30d3cdaeeb841f6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ed656e43ce0ab082107adec89c177ae6b93eaa2b0a1eaa4e30d3cdaeeb841f6", kill_on_drop: false }` [INFO] [stdout] 0ed656e43ce0ab082107adec89c177ae6b93eaa2b0a1eaa4e30d3cdaeeb841f6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f85da2ffa0c69b36589905429ba2620ea1c229c70c9ebb5f35e84650bce6f3f [INFO] running `Command { std: "docker" "start" "-a" "7f85da2ffa0c69b36589905429ba2620ea1c229c70c9ebb5f35e84650bce6f3f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking const-fnv1a-hash v1.1.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking hydrate-base v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 275 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 280 | | resolved_load_handle, [INFO] [stdout] 281 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 282 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:293:25 [INFO] [stdout] | [INFO] [stdout] 289 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 294 | | resolved_load_handle, [INFO] [stdout] 295 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 296 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:330:25 [INFO] [stdout] | [INFO] [stdout] 326 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 331 | | resolved_load_handle, [INFO] [stdout] 332 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 333 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:343:25 [INFO] [stdout] | [INFO] [stdout] 339 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 344 | | resolved_load_handle, [INFO] [stdout] 345 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 346 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:401:21 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | //LOADER.with(|l| REFOP_SENDER.with(|r| f(*l, r))) [INFO] [stdout] 401 | LOADER.with(|loader| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 402 | | //*loader.borrow_mut() = Some(loader_info_provider); [INFO] [stdout] 403 | | REFOP_SENDER.with(|refop_sender| { [INFO] [stdout] 404 | | (f)( [INFO] [stdout] ... | [INFO] [stdout] 414 | | //output [INFO] [stdout] 415 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:403:31 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | REFOP_SENDER.with(|refop_sender| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 404 | | (f)( [INFO] [stdout] 405 | | *loader.borrow().as_ref().unwrap(), [INFO] [stdout] 406 | | refop_sender.borrow().as_ref().unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 411 | | //output [INFO] [stdout] 412 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:405:22 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | *loader.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:406:21 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | refop_sender.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:433:21 [INFO] [stdout] | [INFO] [stdout] 420 | sender: Sender, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | LOADER.with(|loader| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 434 | | *loader.borrow_mut() = Some(loader_info_provider); [INFO] [stdout] 435 | | let output = REFOP_SENDER.with(|refop_sender| { [INFO] [stdout] 436 | | *refop_sender.borrow_mut() = Some(sender); [INFO] [stdout] ... | [INFO] [stdout] 442 | | output [INFO] [stdout] 443 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:490:22 [INFO] [stdout] | [INFO] [stdout] 484 | let (tx, _) = crossbeam_channel::unbounded(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | current: Mutex::new(DummySerdeContextCurrent { [INFO] [stdout] | ______________________^ [INFO] [stdout] 491 | | current_serde_dependencies: HashSet::new(), [INFO] [stdout] 492 | | current_serde_artifact: None, [INFO] [stdout] 493 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:518:14 [INFO] [stdout] | [INFO] [stdout] 505 | let mut maps = self.maps.write().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | Some(Arc::new(ResolvedLoadHandle { [INFO] [stdout] | ______________^ [INFO] [stdout] 519 | | id: *handle, [INFO] [stdout] 520 | | direct_load_handle: AtomicU64::new(handle.0), [INFO] [stdout] 521 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:627:31 [INFO] [stdout] | [INFO] [stdout] 622 | serializer: S, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 627 | SerdeContext::with_active(|loader, _| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 628 | | use ser::SerializeSeq; [INFO] [stdout] 629 | | let uuid_bytes: uuid::Bytes = *loader [INFO] [stdout] 630 | | .artifact_id(load) [INFO] [stdout] ... | [INFO] [stdout] 638 | | seq.end() [INFO] [stdout] 639 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:673:18 [INFO] [stdout] | [INFO] [stdout] 666 | let handle = if artifact_ref == ArtifactRef(ArtifactId::default()) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 673 | (handle, sender.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:688:12 [INFO] [stdout] | [INFO] [stdout] 678 | fn deserialize(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 687 | let (handle, sender) = get_handle_ref(artifact_ref); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 688 | Ok(Handle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:703:12 [INFO] [stdout] | [INFO] [stdout] 693 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 702 | let (handle, sender) = get_handle_ref(artifact_ref); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 703 | Ok(GenericHandle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:909:26 [INFO] [stdout] | [INFO] [stdout] 906 | let load_handle = loader_info_provider [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 909 | Handle::::new(ref_op_sender.clone(), load_handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hydrate-base` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 275 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 280 | | resolved_load_handle, [INFO] [stdout] 281 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 282 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:293:25 [INFO] [stdout] | [INFO] [stdout] 289 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 290 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 294 | | resolved_load_handle, [INFO] [stdout] 295 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 296 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:330:25 [INFO] [stdout] | [INFO] [stdout] 326 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 331 | | resolved_load_handle, [INFO] [stdout] 332 | | ref_type: HandleRefType::Strong(chan), [INFO] [stdout] 333 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:343:25 [INFO] [stdout] | [INFO] [stdout] 339 | chan: Sender, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | resolved_load_handle: Arc, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | handle_ref: HandleRef { [INFO] [stdout] | _________________________^ [INFO] [stdout] 344 | | resolved_load_handle, [INFO] [stdout] 345 | | ref_type: HandleRefType::Internal(chan), [INFO] [stdout] 346 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:401:21 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | ------------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 400 | //LOADER.with(|l| REFOP_SENDER.with(|r| f(*l, r))) [INFO] [stdout] 401 | LOADER.with(|loader| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 402 | | //*loader.borrow_mut() = Some(loader_info_provider); [INFO] [stdout] 403 | | REFOP_SENDER.with(|refop_sender| { [INFO] [stdout] 404 | | (f)( [INFO] [stdout] ... | [INFO] [stdout] 414 | | //output [INFO] [stdout] 415 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:403:31 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | REFOP_SENDER.with(|refop_sender| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 404 | | (f)( [INFO] [stdout] 405 | | *loader.borrow().as_ref().unwrap(), [INFO] [stdout] 406 | | refop_sender.borrow().as_ref().unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 411 | | //output [INFO] [stdout] 412 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:405:22 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | *loader.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:406:21 [INFO] [stdout] | [INFO] [stdout] 399 | pub fn with_active(f: impl FnOnce(&dyn LoaderInfoProvider, &Sender) -> R) -> R { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 406 | refop_sender.borrow().as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:433:21 [INFO] [stdout] | [INFO] [stdout] 420 | sender: Sender, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 433 | LOADER.with(|loader| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 434 | | *loader.borrow_mut() = Some(loader_info_provider); [INFO] [stdout] 435 | | let output = REFOP_SENDER.with(|refop_sender| { [INFO] [stdout] 436 | | *refop_sender.borrow_mut() = Some(sender); [INFO] [stdout] ... | [INFO] [stdout] 442 | | output [INFO] [stdout] 443 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:490:22 [INFO] [stdout] | [INFO] [stdout] 484 | let (tx, _) = crossbeam_channel::unbounded(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 490 | current: Mutex::new(DummySerdeContextCurrent { [INFO] [stdout] | ______________________^ [INFO] [stdout] 491 | | current_serde_dependencies: HashSet::new(), [INFO] [stdout] 492 | | current_serde_artifact: None, [INFO] [stdout] 493 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:518:14 [INFO] [stdout] | [INFO] [stdout] 505 | let mut maps = self.maps.write().unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 518 | Some(Arc::new(ResolvedLoadHandle { [INFO] [stdout] | ______________^ [INFO] [stdout] 519 | | id: *handle, [INFO] [stdout] 520 | | direct_load_handle: AtomicU64::new(handle.0), [INFO] [stdout] 521 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:627:31 [INFO] [stdout] | [INFO] [stdout] 622 | serializer: S, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 627 | SerdeContext::with_active(|loader, _| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 628 | | use ser::SerializeSeq; [INFO] [stdout] 629 | | let uuid_bytes: uuid::Bytes = *loader [INFO] [stdout] 630 | | .artifact_id(load) [INFO] [stdout] ... | [INFO] [stdout] 638 | | seq.end() [INFO] [stdout] 639 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:673:18 [INFO] [stdout] | [INFO] [stdout] 666 | let handle = if artifact_ref == ArtifactRef(ArtifactId::default()) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 673 | (handle, sender.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:688:12 [INFO] [stdout] | [INFO] [stdout] 678 | fn deserialize(deserializer: D) -> Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 687 | let (handle, sender) = get_handle_ref(artifact_ref); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 688 | Ok(Handle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:703:12 [INFO] [stdout] | [INFO] [stdout] 693 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 702 | let (handle, sender) = get_handle_ref(artifact_ref); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 703 | Ok(GenericHandle::new_internal(sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handle.rs:909:26 [INFO] [stdout] | [INFO] [stdout] 906 | let load_handle = loader_info_provider [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 909 | Handle::::new(ref_op_sender.clone(), load_handle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hydrate-base` (lib test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "7f85da2ffa0c69b36589905429ba2620ea1c229c70c9ebb5f35e84650bce6f3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f85da2ffa0c69b36589905429ba2620ea1c229c70c9ebb5f35e84650bce6f3f", kill_on_drop: false }` [INFO] [stdout] 7f85da2ffa0c69b36589905429ba2620ea1c229c70c9ebb5f35e84650bce6f3f