[INFO] fetching crate hxcfe 0.1.5... [INFO] checking hxcfe-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hxcfe 0.1.5 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate hxcfe 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hxcfe 0.1.5 [INFO] finished tweaking crates.io crate hxcfe 0.1.5 [INFO] tweaked toml for crates.io crate hxcfe 0.1.5 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate hxcfe 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8e0efe7833344b12a726e9a3108e06b4486a17ae68ac130f3ac10801775f5317 [INFO] running `Command { std: "docker" "start" "-a" "8e0efe7833344b12a726e9a3108e06b4486a17ae68ac130f3ac10801775f5317", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8e0efe7833344b12a726e9a3108e06b4486a17ae68ac130f3ac10801775f5317", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8e0efe7833344b12a726e9a3108e06b4486a17ae68ac130f3ac10801775f5317", kill_on_drop: false }` [INFO] [stdout] 8e0efe7833344b12a726e9a3108e06b4486a17ae68ac130f3ac10801775f5317 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e6652fc0e359bb46c119764790893869ae93be72173de6669d5cb8c85d46a71 [INFO] running `Command { std: "docker" "start" "-a" "2e6652fc0e359bb46c119764790893869ae93be72173de6669d5cb8c85d46a71", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling rustix v0.38.15 [INFO] [stderr] Compiling prettyplease v0.2.15 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling memchr v2.6.3 [INFO] [stderr] Compiling linux-raw-sys v0.4.8 [INFO] [stderr] Compiling bitflags v2.4.0 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling bindgen v0.68.1 [INFO] [stderr] Compiling home v0.5.5 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Compiling walkdir v2.4.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling shlex v1.2.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling make-cmd v0.1.0 [INFO] [stderr] Compiling dunce v1.0.4 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling copy_dir v0.1.3 [INFO] [stderr] Compiling clang-sys v1.6.1 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling regex-automata v0.3.9 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling regex v1.9.6 [INFO] [stderr] Compiling enumn v0.1.12 [INFO] [stderr] Compiling hxcadaptor-sys v0.1.5 [INFO] [stderr] Compiling hxcfe-sys v0.1.5 [INFO] [stderr] Checking hxcfe v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `HXCFE_VALIDFILE` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | HXCFE_VALIDFILE = 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeValidfile` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_NOERROR` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | HXCFE_NOERROR = 0, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeNoerror` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_ACCESSERROR` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | HXCFE_ACCESSERROR = -1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeAccesserror` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_BADFILE` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | HXCFE_BADFILE = -2, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeBadfile` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_FILECORRUPTED` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | HXCFE_FILECORRUPTED = -3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeFilecorrupted` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_BADPARAMETER` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | HXCFE_BADPARAMETER = -4, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeBadparameter` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_INTERNALERROR` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | HXCFE_INTERNALERROR = -5, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeInternalerror` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_UNSUPPORTEDFILE` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | HXCFE_UNSUPPORTEDFILE = -6, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeUnsupportedfile` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Amiga_Mfm` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | Amiga_Mfm = AMIGA_MFM_ENCODING, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `AmigaMfm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_VALIDFILE` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | HXCFE_VALIDFILE = 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeValidfile` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_NOERROR` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | HXCFE_NOERROR = 0, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeNoerror` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_ACCESSERROR` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | HXCFE_ACCESSERROR = -1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeAccesserror` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_BADFILE` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | HXCFE_BADFILE = -2, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeBadfile` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_FILECORRUPTED` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | HXCFE_FILECORRUPTED = -3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeFilecorrupted` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_BADPARAMETER` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | HXCFE_BADPARAMETER = -4, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeBadparameter` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_INTERNALERROR` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | HXCFE_INTERNALERROR = -5, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeInternalerror` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `HXCFE_UNSUPPORTEDFILE` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | HXCFE_UNSUPPORTEDFILE = -6, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `HxcfeUnsupportedfile` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Amiga_Mfm` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | Amiga_Mfm = AMIGA_MFM_ENCODING, [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to upper camel case: `AmigaMfm` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `img` is never read [INFO] [stdout] --> src/sector_access.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct SectorAccess<'img> { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 11 | img: &'img Img, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn load>(&self, p: P) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let manager = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / loader [INFO] [stdout] 151 | | .load(&p) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `img` is never read [INFO] [stdout] --> src/sector_access.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct SectorAccess<'img> { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 11 | img: &'img Img, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn load>(&self, p: P) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | let manager = self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | / loader [INFO] [stdout] 151 | | .load(&p) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `FSENTRY_` does not permit being left uninitialized [INFO] [stdout] --> src/fs_manager.rs:77:49 [INFO] [stdout] | [INFO] [stdout] 77 | let mut entry: HXCFE_FSENTRY = unsafe { MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `FSENTRY_` does not permit being left uninitialized [INFO] [stdout] --> src/fs_manager.rs:77:49 [INFO] [stdout] | [INFO] [stdout] 77 | let mut entry: HXCFE_FSENTRY = unsafe { MaybeUninit::uninit().assume_init() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: integers must be initialized [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hxcfe` (lib) due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hxcfe` (lib test) due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2e6652fc0e359bb46c119764790893869ae93be72173de6669d5cb8c85d46a71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e6652fc0e359bb46c119764790893869ae93be72173de6669d5cb8c85d46a71", kill_on_drop: false }` [INFO] [stdout] 2e6652fc0e359bb46c119764790893869ae93be72173de6669d5cb8c85d46a71