[INFO] fetching crate hugr-passes 0.8.0... [INFO] checking hugr-passes-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate hugr-passes 0.8.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate hugr-passes 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate hugr-passes 0.8.0 [INFO] finished tweaking crates.io crate hugr-passes 0.8.0 [INFO] tweaked toml for crates.io crate hugr-passes 0.8.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 84 packages to latest compatible versions [INFO] [stderr] Adding approx v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding fixedbitset v0.4.2 (latest: v0.5.7) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b90b24295dedb8ea58342f3dab47d677b8f9e0a338e19aeec6197460e53e1d54 [INFO] running `Command { std: "docker" "start" "-a" "b90b24295dedb8ea58342f3dab47d677b8f9e0a338e19aeec6197460e53e1d54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b90b24295dedb8ea58342f3dab47d677b8f9e0a338e19aeec6197460e53e1d54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b90b24295dedb8ea58342f3dab47d677b8f9e0a338e19aeec6197460e53e1d54", kill_on_drop: false }` [INFO] [stdout] b90b24295dedb8ea58342f3dab47d677b8f9e0a338e19aeec6197460e53e1d54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d99a6144bd2f15b88645955a22269a20872df548c9d3d9cfcb9835b1c252c2e [INFO] running `Command { std: "docker" "start" "-a" "8d99a6144bd2f15b88645955a22269a20872df548c9d3d9cfcb9835b1c252c2e", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling typeid v1.0.2 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling delegate v0.12.0 [INFO] [stderr] Compiling typetag-impl v0.2.18 [INFO] [stderr] Compiling rstest_macros v0.22.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking context-iterators v0.2.0 [INFO] [stderr] Checking html-escape v0.2.13 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking typetag v0.2.18 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking portgraph v0.12.2 [INFO] [stderr] Checking hugr-core v0.9.0 [INFO] [stderr] Checking rstest v0.22.0 [INFO] [stderr] Checking hugr-passes v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 110 | fn const_graph(consts: Vec, reg: &ExtensionRegistry) -> Hugr { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let const_types = consts.iter().map(Value::get_type).collect_vec(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let mut b = DFGBuilder::new(inout_sig(type_row![], const_types)).unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | b.finish_hugr_with_outputs(outputs, reg).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 131 | candidate_nodes: impl IntoIterator + 'a, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / candidate_nodes [INFO] [stdout] 138 | | .into_iter() [INFO] [stdout] 139 | | .filter_map(move |n| { [INFO] [stdout] 140 | | // only look at LoadConstant [INFO] [stdout] ... | [INFO] [stdout] 155 | | Some(fold_iter) [INFO] [stdout] 156 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:197:10 [INFO] [stdout] | [INFO] [stdout] 168 | let (in_consts, removals): (Vec<_>, Vec<_>) = hugr [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let (nu_out, consts): (HashMap<_, _>, Vec<_>) = fold_leaf_op(neighbour_op, &in_consts)? [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let replacement = const_graph(consts, reg); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let simple_replace = SimpleReplacement::new( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Some((simple_replace, removals)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:172:18 [INFO] [stdout] | [INFO] [stdout] 171 | let (con_op, load_n) = get_const(hugr, op_node, in_p)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Some(((in_p, con_op), RemoveLoadConstant(load_n))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 179 | .filter_map(|(i, (op_out, konst))| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | .map(|np| ((np, i.into()), konst)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 130 | fn empty(graph: G, rank: F) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | ordered: graph.visit_map(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:136:22 [INFO] [stdout] | [INFO] [stdout] 130 | fn empty(graph: G, rank: F) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | tovisit: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:148:35 [INFO] [stdout] | [INFO] [stdout] 148 | .filter(move |&a| g.neighbors_directed(a, Incoming).next().is_none()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:154:52 [INFO] [stdout] | [INFO] [stdout] 154 | .extend(new_nodes.into_iter().map(|x| (Reverse((self.rank)(x)), x))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nest_cfgs.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 475 | let mut s = Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | / s.edge_classes [INFO] [stdout] 485 | | .into_iter() [INFO] [stdout] 486 | | .map(|(k, v)| { [INFO] [stdout] 487 | | let l = cycle_class_idxs.len(); [INFO] [stdout] 488 | | (k, *cycle_class_idxs.entry(v).or_insert(l)) [INFO] [stdout] 489 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/non_local.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 16 | hugr.in_value_types(node).filter_map(move |(in_p, _)| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let parent = hugr.get_parent(node); [INFO] [stdout] 18 | hugr.linked_outputs(node, in_p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validation.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 84 | mk_err: impl FnOnce(ValidationError, String) -> ValidatePassError, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / match self { [INFO] [stdout] 90 | | ValidationLevel::None => Ok(()), [INFO] [stdout] 91 | | ValidationLevel::WithoutExtensions => hugr.validate_no_extensions(reg), [INFO] [stdout] 92 | | ValidationLevel::WithExtensions => hugr.validate(reg), [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validation.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 84 | mk_err: impl FnOnce(ValidationError, String) -> ValidatePassError, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | .map_err(|err| mk_err(err, hugr.mermaid_string()).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validation.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 84 | mk_err: impl FnOnce(ValidationError, String) -> ValidatePassError, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | .map_err(|err| mk_err(err, hugr.mermaid_string()).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hugr-passes` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 110 | fn const_graph(consts: Vec, reg: &ExtensionRegistry) -> Hugr { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let const_types = consts.iter().map(Value::get_type).collect_vec(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let mut b = DFGBuilder::new(inout_sig(type_row![], const_types)).unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | b.finish_hugr_with_outputs(outputs, reg).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:137:5 [INFO] [stdout] | [INFO] [stdout] 131 | candidate_nodes: impl IntoIterator + 'a, [INFO] [stdout] | ---------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | / candidate_nodes [INFO] [stdout] 138 | | .into_iter() [INFO] [stdout] 139 | | .filter_map(move |n| { [INFO] [stdout] 140 | | // only look at LoadConstant [INFO] [stdout] ... | [INFO] [stdout] 155 | | Some(fold_iter) [INFO] [stdout] 156 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:197:10 [INFO] [stdout] | [INFO] [stdout] 168 | let (in_consts, removals): (Vec<_>, Vec<_>) = hugr [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | let (nu_out, consts): (HashMap<_, _>, Vec<_>) = fold_leaf_op(neighbour_op, &in_consts)? [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let replacement = const_graph(consts, reg); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let simple_replace = SimpleReplacement::new( [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | Some((simple_replace, removals)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:172:18 [INFO] [stdout] | [INFO] [stdout] 171 | let (con_op, load_n) = get_const(hugr, op_node, in_p)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | Some(((in_p, con_op), RemoveLoadConstant(load_n))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 179 | .filter_map(|(i, (op_out, konst))| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | .map(|np| ((np, i.into()), konst)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/const_fold/test.rs:262:30 [INFO] [stdout] | [INFO] [stdout] 241 | let mut build = DFGBuilder::new(noargfn(vec![BOOL_T])).unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let reg = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | ExtensionRegistry::try_new([PRELUDE.to_owned(), logic::EXTENSION.to_owned()]).unwrap(); [INFO] [stdout] 252 | let mut h = build.finish_hugr_with_outputs(r.outputs(), ®).unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | assert_fully_folded(&h, &Value::true_val()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 130 | fn empty(graph: G, rank: F) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 135 | ordered: graph.visit_map(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:136:22 [INFO] [stdout] | [INFO] [stdout] 130 | fn empty(graph: G, rank: F) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | tovisit: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:148:35 [INFO] [stdout] | [INFO] [stdout] 148 | .filter(move |&a| g.neighbors_directed(a, Incoming).next().is_none()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:154:52 [INFO] [stdout] | [INFO] [stdout] 154 | .extend(new_nodes.into_iter().map(|x| (Reverse((self.rank)(x)), x))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/force_order.rs:263:13 [INFO] [stdout] | [INFO] [stdout] 249 | let t = INT_TYPES[I as usize].clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let mut builder = DFGBuilder::new(endo_sig(vec![t.clone(), t.clone()])).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | / builder [INFO] [stdout] 264 | | .finish_hugr_with_outputs( [INFO] [stdout] 265 | | [v2.out_wire(0), v3.out_wire(0)], [INFO] [stdout] 266 | | &int_ops::INT_OPS_REGISTRY, [INFO] [stdout] 267 | | ) [INFO] [stdout] 268 | | .unwrap(), [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge_bbs.rs:277:25 [INFO] [stdout] | [INFO] [stdout] 277 | .filter(|n| h.get_optype(*n).cast::().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge_bbs.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 383 | fn find_unique(items: impl Iterator, pred: impl Fn(&T) -> bool) -> T { [INFO] [stdout] | ------------------------------ ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | items.filter(pred).exactly_one().ok().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nest_cfgs.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 475 | let mut s = Self { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 484 | / s.edge_classes [INFO] [stdout] 485 | | .into_iter() [INFO] [stdout] 486 | | .map(|(k, v)| { [INFO] [stdout] 487 | | let l = cycle_class_idxs.len(); [INFO] [stdout] 488 | | (k, *cycle_class_idxs.entry(v).or_insert(l)) [INFO] [stdout] 489 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nest_cfgs.rs:597:9 [INFO] [stdout] | [INFO] [stdout] 592 | pub fn group_by(h: HashMap) -> HashSet> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 593 | let mut res = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 597 | res.into_values().map(sorted).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nest_cfgs.rs:899:12 [INFO] [stdout] | [INFO] [stdout] 879 | let mut cfg_builder = CFGBuilder::new(Signature::new_endo(NAT))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 884 | cfg_builder.simple_entry_builder(type_row![NAT], 2)?, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 898 | let h = cfg_builder.finish_prelude_hugr()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 899 | Ok((h, merge, tail)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nest_cfgs.rs:909:12 [INFO] [stdout] | [INFO] [stdout] 906 | let mut cfg_builder = CFGBuilder::new(Signature::new_endo(NAT))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 907 | let (head, tail) = build_conditional_in_loop(&mut cfg_builder, separate_headers)?; [INFO] [stdout] 908 | let h = cfg_builder.finish_prelude_hugr()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 909 | Ok((h, head, tail)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/non_local.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 16 | hugr.in_value_types(node).filter_map(move |(in_p, _)| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let parent = hugr.get_parent(node); [INFO] [stdout] 18 | hugr.linked_outputs(node, in_p) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validation.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 84 | mk_err: impl FnOnce(ValidationError, String) -> ValidatePassError, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / match self { [INFO] [stdout] 90 | | ValidationLevel::None => Ok(()), [INFO] [stdout] 91 | | ValidationLevel::WithoutExtensions => hugr.validate_no_extensions(reg), [INFO] [stdout] 92 | | ValidationLevel::WithExtensions => hugr.validate(reg), [INFO] [stdout] 93 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validation.rs:94:18 [INFO] [stdout] | [INFO] [stdout] 84 | mk_err: impl FnOnce(ValidationError, String) -> ValidatePassError, [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | .map_err(|err| mk_err(err, hugr.mermaid_string()).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validation.rs:94:24 [INFO] [stdout] | [INFO] [stdout] 84 | mk_err: impl FnOnce(ValidationError, String) -> ValidatePassError, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | .map_err(|err| mk_err(err, hugr.mermaid_string()).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hugr-passes` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "8d99a6144bd2f15b88645955a22269a20872df548c9d3d9cfcb9835b1c252c2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d99a6144bd2f15b88645955a22269a20872df548c9d3d9cfcb9835b1c252c2e", kill_on_drop: false }` [INFO] [stdout] 8d99a6144bd2f15b88645955a22269a20872df548c9d3d9cfcb9835b1c252c2e